From shade at openjdk.org Tue Dec 10 17:11:22 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 10 Dec 2024 17:11:22 GMT Subject: RFR: 7903904: JOL: Switch to latest GHA runners Message-ID: Like JMH, we want to switch to latest GHA runners, to avoid chasing the ever-upgrading GHA infrastructure. ------------- Commit messages: - Fix Changes: https://git.openjdk.org/jol/pull/59/files Webrev: https://webrevs.openjdk.org/?repo=jol&pr=59&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903904 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jol/pull/59.diff Fetch: git fetch https://git.openjdk.org/jol.git pull/59/head:pull/59 PR: https://git.openjdk.org/jol/pull/59 From shade at openjdk.org Tue Dec 10 18:56:05 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 10 Dec 2024 18:56:05 GMT Subject: RFR: 7903904: JOL: Switch to latest GHA runners [v2] In-Reply-To: References: Message-ID: > Like JMH, we want to switch to latest GHA runners, to avoid chasing the ever-upgrading GHA infrastructure. Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: Update to Corretto, use more modern steps ------------- Changes: - all: https://git.openjdk.org/jol/pull/59/files - new: https://git.openjdk.org/jol/pull/59/files/440cb22e..94aa48c5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jol&pr=59&range=01 - incr: https://webrevs.openjdk.org/?repo=jol&pr=59&range=00-01 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jol/pull/59.diff Fetch: git fetch https://git.openjdk.org/jol.git pull/59/head:pull/59 PR: https://git.openjdk.org/jol/pull/59 From shade at openjdk.org Tue Dec 10 19:13:35 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 10 Dec 2024 19:13:35 GMT Subject: RFR: 7903904: JOL: Switch to latest GHA runners [v3] In-Reply-To: References: Message-ID: > Like JMH, we want to switch to latest GHA runners, to avoid chasing the ever-upgrading GHA infrastructure. Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: MacOS runners cannot complete the default tests? ------------- Changes: - all: https://git.openjdk.org/jol/pull/59/files - new: https://git.openjdk.org/jol/pull/59/files/94aa48c5..45ae2330 Webrevs: - full: https://webrevs.openjdk.org/?repo=jol&pr=59&range=02 - incr: https://webrevs.openjdk.org/?repo=jol&pr=59&range=01-02 Stats: 11 lines in 1 file changed: 0 ins; 11 del; 0 mod Patch: https://git.openjdk.org/jol/pull/59.diff Fetch: git fetch https://git.openjdk.org/jol.git pull/59/head:pull/59 PR: https://git.openjdk.org/jol/pull/59 From shade at openjdk.org Tue Dec 10 19:16:11 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 10 Dec 2024 19:16:11 GMT Subject: RFR: 7903904: JOL: Switch to latest GHA runners [v4] In-Reply-To: References: Message-ID: > Like JMH, we want to switch to latest GHA runners, to avoid chasing the ever-upgrading GHA infrastructure. Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: Properly skip default tests ------------- Changes: - all: https://git.openjdk.org/jol/pull/59/files - new: https://git.openjdk.org/jol/pull/59/files/45ae2330..73ee5ec6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jol&pr=59&range=03 - incr: https://webrevs.openjdk.org/?repo=jol&pr=59&range=02-03 Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jol/pull/59.diff Fetch: git fetch https://git.openjdk.org/jol.git pull/59/head:pull/59 PR: https://git.openjdk.org/jol/pull/59 From shade at openjdk.org Tue Dec 10 19:36:28 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 10 Dec 2024 19:36:28 GMT Subject: RFR: 7903904: JOL: Switch to latest GHA runners [v5] In-Reply-To: References: Message-ID: <-Y0E-pZdgdq81xdv3epupT3MzV6E-jk-XTOmihxFZrU=.b30ed341-ecc6-43b3-ba49-5dc72e7381be@github.com> > Like JMH, we want to switch to latest GHA runners, to avoid chasing the ever-upgrading GHA infrastructure. Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: Try with lower fork count ------------- Changes: - all: https://git.openjdk.org/jol/pull/59/files - new: https://git.openjdk.org/jol/pull/59/files/73ee5ec6..50562fce Webrevs: - full: https://webrevs.openjdk.org/?repo=jol&pr=59&range=04 - incr: https://webrevs.openjdk.org/?repo=jol&pr=59&range=03-04 Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jol/pull/59.diff Fetch: git fetch https://git.openjdk.org/jol.git pull/59/head:pull/59 PR: https://git.openjdk.org/jol/pull/59 From shade at openjdk.org Tue Dec 10 19:58:17 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 10 Dec 2024 19:58:17 GMT Subject: RFR: 7903904: JOL: Switch to latest GHA runners [v6] In-Reply-To: References: Message-ID: > Like JMH, we want to switch to latest GHA runners, to avoid chasing the ever-upgrading GHA infrastructure. Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: Shorter iterations ------------- Changes: - all: https://git.openjdk.org/jol/pull/59/files - new: https://git.openjdk.org/jol/pull/59/files/50562fce..6235a36b Webrevs: - full: https://webrevs.openjdk.org/?repo=jol&pr=59&range=05 - incr: https://webrevs.openjdk.org/?repo=jol&pr=59&range=04-05 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jol/pull/59.diff Fetch: git fetch https://git.openjdk.org/jol.git pull/59/head:pull/59 PR: https://git.openjdk.org/jol/pull/59 From shade at openjdk.org Wed Dec 11 12:23:08 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 11 Dec 2024 12:23:08 GMT Subject: RFR: 7903906: JOL: SA detection code may hang indefinitely Message-ID: <6IlaCtytoi0nEJ90FZidkgJLI7ugzei0dC4pU1R42HU=.3e5d10d3-26d4-4bcc-bff3-ef05fc98cf86@github.com> This is seen when running GHA on macos-aarch64 runners. The attempt to attach to SA would fail cryptically, as waitFor would wait indefinitely for a non-compliant SA to respond. We need to handle waitFor timeouts gracefully. ------------- Commit messages: - Fix Changes: https://git.openjdk.org/jol/pull/60/files Webrev: https://webrevs.openjdk.org/?repo=jol&pr=60&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903906 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jol/pull/60.diff Fetch: git fetch https://git.openjdk.org/jol.git pull/60/head:pull/60 PR: https://git.openjdk.org/jol/pull/60 From duke at openjdk.org Wed Dec 11 12:28:05 2024 From: duke at openjdk.org (duke) Date: Wed, 11 Dec 2024 12:28:05 GMT Subject: git: openjdk/jol: 7903906: JOL: SA detection code may hang indefinitely Message-ID: <6f770c3d-f52d-40bd-9ee6-ee6dd0b1c355@openjdk.org> Changeset: dcc010a5 Branch: master Author: Aleksey Shipil?v Committer: GitHub Date: 2024-12-11 13:26:20 +0000 URL: https://git.openjdk.org/jol/commit/dcc010a599bc97f230c7867a561dab638e8735eb 7903906: JOL: SA detection code may hang indefinitely ! jol-core/src/main/java/org/openjdk/jol/vm/sa/ServiceabilityAgentSupport.java From shade at openjdk.org Wed Dec 11 12:28:55 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 11 Dec 2024 12:28:55 GMT Subject: Withdrawn: 7903906: JOL: SA detection code may hang indefinitely In-Reply-To: <6IlaCtytoi0nEJ90FZidkgJLI7ugzei0dC4pU1R42HU=.3e5d10d3-26d4-4bcc-bff3-ef05fc98cf86@github.com> References: <6IlaCtytoi0nEJ90FZidkgJLI7ugzei0dC4pU1R42HU=.3e5d10d3-26d4-4bcc-bff3-ef05fc98cf86@github.com> Message-ID: On Wed, 11 Dec 2024 12:18:09 GMT, Aleksey Shipilev wrote: > This is seen when running GHA on macos-aarch64 runners. The attempt to attach to SA would fail cryptically, as waitFor would wait indefinitely for a non-compliant SA to respond. We need to handle waitFor timeouts gracefully. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jol/pull/60 From shade at openjdk.org Wed Dec 11 12:31:22 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 11 Dec 2024 12:31:22 GMT Subject: RFR: 7903904: JOL: Switch to latest GHA runners [v7] In-Reply-To: References: Message-ID: <94D8CQGu0fNyfbzkqpPpKDhpz8JqUtDLuxr9HrJCugE=.68141327-9895-46d8-a174-34d58b40a1be@github.com> > Like JMH, we want to switch to latest GHA runners, to avoid chasing the ever-upgrading GHA infrastructure. Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - Revert test stabilization changes - Shorter iterations - Try with lower fork count - Properly skip default tests - MacOS runners cannot complete the default tests? - Update to Corretto, use more modern steps - Fix ------------- Changes: https://git.openjdk.org/jol/pull/59/files Webrev: https://webrevs.openjdk.org/?repo=jol&pr=59&range=06 Stats: 6 lines in 1 file changed: 1 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jol/pull/59.diff Fetch: git fetch https://git.openjdk.org/jol.git pull/59/head:pull/59 PR: https://git.openjdk.org/jol/pull/59 From duke at openjdk.org Wed Dec 11 12:40:01 2024 From: duke at openjdk.org (duke) Date: Wed, 11 Dec 2024 12:40:01 GMT Subject: git: openjdk/jol: 7903904: JOL: Switch to latest GHA runners Message-ID: Changeset: 6e30b647 Branch: master Author: Aleksey Shipil?v Committer: GitHub Date: 2024-12-11 13:39:35 +0000 URL: https://git.openjdk.org/jol/commit/6e30b6470b0feb221dbf7c33cb85648d2c4b1e95 7903904: JOL: Switch to latest GHA runners ! .github/workflows/pre-integration.yml From shade at openjdk.org Wed Dec 11 12:41:55 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 11 Dec 2024 12:41:55 GMT Subject: Withdrawn: 7903904: JOL: Switch to latest GHA runners In-Reply-To: References: Message-ID: On Tue, 10 Dec 2024 17:07:07 GMT, Aleksey Shipilev wrote: > Like JMH, we want to switch to latest GHA runners, to avoid chasing the ever-upgrading GHA infrastructure. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jol/pull/59 From shade at openjdk.org Wed Dec 11 17:23:32 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 11 Dec 2024 17:23:32 GMT Subject: RFR: 7903905: JOL: Simplify Lilliput headump-estimates Message-ID: Lilliput was shipped in JDK 24 as experimental option. Current heapdump-esitmates provides *two* estimates: one with array base improvements, and one without. The version of Lilliput in upstream does implement array base improvements unconditionally ([JDK-8139457](https://bugs.openjdk.org/browse/JDK-8139457)). Therefore, we do not need one of the estimates. ------------- Commit messages: - Capture array base improvements better - Basic Lilliput removals Changes: https://git.openjdk.org/jol/pull/61/files Webrev: https://webrevs.openjdk.org/?repo=jol&pr=61&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903905 Stats: 148 lines in 10 files changed: 7 ins; 69 del; 72 mod Patch: https://git.openjdk.org/jol/pull/61.diff Fetch: git fetch https://git.openjdk.org/jol.git pull/61/head:pull/61 PR: https://git.openjdk.org/jol/pull/61 From duke at openjdk.org Wed Dec 11 17:51:43 2024 From: duke at openjdk.org (duke) Date: Wed, 11 Dec 2024 17:51:43 GMT Subject: git: openjdk/jol: 7903905: JOL: Simplify Lilliput headump-estimates Message-ID: <3a625216-9161-452b-b15a-93dba1cb2ea8@openjdk.org> Changeset: 16705c91 Branch: master Author: Aleksey Shipil?v Committer: GitHub Date: 2024-12-11 18:50:02 +0000 URL: https://git.openjdk.org/jol/commit/16705c91420cd26ea7f5bb5f11f539f4f71f7267 7903905: JOL: Simplify Lilliput headump-estimates ! jol-cli/src/main/java/org/openjdk/jol/operations/EstimatedModels.java ! jol-cli/src/main/java/org/openjdk/jol/operations/HeapDumpEstimates.java ! jol-cli/src/main/java/org/openjdk/jol/operations/ObjectInternalsEstimates.java ! jol-core/src/main/java/org/openjdk/jol/datamodel/DataModel.java ! jol-core/src/main/java/org/openjdk/jol/datamodel/Model32.java ! jol-core/src/main/java/org/openjdk/jol/datamodel/Model64.java ! jol-core/src/main/java/org/openjdk/jol/datamodel/Model64_Lilliput.java ! jol-core/src/main/java/org/openjdk/jol/datamodel/ModelVM.java ! jol-core/src/main/java/org/openjdk/jol/layouters/HotSpotLayouter.java ! jol-samples/src/main/java/org/openjdk/jol/samples/JOLSample_10_DataModels.java From shade at openjdk.org Wed Dec 11 17:52:26 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 11 Dec 2024 17:52:26 GMT Subject: Withdrawn: 7903905: JOL: Simplify Lilliput headump-estimates In-Reply-To: References: Message-ID: On Wed, 11 Dec 2024 17:17:13 GMT, Aleksey Shipilev wrote: > Lilliput was shipped in JDK 24 as experimental option. Current heapdump-esitmates provides *two* estimates: one with array base improvements, and one without. The version of Lilliput in upstream does implement array base improvements unconditionally ([JDK-8139457](https://bugs.openjdk.org/browse/JDK-8139457)). Therefore, we do not need one of the estimates. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jol/pull/61 From shade at openjdk.org Wed Dec 11 18:48:17 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 11 Dec 2024 18:48:17 GMT Subject: RFR: 7903907: JOL: Further cleanup in heapdump-estimates Message-ID: Looking more closely at the report, I don't think we need to see overly large alignments. This only adds visual noise to the report and makes it slower than it should be. ------------- Commit messages: - Fix Changes: https://git.openjdk.org/jol/pull/62/files Webrev: https://webrevs.openjdk.org/?repo=jol&pr=62&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903907 Stats: 16 lines in 1 file changed: 1 ins; 9 del; 6 mod Patch: https://git.openjdk.org/jol/pull/62.diff Fetch: git fetch https://git.openjdk.org/jol.git pull/62/head:pull/62 PR: https://git.openjdk.org/jol/pull/62 From duke at openjdk.org Wed Dec 11 18:50:47 2024 From: duke at openjdk.org (duke) Date: Wed, 11 Dec 2024 18:50:47 GMT Subject: git: openjdk/jol: 7903907: JOL: Further cleanup in heapdump-estimates Message-ID: <0ef70911-f3df-456e-b675-dd7e202253d5@openjdk.org> Changeset: 2ebe79c4 Branch: master Author: Aleksey Shipil?v Committer: GitHub Date: 2024-12-11 19:49:29 +0000 URL: https://git.openjdk.org/jol/commit/2ebe79c476f42eca0b453749c2cd8a643fa7bd8b 7903907: JOL: Further cleanup in heapdump-estimates ! jol-cli/src/main/java/org/openjdk/jol/operations/HeapDumpEstimates.java From shade at openjdk.org Wed Dec 11 18:51:34 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 11 Dec 2024 18:51:34 GMT Subject: Withdrawn: 7903907: JOL: Further cleanup in heapdump-estimates In-Reply-To: References: Message-ID: On Wed, 11 Dec 2024 18:42:57 GMT, Aleksey Shipilev wrote: > Looking more closely at the report, I don't think we need to see overly large alignments. This only adds visual noise to the report and makes it slower than it should be. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jol/pull/62 From eero.vaarnas at twoday.com Wed Dec 18 13:58:21 2024 From: eero.vaarnas at twoday.com (Eero Vaarnas) Date: Wed, 18 Dec 2024 13:58:21 +0000 Subject: Bug report In-Reply-To: References: Message-ID: Suggestions for fixing this: * (Optionally) ignore NoClassDefFoundErrors in the calculation * Implement logging of errors and/or some kind of error report From: Eero Vaarnas Sent: Tuesday, December 17, 2024 9:49 PM To: jol-dev at openjdk.org Subject: Bug report Hi, I would like to report a bug in JOL: When running GraphLayout.parseInstance(object).totalSize(), I?m getting NoClassDefFoundError for oracle/simplefan/FanManager. Any means to avoid that? -------------- next part -------------- An HTML attachment was scrubbed... URL: