From robilad at openjdk.org  Fri Feb  2 12:49:15 2024
From: robilad at openjdk.org (Dalibor Topic)
Date: Fri, 2 Feb 2024 12:49:15 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v7]
In-Reply-To: <sLS4a1DONBLfqE6c6ooz3YqO18hD3F8rAvSQAjtW9Pc=.48db0fd7-d8db-44f7-a6de-74ea16c9e53d@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <sLS4a1DONBLfqE6c6ooz3YqO18hD3F8rAvSQAjtW9Pc=.48db0fd7-d8db-44f7-a6de-74ea16c9e53d@github.com>
Message-ID: <A3nFdlXc5_m78PpSjU6sFUb-atRaEGhaxUWeNRx0P8A=.0a6d2c47-124f-4a75-8e56-3aa154b68d7d@github.com>

On Wed, 19 Oct 2022 14:43:38 GMT, Ivan Ponomarev <duke at openjdk.org> wrote:

>> This moves https://github.com/atp-mipt/ljv project inside JOL in order for LJV to get access to internal JOL's APIs.
>> 
>> See blogposts about LJV [in Russian](https://habr.com/ru/post/599045/) /  [in English](https://dzone.com/articles/what-can-we-learn-from-java-data-structures-visual).
>
> Ivan Ponomarev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 100 commits:
> 
>  - Merge remote-tracking branch 'upstream/master'
>  - fix review comments
>  - Merge pull request #7 from atp-mipt/jchekProblems
>    
>    jcheck Whitespace error fix
>  - jcheck Whitespace error fix
>  - leftover comments + braces (#6)
>    
>    * leftover comments + braces
>    
>    * remove leftover pom.xml
>    
>    * remove extra copyright comments
>    
>    Co-authored-by: Ivan Ponomarev <iponomarev at mail.ru>
>  - minor changes (#5)
>    
>    * HashCodeCollision reimplementation
>    * JDK headers fix
>    *  LJV Github actions removed
>    * other code review fixes
>    
>    Co-authored-by: Ivan Ponomarev <iponomarev at mail.ru>
>  - update copyright notice, lint
>  - code cleanup
>  - Move ljv inside jol (#2)
>    
>    * sub module ljv in jol-core
>    
>    * LJV 1.7 JDK version
>    
>    Co-authored-by: Victor Petrosyan <viko20000 at mail.ru>
>  - Merge remote-tracking branch 'upstream/master'
>  - ... and 90 more: https://git.openjdk.org/jol/compare/482c0ee8...043009e8

I can confirm that the individuals listed as contributors have an OCA on file.

-------------

PR Comment: https://git.openjdk.org/jol/pull/24#issuecomment-1923735289

From duke at openjdk.org  Fri Feb  2 13:46:26 2024
From: duke at openjdk.org (Ivan Ponomarev)
Date: Fri, 2 Feb 2024 13:46:26 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v8]
In-Reply-To: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
Message-ID: <Giu9_0dEZMtIU23NHTYaN8UIpBCPAOqDs--gKlO4sEM=.4a39a73a-c099-467f-9a00-db2375623afa@github.com>

> This moves https://github.com/atp-mipt/ljv project inside JOL in order for LJV to get access to internal JOL's APIs.
> 
> See blogposts about LJV [in Russian](https://habr.com/ru/post/599045/) /  [in English](https://dzone.com/articles/what-can-we-learn-from-java-data-structures-visual).

Ivan Ponomarev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 101 commits:

 - Merge remote-tracking branch 'upstream/master'
 - Merge remote-tracking branch 'upstream/master'
 - fix review comments
 - Merge pull request #7 from atp-mipt/jchekProblems
   
   jcheck Whitespace error fix
 - jcheck Whitespace error fix
 - leftover comments + braces (#6)
   
   * leftover comments + braces
   
   * remove leftover pom.xml
   
   * remove extra copyright comments
   
   Co-authored-by: Ivan Ponomarev <iponomarev at mail.ru>
 - minor changes (#5)
   
   * HashCodeCollision reimplementation
   * JDK headers fix
   *  LJV Github actions removed
   * other code review fixes
   
   Co-authored-by: Ivan Ponomarev <iponomarev at mail.ru>
 - update copyright notice, lint
 - code cleanup
 - Move ljv inside jol (#2)
   
   * sub module ljv in jol-core
   
   * LJV 1.7 JDK version
   
   Co-authored-by: Victor Petrosyan <viko20000 at mail.ru>
 - ... and 91 more: https://git.openjdk.org/jol/compare/2992aa42...782fc818

-------------

Changes: https://git.openjdk.org/jol/pull/24/files
 Webrev: https://webrevs.openjdk.org/?repo=jol&pr=24&range=07
  Stats: 4177 lines in 59 files changed: 4176 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jol/pull/24.diff
  Fetch: git fetch https://git.openjdk.org/jol.git pull/24/head:pull/24

PR: https://git.openjdk.org/jol/pull/24

From duke at openjdk.org  Fri Feb  2 14:08:17 2024
From: duke at openjdk.org (Ivan Ponomarev)
Date: Fri, 2 Feb 2024 14:08:17 GMT
Subject: Integrated: CODETOOLS-7903176: Move LJV inside JOL
In-Reply-To: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
Message-ID: <EUGacgb35cfK5IL1d43bYQs6Q3G6iWk_6B_B28hz2Sw=.c014e48a-e42e-4bfe-901a-5f36f13bb087@github.com>

On Tue, 3 May 2022 08:47:17 GMT, Ivan Ponomarev <duke at openjdk.org> wrote:

> This moves https://github.com/atp-mipt/ljv project inside JOL in order for LJV to get access to internal JOL's APIs.
> 
> See blogposts about LJV [in Russian](https://habr.com/ru/post/599045/) /  [in English](https://dzone.com/articles/what-can-we-learn-from-java-data-structures-visual).

This pull request has now been integrated.

Changeset: c93c191a
Author:    Ivan Ponomarev <iponomarev at mail.ru>
Committer: Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.org/jol/commit/c93c191a056db8710f7505e3a2c6570539c60c6c
Stats:     4177 lines in 59 files changed: 4176 ins; 0 del; 1 mod

7903176: Move LJV inside JOL

Co-authored-by: Ivan Arkhipov <me at endevir.ru>
Co-authored-by: John Hamer <john.hamer at glasgow.ac.uk>
Co-authored-by: Ilya Selivanau <ilyaspacemail at gmail.com>
Co-authored-by: Victor Petrosyan <victor at galahad.ee>
Co-authored-by: Georgy Guminov <georgy at galahad.ee>
Co-authored-by: Ilya Shvetsov <ilya at galahad.ee>
Co-authored-by: Nuras Nogaev <nuras at galahad.ee>
Reviewed-by: shade

-------------

PR: https://git.openjdk.org/jol/pull/24

From duke at openjdk.org  Tue Feb  6 08:55:14 2024
From: duke at openjdk.org (Ivan Ponomarev)
Date: Tue, 6 Feb 2024 08:55:14 GMT
Subject: RFR: Fix empty arrays visualization
Message-ID: <2RS1UPs2ag0pyjWEiRzUP5F1rodar0NW5g1CK-wBv60=.9c37bf18-c5ee-4af5-b69b-6ca46db72b0c@github.com>

Currently, visualization of an empty array produces invalid DOT (see https://github.com/atp-mipt/ljv/issues/28)

The solution proposed is as discussed in that issue in 2021 (we now show array component type as well, also treating primitive types and "multidimensional" arrays correctly, that is `int[]`, `int[][]` etc).

This PR also changes the expected version of Java for LJV approval tests from 11 to 8 in order to simplify development of LJV as a part of JOL.

-------------

Commit messages:
 - fix empty arrays Visualization. Show array component type

Changes: https://git.openjdk.org/jol/pull/57/files
 Webrev: https://webrevs.openjdk.org/?repo=jol&pr=57&range=00
  Stats: 196 lines in 25 files changed: 72 ins; 34 del; 90 mod
  Patch: https://git.openjdk.org/jol/pull/57.diff
  Fetch: git fetch https://git.openjdk.org/jol.git pull/57/head:pull/57

PR: https://git.openjdk.org/jol/pull/57

From shade at openjdk.org  Tue Feb  6 09:48:08 2024
From: shade at openjdk.org (Aleksey Shipilev)
Date: Tue, 6 Feb 2024 09:48:08 GMT
Subject: RFR: 7903652: JOL: Fix empty arrays visualization in LJV
In-Reply-To: <2RS1UPs2ag0pyjWEiRzUP5F1rodar0NW5g1CK-wBv60=.9c37bf18-c5ee-4af5-b69b-6ca46db72b0c@github.com>
References: <2RS1UPs2ag0pyjWEiRzUP5F1rodar0NW5g1CK-wBv60=.9c37bf18-c5ee-4af5-b69b-6ca46db72b0c@github.com>
Message-ID: <x0XL3PxjzF6WIcRZaFUKHGzD1pFx-vPLRDduO76EVUs=.9705ad9e-6353-4820-932d-49dd5022f1bc@github.com>

On Tue, 6 Feb 2024 08:51:38 GMT, Ivan Ponomarev <duke at openjdk.org> wrote:

> This PR also changes the expected version of Java for LJV approval tests from 11 to 8 in order to simplify development of LJV as a part of JOL.

Is there a pressing need to do it here? For example, does it make testing for this bugfix easier? If not, I would suggest we do it separately.

-------------

Marked as reviewed by shade (Committer).

PR Review: https://git.openjdk.org/jol/pull/57#pullrequestreview-1864699164

From duke at openjdk.org  Tue Feb  6 23:32:02 2024
From: duke at openjdk.org (Ivan Ponomarev)
Date: Tue, 6 Feb 2024 23:32:02 GMT
Subject: RFR: 7903652: JOL: Fix empty arrays visualization in LJV
In-Reply-To: <x0XL3PxjzF6WIcRZaFUKHGzD1pFx-vPLRDduO76EVUs=.9705ad9e-6353-4820-932d-49dd5022f1bc@github.com>
References: <2RS1UPs2ag0pyjWEiRzUP5F1rodar0NW5g1CK-wBv60=.9c37bf18-c5ee-4af5-b69b-6ca46db72b0c@github.com>
 <x0XL3PxjzF6WIcRZaFUKHGzD1pFx-vPLRDduO76EVUs=.9705ad9e-6353-4820-932d-49dd5022f1bc@github.com>
Message-ID: <TlPsPlJcfXM_RDUdyrevlCXWnaN2Ebobtqr4TPtQ8UE=.15c816eb-affc-484e-a07b-6f2635a050b2@github.com>

On Tue, 6 Feb 2024 09:45:32 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Is there a pressing need to do it here? For example, does it make testing for this bugfix easier? If not, I would suggest we do it separately.

It's not that the reason is very pressing, but yes, running tests from IDE is not possible as target version for JOL is 1.8, while for LJV we used 11. Thus when you set JDK1.8 in IDEA all the tests targeted for 11 are ignored, and when you set JDK11, it won't compile as `sun.misc.Unsafe does not exist`.

I fully agree with the point that it's not good to bring two things in one pull request. But on the other hand, all the `*.approved.txt` files were going to be changed anyway, as we change arrays visualization. So it's either two PRs one after another, or merge conflicts. And on top of it I am still kinda scared by the PR handling throughput rate of this project, that's why I decided to make one PR instead of two.

So if you insist, I can split it into two PRs. If not really, let's just merge for now, and I will be sending more fine-grained PRs in the future

-------------

PR Comment: https://git.openjdk.org/jol/pull/57#issuecomment-1930942587

From shade at openjdk.org  Wed Feb  7 08:17:06 2024
From: shade at openjdk.org (Aleksey Shipilev)
Date: Wed, 7 Feb 2024 08:17:06 GMT
Subject: RFR: 7903652: JOL: Fix empty arrays visualization in LJV
In-Reply-To: <2RS1UPs2ag0pyjWEiRzUP5F1rodar0NW5g1CK-wBv60=.9c37bf18-c5ee-4af5-b69b-6ca46db72b0c@github.com>
References: <2RS1UPs2ag0pyjWEiRzUP5F1rodar0NW5g1CK-wBv60=.9c37bf18-c5ee-4af5-b69b-6ca46db72b0c@github.com>
Message-ID: <r1u49SoKm97zN6XdqRmKG_5BWGHtRXlnw-U4JCNKC74=.604e1791-a2cd-4914-adfc-bf1fc7c5c86a@github.com>

On Tue, 6 Feb 2024 08:51:38 GMT, Ivan Ponomarev <duke at openjdk.org> wrote:

> Currently, visualization of an empty array produces invalid DOT (see https://github.com/atp-mipt/ljv/issues/28)
> 
> The solution proposed is as discussed in that issue in 2021 (we now show array component type as well, also treating primitive types and "multidimensional" arrays correctly, that is `int[]`, `int[][]` etc).
> 
> This PR also changes the expected version of Java for LJV approval tests from 11 to 8 in order to simplify development of LJV as a part of JOL.

All right, no need to split, integrate as is.

-------------

PR Comment: https://git.openjdk.org/jol/pull/57#issuecomment-1931497525

From duke at openjdk.org  Wed Feb  7 10:57:09 2024
From: duke at openjdk.org (Ivan Ponomarev)
Date: Wed, 7 Feb 2024 10:57:09 GMT
Subject: Integrated: 7903652: JOL: Fix empty arrays visualization in LJV
In-Reply-To: <2RS1UPs2ag0pyjWEiRzUP5F1rodar0NW5g1CK-wBv60=.9c37bf18-c5ee-4af5-b69b-6ca46db72b0c@github.com>
References: <2RS1UPs2ag0pyjWEiRzUP5F1rodar0NW5g1CK-wBv60=.9c37bf18-c5ee-4af5-b69b-6ca46db72b0c@github.com>
Message-ID: <jLmeGUX9zuerd5nkfNk1CpsUzE1LECYvE7TgH8cyNfg=.65f89cb9-62ba-4a9f-8b20-ddae5e28401b@github.com>

On Tue, 6 Feb 2024 08:51:38 GMT, Ivan Ponomarev <duke at openjdk.org> wrote:

> Currently, visualization of an empty array produces invalid DOT (see https://github.com/atp-mipt/ljv/issues/28)
> 
> The solution proposed is as discussed in that issue in 2021 (we now show array component type as well, also treating primitive types and "multidimensional" arrays correctly, that is `int[]`, `int[][]` etc).
> 
> This PR also changes the expected version of Java for LJV approval tests from 11 to 8 in order to simplify development of LJV as a part of JOL.

This pull request has now been integrated.

Changeset: faefa00a
Author:    Ivan Ponomarev <iponomarev at mail.ru>
Committer: Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.org/jol/commit/faefa00ad094205e83fbbd97a300e93766627059
Stats:     196 lines in 25 files changed: 72 ins; 34 del; 90 mod

7903652: JOL: Fix empty arrays visualization in LJV

Reviewed-by: shade

-------------

PR: https://git.openjdk.org/jol/pull/57

From robilad at openjdk.org  Thu Feb  8 22:03:07 2024
From: robilad at openjdk.org (Dalibor Topic)
Date: Thu, 8 Feb 2024 22:03:07 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v8]
In-Reply-To: <Giu9_0dEZMtIU23NHTYaN8UIpBCPAOqDs--gKlO4sEM=.4a39a73a-c099-467f-9a00-db2375623afa@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <Giu9_0dEZMtIU23NHTYaN8UIpBCPAOqDs--gKlO4sEM=.4a39a73a-c099-467f-9a00-db2375623afa@github.com>
Message-ID: <P2gm0oQvj5_e54R8TetO7VTk82MUxJFSJJsueF0fZRY=.12adca28-3765-411f-8b58-27e5ecb43ada@github.com>

On Fri, 2 Feb 2024 13:46:26 GMT, Ivan Ponomarev <duke at openjdk.org> wrote:

>> This moves https://github.com/atp-mipt/ljv project inside JOL in order for LJV to get access to internal JOL's APIs.
>> 
>> See blogposts about LJV [in Russian](https://habr.com/ru/post/599045/) /  [in English](https://dzone.com/articles/what-can-we-learn-from-java-data-structures-visual).
>
> Ivan Ponomarev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 101 commits:
> 
>  - Merge remote-tracking branch 'upstream/master'
>  - Merge remote-tracking branch 'upstream/master'
>  - fix review comments
>  - Merge pull request #7 from atp-mipt/jchekProblems
>    
>    jcheck Whitespace error fix
>  - jcheck Whitespace error fix
>  - leftover comments + braces (#6)
>    
>    * leftover comments + braces
>    
>    * remove leftover pom.xml
>    
>    * remove extra copyright comments
>    
>    Co-authored-by: Ivan Ponomarev <iponomarev at mail.ru>
>  - minor changes (#5)
>    
>    * HashCodeCollision reimplementation
>    * JDK headers fix
>    *  LJV Github actions removed
>    * other code review fixes
>    
>    Co-authored-by: Ivan Ponomarev <iponomarev at mail.ru>
>  - update copyright notice, lint
>  - code cleanup
>  - Move ljv inside jol (#2)
>    
>    * sub module ljv in jol-core
>    
>    * LJV 1.7 JDK version
>    
>    Co-authored-by: Victor Petrosyan <viko20000 at mail.ru>
>  - ... and 91 more: https://git.openjdk.org/jol/compare/2992aa42...782fc818

Please also have each contributor listed in the change confirm in the PR comments that they would like to make this contribution, as this contribution has not been developed within this project.

-------------

PR Comment: https://git.openjdk.org/jol/pull/24#issuecomment-1935001243

From duke at openjdk.org  Sat Feb 10 19:13:08 2024
From: duke at openjdk.org (Ivan Arkhipov)
Date: Sat, 10 Feb 2024 19:13:08 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v8]
In-Reply-To: <Giu9_0dEZMtIU23NHTYaN8UIpBCPAOqDs--gKlO4sEM=.4a39a73a-c099-467f-9a00-db2375623afa@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <Giu9_0dEZMtIU23NHTYaN8UIpBCPAOqDs--gKlO4sEM=.4a39a73a-c099-467f-9a00-db2375623afa@github.com>
Message-ID: <PllGTEO-UrlNwbqWWJPFwdRJQWt7zmTrA9lSaSS4dBI=.e496f669-d6ca-48de-ba64-ec6938943f04@github.com>

On Fri, 2 Feb 2024 13:46:26 GMT, Ivan Ponomarev <duke at openjdk.org> wrote:

>> This moves https://github.com/atp-mipt/ljv project inside JOL in order for LJV to get access to internal JOL's APIs.
>> 
>> See blogposts about LJV [in Russian](https://habr.com/ru/post/599045/) /  [in English](https://dzone.com/articles/what-can-we-learn-from-java-data-structures-visual).
>
> Ivan Ponomarev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 101 commits:
> 
>  - Merge remote-tracking branch 'upstream/master'
>  - Merge remote-tracking branch 'upstream/master'
>  - fix review comments
>  - Merge pull request #7 from atp-mipt/jchekProblems
>    
>    jcheck Whitespace error fix
>  - jcheck Whitespace error fix
>  - leftover comments + braces (#6)
>    
>    * leftover comments + braces
>    
>    * remove leftover pom.xml
>    
>    * remove extra copyright comments
>    
>    Co-authored-by: Ivan Ponomarev <iponomarev at mail.ru>
>  - minor changes (#5)
>    
>    * HashCodeCollision reimplementation
>    * JDK headers fix
>    *  LJV Github actions removed
>    * other code review fixes
>    
>    Co-authored-by: Ivan Ponomarev <iponomarev at mail.ru>
>  - update copyright notice, lint
>  - code cleanup
>  - Move ljv inside jol (#2)
>    
>    * sub module ljv in jol-core
>    
>    * LJV 1.7 JDK version
>    
>    Co-authored-by: Victor Petrosyan <viko20000 at mail.ru>
>  - ... and 91 more: https://git.openjdk.org/jol/compare/2992aa42...782fc818

I confirm that I'll be glad to make this contribution within JOL project.

-------------

PR Comment: https://git.openjdk.org/jol/pull/24#issuecomment-1937098775

From duke at openjdk.org  Sat Feb 10 20:38:07 2024
From: duke at openjdk.org (Victor)
Date: Sat, 10 Feb 2024 20:38:07 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v8]
In-Reply-To: <P2gm0oQvj5_e54R8TetO7VTk82MUxJFSJJsueF0fZRY=.12adca28-3765-411f-8b58-27e5ecb43ada@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <Giu9_0dEZMtIU23NHTYaN8UIpBCPAOqDs--gKlO4sEM=.4a39a73a-c099-467f-9a00-db2375623afa@github.com>
 <P2gm0oQvj5_e54R8TetO7VTk82MUxJFSJJsueF0fZRY=.12adca28-3765-411f-8b58-27e5ecb43ada@github.com>
Message-ID: <hY-VnFiehra41jEiWJCYO7zTjHgHl8yIN3snHks2LWs=.397d6377-2973-4f66-9180-371d82161bb9@github.com>

On Thu, 8 Feb 2024 22:00:43 GMT, Dalibor Topic <robilad at openjdk.org> wrote:

>> Ivan Ponomarev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 101 commits:
>> 
>>  - Merge remote-tracking branch 'upstream/master'
>>  - Merge remote-tracking branch 'upstream/master'
>>  - fix review comments
>>  - Merge pull request #7 from atp-mipt/jchekProblems
>>    
>>    jcheck Whitespace error fix
>>  - jcheck Whitespace error fix
>>  - leftover comments + braces (#6)
>>    
>>    * leftover comments + braces
>>    
>>    * remove leftover pom.xml
>>    
>>    * remove extra copyright comments
>>    
>>    Co-authored-by: Ivan Ponomarev <iponomarev at mail.ru>
>>  - minor changes (#5)
>>    
>>    * HashCodeCollision reimplementation
>>    * JDK headers fix
>>    *  LJV Github actions removed
>>    * other code review fixes
>>    
>>    Co-authored-by: Ivan Ponomarev <iponomarev at mail.ru>
>>  - update copyright notice, lint
>>  - code cleanup
>>  - Move ljv inside jol (#2)
>>    
>>    * sub module ljv in jol-core
>>    
>>    * LJV 1.7 JDK version
>>    
>>    Co-authored-by: Victor Petrosyan <viko20000 at mail.ru>
>>  - ... and 91 more: https://git.openjdk.org/jol/compare/2992aa42...782fc818
>
> Please also have each contributor listed in the change confirm in the PR comments that they would like to make this contribution, as this contribution has not been developed within this project.

Hello @robilad ,  as a contributor to LJV, I confirm that we wanted to merge it with OpenJDK/JOL

-------------

PR Comment: https://git.openjdk.org/jol/pull/24#issuecomment-1937114770

From duke at openjdk.org  Sun Feb 11 03:41:07 2024
From: duke at openjdk.org (Nuras Nogayev)
Date: Sun, 11 Feb 2024 03:41:07 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v8]
In-Reply-To: <Giu9_0dEZMtIU23NHTYaN8UIpBCPAOqDs--gKlO4sEM=.4a39a73a-c099-467f-9a00-db2375623afa@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <Giu9_0dEZMtIU23NHTYaN8UIpBCPAOqDs--gKlO4sEM=.4a39a73a-c099-467f-9a00-db2375623afa@github.com>
Message-ID: <gVTMzyZYWKiWgzjTWPVyyfKCywswnIxuUpUbGfQT5Pk=.9ce8d12f-48ef-483e-a237-5554c41bd97c@github.com>

On Fri, 2 Feb 2024 13:46:26 GMT, Ivan Ponomarev <duke at openjdk.org> wrote:

>> This moves https://github.com/atp-mipt/ljv project inside JOL in order for LJV to get access to internal JOL's APIs.
>> 
>> See blogposts about LJV [in Russian](https://habr.com/ru/post/599045/) /  [in English](https://dzone.com/articles/what-can-we-learn-from-java-data-structures-visual).
>
> Ivan Ponomarev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 101 commits:
> 
>  - Merge remote-tracking branch 'upstream/master'
>  - Merge remote-tracking branch 'upstream/master'
>  - fix review comments
>  - Merge pull request #7 from atp-mipt/jchekProblems
>    
>    jcheck Whitespace error fix
>  - jcheck Whitespace error fix
>  - leftover comments + braces (#6)
>    
>    * leftover comments + braces
>    
>    * remove leftover pom.xml
>    
>    * remove extra copyright comments
>    
>    Co-authored-by: Ivan Ponomarev <iponomarev at mail.ru>
>  - minor changes (#5)
>    
>    * HashCodeCollision reimplementation
>    * JDK headers fix
>    *  LJV Github actions removed
>    * other code review fixes
>    
>    Co-authored-by: Ivan Ponomarev <iponomarev at mail.ru>
>  - update copyright notice, lint
>  - code cleanup
>  - Move ljv inside jol (#2)
>    
>    * sub module ljv in jol-core
>    
>    * LJV 1.7 JDK version
>    
>    Co-authored-by: Victor Petrosyan <viko20000 at mail.ru>
>  - ... and 91 more: https://git.openjdk.org/jol/compare/2992aa42...782fc818

I confirm that I would like to make this contribution

-------------

PR Comment: https://git.openjdk.org/jol/pull/24#issuecomment-1937411211

From duke at openjdk.org  Sun Feb 11 07:13:08 2024
From: duke at openjdk.org (Ilya Shvetsov)
Date: Sun, 11 Feb 2024 07:13:08 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v8]
In-Reply-To: <Giu9_0dEZMtIU23NHTYaN8UIpBCPAOqDs--gKlO4sEM=.4a39a73a-c099-467f-9a00-db2375623afa@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <Giu9_0dEZMtIU23NHTYaN8UIpBCPAOqDs--gKlO4sEM=.4a39a73a-c099-467f-9a00-db2375623afa@github.com>
Message-ID: <T5-v2Oe_jprrmNfg4Ao5owwy3K2qPZVuapqqDFxmTwg=.82f5d6b8-6224-43bc-8c36-66cf59b138d5@github.com>

On Fri, 2 Feb 2024 13:46:26 GMT, Ivan Ponomarev <duke at openjdk.org> wrote:

>> This moves https://github.com/atp-mipt/ljv project inside JOL in order for LJV to get access to internal JOL's APIs.
>> 
>> See blogposts about LJV [in Russian](https://habr.com/ru/post/599045/) /  [in English](https://dzone.com/articles/what-can-we-learn-from-java-data-structures-visual).
>
> Ivan Ponomarev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 101 commits:
> 
>  - Merge remote-tracking branch 'upstream/master'
>  - Merge remote-tracking branch 'upstream/master'
>  - fix review comments
>  - Merge pull request #7 from atp-mipt/jchekProblems
>    
>    jcheck Whitespace error fix
>  - jcheck Whitespace error fix
>  - leftover comments + braces (#6)
>    
>    * leftover comments + braces
>    
>    * remove leftover pom.xml
>    
>    * remove extra copyright comments
>    
>    Co-authored-by: Ivan Ponomarev <iponomarev at mail.ru>
>  - minor changes (#5)
>    
>    * HashCodeCollision reimplementation
>    * JDK headers fix
>    *  LJV Github actions removed
>    * other code review fixes
>    
>    Co-authored-by: Ivan Ponomarev <iponomarev at mail.ru>
>  - update copyright notice, lint
>  - code cleanup
>  - Move ljv inside jol (#2)
>    
>    * sub module ljv in jol-core
>    
>    * LJV 1.7 JDK version
>    
>    Co-authored-by: Victor Petrosyan <viko20000 at mail.ru>
>  - ... and 91 more: https://git.openjdk.org/jol/compare/2992aa42...782fc818

Hello! I confirm that I want this to be merged with OpenJDK/JOL

-------------

PR Comment: https://git.openjdk.org/jol/pull/24#issuecomment-1937455933

From duke at openjdk.org  Sun Feb 11 12:38:08 2024
From: duke at openjdk.org (Georgy Guminov)
Date: Sun, 11 Feb 2024 12:38:08 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v8]
In-Reply-To: <P2gm0oQvj5_e54R8TetO7VTk82MUxJFSJJsueF0fZRY=.12adca28-3765-411f-8b58-27e5ecb43ada@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <Giu9_0dEZMtIU23NHTYaN8UIpBCPAOqDs--gKlO4sEM=.4a39a73a-c099-467f-9a00-db2375623afa@github.com>
 <P2gm0oQvj5_e54R8TetO7VTk82MUxJFSJJsueF0fZRY=.12adca28-3765-411f-8b58-27e5ecb43ada@github.com>
Message-ID: <LfP5rToH_1tGGp7x-CXp6zP0nY7QgARYtxEa1gEfN3M=.b7ddba39-d6bc-429e-abe9-e82fd42f56d1@github.com>

On Thu, 8 Feb 2024 22:00:43 GMT, Dalibor Topic <robilad at openjdk.org> wrote:

> Please also have each contributor listed in the change confirm in the PR comments that they would like to make this contribution, as this contribution has not been developed within this project.

I confirm that I want this contribution to be made within JOL project.

-------------

PR Comment: https://git.openjdk.org/jol/pull/24#issuecomment-1937694078

From duke at openjdk.org  Mon Feb 12 16:16:11 2024
From: duke at openjdk.org (Ilya Selivanau)
Date: Mon, 12 Feb 2024 16:16:11 GMT
Subject: RFR: CODETOOLS-7903176: Move LJV inside JOL [v8]
In-Reply-To: <LfP5rToH_1tGGp7x-CXp6zP0nY7QgARYtxEa1gEfN3M=.b7ddba39-d6bc-429e-abe9-e82fd42f56d1@github.com>
References: <Y_5-M6t_07RxJjUkvOUSc0pQNAxPLsW73t1rLn1oHmk=.cfae8829-0aba-4e08-841f-5b83d610d46b@github.com>
 <Giu9_0dEZMtIU23NHTYaN8UIpBCPAOqDs--gKlO4sEM=.4a39a73a-c099-467f-9a00-db2375623afa@github.com>
 <P2gm0oQvj5_e54R8TetO7VTk82MUxJFSJJsueF0fZRY=.12adca28-3765-411f-8b58-27e5ecb43ada@github.com>
 <LfP5rToH_1tGGp7x-CXp6zP0nY7QgARYtxEa1gEfN3M=.b7ddba39-d6bc-429e-abe9-e82fd42f56d1@github.com>
Message-ID: <KME7MZPOQY6FOWAj0SLk3_u_9nVS69O-I3racN3YeDk=.efde820d-b0a5-4a70-89d9-b3637741dfba@github.com>

On Sun, 11 Feb 2024 12:35:37 GMT, Georgy Guminov <duke at openjdk.org> wrote:

> Please also have each contributor listed in the change confirm in the PR comments that they would like to make this contribution, as this contribution has not been developed within this project.

I confirm that I would like to make this contribution

-------------

PR Comment: https://git.openjdk.org/jol/pull/24#issuecomment-1939028889