RFR: 7903652: JOL: Fix empty arrays visualization in LJV
Ivan Ponomarev
duke at openjdk.org
Tue Feb 6 23:32:02 UTC 2024
On Tue, 6 Feb 2024 09:45:32 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> Is there a pressing need to do it here? For example, does it make testing for this bugfix easier? If not, I would suggest we do it separately.
It's not that the reason is very pressing, but yes, running tests from IDE is not possible as target version for JOL is 1.8, while for LJV we used 11. Thus when you set JDK1.8 in IDEA all the tests targeted for 11 are ignored, and when you set JDK11, it won't compile as `sun.misc.Unsafe does not exist`.
I fully agree with the point that it's not good to bring two things in one pull request. But on the other hand, all the `*.approved.txt` files were going to be changed anyway, as we change arrays visualization. So it's either two PRs one after another, or merge conflicts. And on top of it I am still kinda scared by the PR handling throughput rate of this project, that's why I decided to make one PR instead of two.
So if you insist, I can split it into two PRs. If not really, let's just merge for now, and I will be sending more fine-grained PRs in the future
-------------
PR Comment: https://git.openjdk.org/jol/pull/57#issuecomment-1930942587
More information about the jol-dev
mailing list