From brian.kurotsuchi at oracle.com  Mon May  5 19:57:24 2014
From: brian.kurotsuchi at oracle.com (brian.kurotsuchi at oracle.com)
Date: Mon, 05 May 2014 19:57:24 +0000
Subject: hg: code-tools/jtharness: 3 new changesets
Message-ID: <201405051957.s45JvQ0b024914@aojmv0008>

Changeset: 246f955738d9
Author:    bkurotsu
Date:      2014-04-29 14:01 -0600
URL:       http://hg.openjdk.java.net/code-tools/jtharness/rev/246f955738d9

Added tag 4.6b05 for changeset 0ed5ae3cb5a2

+ .hgtags

Changeset: ea0e4338fccb
Author:    bkurotsu
Date:      2014-05-05 13:54 -0600
URL:       http://hg.openjdk.java.net/code-tools/jtharness/rev/ea0e4338fccb

7900156: Need shared agent class loader
Summary: Continuation of fixes to allow shared class loader to work.
Reviewed-by: bkurotsu
Contributed-by: alexey.x.fedorov at oracle.com

! src/com/sun/javatest/agent/Agent.java

Changeset: 348228eb67aa
Author:    bkurotsu
Date:      2014-05-05 13:57 -0600
URL:       http://hg.openjdk.java.net/code-tools/jtharness/rev/348228eb67aa

Removed tag 4.6b05

! .hgtags


From brian.kurotsuchi at oracle.com  Thu May  8 18:45:33 2014
From: brian.kurotsuchi at oracle.com (Brian Kurotsuchi)
Date: Thu, 08 May 2014 12:45:33 -0600
Subject: FOR REVIEW: CODETOOLS-7900280 Appearence Preferences
Message-ID: <536BD0CD.10707@oracle.com>

For review please.
https://bugs.openjdk.java.net/browse/CODETOOLS-7900280

    On the page "Appearance Preferences" in online help there is the
    section "Tool tip options". In the list of available options there
    is the option "Persistence". But actually this option is called
    "Duration" in javatest. This option should be renamed in online help



The only important part is the text change in the middle, the rest are 
header and footer updates.

Thanks!
Brian



diff --git a/src/com/sun/javatest/help/default/ui/appearancePrefs.html 
b/src/com/sun/javatest/help/default/ui/appearancePrefs.html
--- a/src/com/sun/javatest/help/default/ui/appearancePrefs.html
+++ b/src/com/sun/javatest/help/default/ui/appearancePrefs.html
@@ -2,25 +2,25 @@
  <!--
    $Id$

-  Copyright (c) 2001, 2011, Oracle and/or its affiliates. All rights 
reserved.
+  Copyright (c) 2001, 2014, Oracle and/or its affiliates. All rights 
reserved.
    DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
-
+
    This code is free software; you can redistribute it and/or modify it
    under the terms of the GNU General Public License version 2 only, as
    published by the Free Software Foundation.  Oracle designates this
    particular file as subject to the "Classpath" exception as provided
    by Oracle in the LICENSE file that accompanied this code.
-
+
    This code is distributed in the hope that it will be useful, but WITHOUT
    ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    version 2 for more details (a copy is included in the LICENSE file that
    accompanied this code).
-
+
    You should have received a copy of the GNU General Public License 
version
    2 along with this work; if not, write to the Free Software Foundation,
    Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
-
+
    Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    or visit www.oracle.com if you need additional information or have any
    questions.
@@ -105,10 +105,10 @@

  <tr valign="top">
  <td scope="row">
-Persistence
+Duration
  </td>
  <td>
-Use the combo box to select the duration that the GUI displays a tool tip.
+Use the combo box to select how long a tooltip will stay on the screen 
before hiding itself.
  </td>
  </tr>
  </table>
@@ -127,7 +127,7 @@

  <hr>

-<p><a href="../copyright.html">Copyright</a> &copy; 2001, 2011, Oracle 
and/or its affiliates. All rights reserved.</p>
+<p><a href="../copyright.html">Copyright</a> &copy; 2001, 2014, Oracle 
and/or its affiliates. All rights reserved.</p>
  </BODY>
  </HTML>

From brian.kurotsuchi at oracle.com  Thu May  8 19:19:46 2014
From: brian.kurotsuchi at oracle.com (Brian Kurotsuchi)
Date: Thu, 08 May 2014 13:19:46 -0600
Subject: FOR REVIEW: CODETOOLS-7900288 random stray chars in online help
Message-ID: <536BD8D2.208@oracle.com>


https://bugs.openjdk.java.net/browse/CODETOOLS-7900288

Sorry for all the noise in the diffs.  THe only important lines are the 
line 115 block in the first diff and line 41 in the second.

Thanks!
Brian



diff --git 
a/src/com/sun/javatest/help/default/confEdit/fullViewDialog.html 
b/src/com/sun/javatest/help/default/confEdit/fullViewDialog.html
--- a/src/com/sun/javatest/help/default/confEdit/fullViewDialog.html
+++ b/src/com/sun/javatest/help/default/confEdit/fullViewDialog.html
@@ -2,25 +2,25 @@
  <!--
    $Id$

-  Copyright (c) 2002, 2011, Oracle and/or its affiliates. All rights 
reserved.
+  Copyright (c) 2002, 2014, Oracle and/or its affiliates. All rights 
reserved.
    DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
-
+
    This code is free software; you can redistribute it and/or modify it
    under the terms of the GNU General Public License version 2 only, as
    published by the Free Software Foundation.  Oracle designates this
    particular file as subject to the "Classpath" exception as provided
    by Oracle in the LICENSE file that accompanied this code.
-
+
    This code is distributed in the hope that it will be useful, but WITHOUT
    ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    version 2 for more details (a copy is included in the LICENSE file that
    accompanied this code).
-
+
    You should have received a copy of the GNU General Public License 
version
    2 along with this work; if not, write to the Free Software Foundation,
    Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
-
+
    Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    or visit www.oracle.com if you need additional information or have any
    questions.
@@ -115,7 +115,7 @@

              <tr valign="top">
                  <td>New Configuration</td>
-                <td>Clears the current configuration and starts a new 
configuration. See <a href="createConfiguration.html">Creating a 
Configuration</a>> for a detailed description.
+                <td>Clears the current configuration and starts a new 
configuration. See <a href="createConfiguration.html">Creating a 
Configuration</a> for a detailed description.
                  </td>
              </tr>

@@ -200,14 +200,14 @@
              <tr valign="top">
                  <td>Unmark Current Question</td>
                  <td>
-                    Bookmarks the selected question in the 
Configuration Editor window. Enabled only if the selected question is 
not bookmarked.
+                    Bookmarks the selected question in the 
Configuration Editor window. Enabled only if the selected question is 
not bookmarked.
                  </td>
              </tr>

              <tr valign="top">
                  <td>Clear Answer For Current Question</td>
                  <td>
-                    Clears the answer for a selected question in the 
Configuration Editor window. Enabled only if the selected question is 
bookmarked.
+                    Clears the answer for a selected question in the 
Configuration Editor window. Enabled only if the selected question is 
bookmarked.
                  </td>
              </tr>

@@ -348,7 +348,7 @@
                      Displays  online help for the Configuration Editor 
window.
                  </td>
              </tr>
-
+
              <tr valign="top">
                  <td>Template Editor</td>
                  <td>
@@ -430,7 +430,7 @@
          <h3>More Info Pane</h3>
          <p>
              To open and close the More Info pane, choose View 
<b>&gt;</b> More Info from
-            the menu bar.
+            the menu bar.
          </p>
          <p>
              The More Info pane provides additional information about 
each question, including
@@ -454,7 +454,7 @@

      <hr>

-<p><a href="../copyright.html">Copyright</a> &copy; 2002, 2011, Oracle 
and/or its affiliates. All rights reserved.</p>
+<p><a href="../copyright.html">Copyright</a> &copy; 2002, 2014, Oracle 
and/or its affiliates. All rights reserved.</p>
  </BODY>
  </HTML>

diff --git a/src/com/sun/javatest/help/default/confEdit/status.html 
b/src/com/sun/javatest/help/default/confEdit/status.html
--- a/src/com/sun/javatest/help/default/confEdit/status.html
+++ b/src/com/sun/javatest/help/default/confEdit/status.html
@@ -2,25 +2,25 @@
  <!--
    $Id$

-  Copyright (c) 2001, 2011, Oracle and/or its affiliates. All rights 
reserved.
+  Copyright (c) 2001, 2014, Oracle and/or its affiliates. All rights 
reserved.
    DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
-
+
    This code is free software; you can redistribute it and/or modify it
    under the terms of the GNU General Public License version 2 only, as
    published by the Free Software Foundation.  Oracle designates this
    particular file as subject to the "Classpath" exception as provided
    by Oracle in the LICENSE file that accompanied this code.
-
+
    This code is distributed in the hope that it will be useful, but WITHOUT
    ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    version 2 for more details (a copy is included in the LICENSE file that
    accompanied this code).
-
+
    You should have received a copy of the GNU General Public License 
version
    2 along with this work; if not, write to the Free Software Foundation,
    Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
-
+
    Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    or visit www.oracle.com if you need additional information or have any
    questions.
@@ -41,7 +41,7 @@
  <p><!--CopyOff--><img src="../../images/hg_proc.gif" alt="This is the 
start of a procedure" longdesc="status.html"><!--CopyOn-->To
    specify prior status used to restrict the set of tests that are run, 
perform
    the following steps:</p>
->
+
  <ol>
    <li>Click the <img src="../../images/stdValues_button.gif" 
alt="QuickSet Mode button" width="10" height="11" 
longdesc="toolBar.html">Quick
      Set Mode button on the Test Manager tool bar or choose Configure
@@ -102,7 +102,7 @@
  Passed
  </td>
  <td>
-Selects tests with passing results the last time the test was executed.
+Selects tests with passing results the last time the test was executed.
  </td>
  </tr>

@@ -111,7 +111,7 @@
  Failed
  </td>
  <td>
-Selects tests with failed results the last time the test was executed.
+Selects tests with failed results the last time the test was executed.
  </td>
  </tr>

@@ -129,7 +129,7 @@
  Not Run
  </td>
  <td>
-Selects tests without results in the current work directory.
+Selects tests without results in the current work directory.
  </td>
  </tr>

@@ -171,7 +171,7 @@
  runs.</p>
  <p> </p>

-<hr><p><a href="../copyright.html">Copyright</a> &copy; 2001, 2011, 
Oracle and/or its affiliates. All rights reserved.</p>
+<hr><p><a href="../copyright.html">Copyright</a> &copy; 2001, 2014, 
Oracle and/or its affiliates. All rights reserved.</p>
  </BODY>
  </HTML>

From brian.kurotsuchi at oracle.com  Thu May  8 19:45:46 2014
From: brian.kurotsuchi at oracle.com (Brian Kurotsuchi)
Date: Thu, 08 May 2014 13:45:46 -0600
Subject: FOR REVIEW: CODETOOLS-7900284 - link to agent monitor incorrect in
	help
Message-ID: <536BDEEA.7080901@oracle.com>

https://bugs.openjdk.java.net/browse/CODETOOLS-7900284

Fixed. Although, the node in the immediate TOC location doesn't appear 
when you click the link, that is a virtual item in the TOC tree and the 
navigator takes you to the primary place where the Agent Monitor help 
exists.

An obvious fix isn't available since the TOC is built from mapped .csh 
targets but the help files contain basic hyperlinks. JH resolves these 
but doesn't know to stay in the local node of the help tree TOC.


diff --git a/src/com/sun/javatest/help/default/run/running.html 
b/src/com/sun/javatest/help/default/run/running.html
--- a/src/com/sun/javatest/help/default/run/running.html
+++ b/src/com/sun/javatest/help/default/run/running.html
@@ -2,25 +2,25 @@
  <!--
    $Id$

-  Copyright (c) 2001, 2011, Oracle and/or its affiliates. All rights 
reserved.
+  Copyright (c) 2001, 2014, Oracle and/or its affiliates. All rights 
reserved.
    DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
-
+
    This code is free software; you can redistribute it and/or modify it
    under the terms of the GNU General Public License version 2 only, as
    published by the Free Software Foundation.  Oracle designates this
    particular file as subject to the "Classpath" exception as provided
    by Oracle in the LICENSE file that accompanied this code.
-
+
    This code is distributed in the hope that it will be useful, but WITHOUT
    ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    version 2 for more details (a copy is included in the LICENSE file that
    accompanied this code).
-
+
    You should have received a copy of the GNU General Public License 
version
    2 along with this work; if not, write to the Free Software Foundation,
    Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
-
+
    Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    or visit www.oracle.com if you need additional information or have any
    questions.
@@ -57,7 +57,7 @@

  <p>
  The harness saves all test results after running tests but does not 
automatically generate reports of test results. You must generate test 
reports from the Test Manager or from the command line. See <a 
href="../report/usingReports.html">Generating and Viewing Reports</a> 
for detailed information about reports.
-</p>
+</p>

  <p>
  If you use the All Tests view filter and begin a test run, the harness 
displays an advisory dialog box. Using the All Test view filter displays 
the results of all tests in a test suite regardless of whether or not 
they are included in the test run.
@@ -81,21 +81,21 @@
      how to use the Test Manager (including the use of the Log Viewer) 
to monitor a test run.
  </li>
  <li>
-  <a href="monitoring.html"><b>Monitoring Agents</b></A> - Describes
+  <a href="../ui/agentMonitor.html"><b>Monitoring Agents</b></A> - 
Describes
      how to use the Agent Monitor tool to monitor agent activity during 
a test run.
  </li>
  <li>
    <a href="stopping.html"><b>Stopping a Test Run</b></A> - Describes
-    how to use the Test Manager to stop a test run.
+    how to use the Test Manager to stop a test run.
  </li>
  <li>
    <a href="troubleshooting.html"><b>Troubleshooting a Test Run</b></A> 
- Describes
-    how to use the Test Manager to troubleshoot a test run.
+    how to use the Test Manager to troubleshoot a test run.
  </li>
  </ul>
  <hr>

-<p><a href="../copyright.html">Copyright</a> &copy; 2001, 2011, Oracle 
and/or its affiliates. All rights reserved.</p>
+<p><a href="../copyright.html">Copyright</a> &copy; 2001, 2014, Oracle 
and/or its affiliates. All rights reserved.</p>
  </BODY>
  </HTML>

From brian.kurotsuchi at oracle.com  Fri May  9 04:23:02 2014
From: brian.kurotsuchi at oracle.com (Brian Kurotsuchi)
Date: Thu, 08 May 2014 22:23:02 -0600
Subject: FOR REVIEW: CODETOOLS-7900889 tooltip in QSW when not needed
Message-ID: <536C5826.7000102@oracle.com>

http://cr.openjdk.java.net/~bkurotsu/7900889-1/

From brian.kurotsuchi at oracle.com  Fri May 16 00:03:24 2014
From: brian.kurotsuchi at oracle.com (Brian Kurotsuchi)
Date: Thu, 15 May 2014 18:03:24 -0600
Subject: FOR REVIEW: CODETOOLS-7900902 Agent.Task.getResourceData incorrect
	for empty files
Message-ID: <537555CC.7060605@oracle.com>

https://bugs.openjdk.java.net/browse/CODETOOLS-7900902

Diffs:
http://cr.openjdk.java.net/~bkurotsu/7900902/

Original contribution by Alexey Fedorov, modified for use by me.

Summary:
Javadoc says that (for the downstream method which uses the wire 
protocol result):
     RETURNS - An input stream for reading the resource, or null if the 
resource could not be found

We currently return a null (missing) case for both missing and empty 
results to the resource request.  JT Agent wire protocol doesn't support 
missing vs zero length.  This code modification makes (missing == -1), 
(zero length == 0).

Alexey has already positively tested the fix for his needs.

From brian.kurotsuchi at oracle.com  Fri May 16 18:28:21 2014
From: brian.kurotsuchi at oracle.com (brian.kurotsuchi at oracle.com)
Date: Fri, 16 May 2014 18:28:21 +0000
Subject: hg: code-tools/jtharness: 7900280: terminology mismatch in Appearance
	Prefs help
Message-ID: <201405161828.s4GISLaS005521@aojmv0008>

Changeset: bd65c54dd5f6
Author:    bkurotsu
Date:      2014-05-16 12:28 -0600
URL:       http://hg.openjdk.java.net/code-tools/jtharness/rev/bd65c54dd5f6

7900280: terminology mismatch in Appearance Prefs help
Summary: Persistence -> Duration

! src/com/sun/javatest/help/default/ui/appearancePrefs.html


From brian.kurotsuchi at oracle.com  Fri May 16 18:29:42 2014
From: brian.kurotsuchi at oracle.com (brian.kurotsuchi at oracle.com)
Date: Fri, 16 May 2014 18:29:42 +0000
Subject: hg: code-tools/jtharness: 7900288: random stray chars in online help
Message-ID: <201405161829.s4GIThHg005684@aojmv0008>

Changeset: faa85fd5492f
Author:    bkurotsu
Date:      2014-05-16 12:29 -0600
URL:       http://hg.openjdk.java.net/code-tools/jtharness/rev/faa85fd5492f

7900288: random stray chars in online help
Summary: Removed chars clearly leftover from edits

! src/com/sun/javatest/help/default/confEdit/fullViewDialog.html
! src/com/sun/javatest/help/default/confEdit/status.html


From brian.kurotsuchi at oracle.com  Fri May 16 18:32:12 2014
From: brian.kurotsuchi at oracle.com (brian.kurotsuchi at oracle.com)
Date: Fri, 16 May 2014 18:32:12 +0000
Subject: hg: code-tools/jtharness: 7900284: link to agent monitor incorrect in
	help
Message-ID: <201405161832.s4GIWCsu006104@aojmv0008>

Changeset: 86881d44c1e9
Author:    bkurotsu
Date:      2014-05-16 12:32 -0600
URL:       http://hg.openjdk.java.net/code-tools/jtharness/rev/86881d44c1e9

7900284: link to agent monitor incorrect in help
Summary: Fix link to agent monitor in help (running) section, was linked to wrong file.

! src/com/sun/javatest/help/default/run/running.html


From brian.kurotsuchi at oracle.com  Fri May 16 18:34:06 2014
From: brian.kurotsuchi at oracle.com (brian.kurotsuchi at oracle.com)
Date: Fri, 16 May 2014 18:34:06 +0000
Subject: hg: code-tools/jtharness: 7900889: random tooltip for invisible error
	files in QSW
Message-ID: <201405161834.s4GIY7Mi006532@aojmv0008>

Changeset: 1830e96cc48e
Author:    bkurotsu
Date:      2014-05-16 12:33 -0600
URL:       http://hg.openjdk.java.net/code-tools/jtharness/rev/1830e96cc48e

7900889: random tooltip for invisible error files in QSW
Summary: Tooltip for help field was active even if there was no visible text.  Made component invisible instead of simply enabled+blank.

! src/com/sun/javatest/exec/QuickStartWizard.java


From brian.kurotsuchi at oracle.com  Fri May 16 18:46:49 2014
From: brian.kurotsuchi at oracle.com (brian.kurotsuchi at oracle.com)
Date: Fri, 16 May 2014 18:46:49 +0000
Subject: hg: code-tools/jtharness: 7900902: Agent.Task.getResourceData
	incorrectly throws MissingResourceException for empty resource files
Message-ID: <201405161846.s4GIkobY008563@aojmv0008>

Changeset: eb678650d7c1
Author:    bkurotsu
Date:      2014-05-16 12:46 -0600
URL:       http://hg.openjdk.java.net/code-tools/jtharness/rev/eb678650d7c1

7900902: Agent.Task.getResourceData incorrectly throws MissingResourceException for empty resource files
Summary: Agent wire protocol was not able to distinguish between a missing resource and an empty one.

! src/com/sun/javatest/agent/Agent.java
! src/com/sun/javatest/agent/AgentManager.java


From brian.kurotsuchi at oracle.com  Mon May 19 19:54:30 2014
From: brian.kurotsuchi at oracle.com (Brian Kurotsuchi)
Date: Mon, 19 May 2014 13:54:30 -0600
Subject: FOR REVIEW: CODETOOLS-7900909 trailing space in JTR entry for script
Message-ID: <537A6176.3060208@oracle.com>

http://cr.openjdk.java.net/~bkurotsu/7900909/

As you can see in the code, the old code will generate a trailing space 
if the args are zero length.

No problems reported with this, I just noticed this while debugging 
something else.

From brian.kurotsuchi at oracle.com  Thu May 22 18:06:27 2014
From: brian.kurotsuchi at oracle.com (brian.kurotsuchi at oracle.com)
Date: Thu, 22 May 2014 18:06:27 +0000
Subject: hg: code-tools/jtharness: CODETOOLS-7900283 wrong filenames in list
	of optional KFL files
Message-ID: <201405221806.s4MI6S40000442@aojmv0008>

Changeset: 1d58f2db43ec
Author:    bkurotsu
Date:      2014-05-22 12:06 -0600
URL:       http://hg.openjdk.java.net/code-tools/jtharness/rev/1d58f2db43ec

CODETOOLS-7900283 wrong filenames in list of optional KFL files

! src/com/sun/javatest/help/default/report/newReports.html


From Mikhail.Ershov at oracle.com  Fri May 23 09:47:17 2014
From: Mikhail.Ershov at oracle.com (Mike Ershov)
Date: Fri, 23 May 2014 02:47:17 -0700
Subject: FOR REVIEW: CODETOOLS-7900902 Agent.Task.getResourceData incorrect
	for empty files
In-Reply-To: <537555CC.7060605@oracle.com>
References: <537555CC.7060605@oracle.com>
Message-ID: <537F1925.8090000@oracle.com>

Hi Brian,

For me everything is ok with this fix, integrate it.

Thanks,
Mike



On 05/15/2014 05:03 PM, Brian Kurotsuchi wrote:
> https://bugs.openjdk.java.net/browse/CODETOOLS-7900902
>
> Diffs:
> http://cr.openjdk.java.net/~bkurotsu/7900902/
>
> Original contribution by Alexey Fedorov, modified for use by me.
>
> Summary:
> Javadoc says that (for the downstream method which uses the wire 
> protocol result):
>     RETURNS - An input stream for reading the resource, or null if the 
> resource could not be found
>
> We currently return a null (missing) case for both missing and empty 
> results to the resource request.  JT Agent wire protocol doesn't 
> support missing vs zero length.  This code modification makes (missing 
> == -1), (zero length == 0).
>
> Alexey has already positively tested the fix for his needs.


From brian.kurotsuchi at oracle.com  Thu May 22 22:49:36 2014
From: brian.kurotsuchi at oracle.com (brian.kurotsuchi at oracle.com)
Date: Thu, 22 May 2014 22:49:36 +0000
Subject: hg: code-tools/jtharness: Basic updates to make version 4.6
Message-ID: <201405222249.s4MMna96017165@aojmv0008>

Changeset: 6cef150df5cc
Author:    bkurotsu
Date:      2014-05-22 16:49 -0600
URL:       http://hg.openjdk.java.net/code-tools/jtharness/rev/6cef150df5cc

Basic updates to make version 4.6

! build/build.properties


From Mikhail.Ershov at oracle.com  Fri May 23 10:59:56 2014
From: Mikhail.Ershov at oracle.com (Mike Ershov)
Date: Fri, 23 May 2014 03:59:56 -0700
Subject: FOR REVIEW: CODETOOLS-7900909 trailing space in JTR entry for
	script
In-Reply-To: <537A6176.3060208@oracle.com>
References: <537A6176.3060208@oracle.com>
Message-ID: <537F2A2C.1070702@oracle.com>

Hi,

In general, this is correct fix. But I'd simply surround it trim(), 
something like this:

String sargs = (this.getClass().getName() + " " + 
StringArray.join(scriptArgs)).trim();
testResult.putProperty(TestResult.SCRIPT,  sargs);

Again, your code is correct, this is just a question of preferences.

Mike

On 05/19/2014 12:54 PM, Brian Kurotsuchi wrote:
> http://cr.openjdk.java.net/~bkurotsu/7900909/
>
> As you can see in the code, the old code will generate a trailing 
> space if the args are zero length.
>
> No problems reported with this, I just noticed this while debugging 
> something else.


From brian.kurotsuchi at oracle.com  Thu May 22 23:03:28 2014
From: brian.kurotsuchi at oracle.com (Brian Kurotsuchi)
Date: Thu, 22 May 2014 17:03:28 -0600
Subject: FOR REVIEW: CODETOOLS-7900909 trailing space in JTR entry for
	script
In-Reply-To: <537F2A2C.1070702@oracle.com>
References: <537A6176.3060208@oracle.com> <537F2A2C.1070702@oracle.com>
Message-ID: <537E8240.5090107@oracle.com>

You are right, that is a simple solution.  I already tested this version 
though, so let's go with the more complex code.  :)



On 5/23/14 04:59, Mike Ershov wrote:
> Hi,
>
> In general, this is correct fix. But I'd simply surround it trim(), 
> something like this:
>
> String sargs = (this.getClass().getName() + " " + 
> StringArray.join(scriptArgs)).trim();
> testResult.putProperty(TestResult.SCRIPT,  sargs);
>
> Again, your code is correct, this is just a question of preferences.
>
> Mike
>
> On 05/19/2014 12:54 PM, Brian Kurotsuchi wrote:
>> http://cr.openjdk.java.net/~bkurotsu/7900909/
>>
>> As you can see in the code, the old code will generate a trailing 
>> space if the args are zero length.
>>
>> No problems reported with this, I just noticed this while debugging 
>> something else.
>


From brian.kurotsuchi at oracle.com  Thu May 22 23:07:03 2014
From: brian.kurotsuchi at oracle.com (brian.kurotsuchi at oracle.com)
Date: Thu, 22 May 2014 23:07:03 +0000
Subject: hg: code-tools/jtharness: 7900909: trailing space in JTR entry for
	script
Message-ID: <201405222307.s4MN73ne020379@aojmv0008>

Changeset: b39509ea8e4a
Author:    bkurotsu
Date:      2014-05-22 17:06 -0600
URL:       http://hg.openjdk.java.net/code-tools/jtharness/rev/b39509ea8e4a

7900909: trailing space in JTR entry for script
Summary: dont' include trailing space in property value if there are no args
Reviewed-by: ersh

! src/com/sun/javatest/Script.java


From brian.kurotsuchi at oracle.com  Fri May 23 19:23:58 2014
From: brian.kurotsuchi at oracle.com (brian.kurotsuchi at oracle.com)
Date: Fri, 23 May 2014 19:23:58 +0000
Subject: hg: code-tools/jtharness: 7900883: [usability] ChoiceArrayQuestion in
	the interview is left-justified on the panel
Message-ID: <201405231923.s4NJNxXF008130@aojmv0008>

Changeset: 33227a8c085b
Author:    bkurotsu
Date:      2014-05-23 13:23 -0600
URL:       http://hg.openjdk.java.net/code-tools/jtharness/rev/33227a8c085b

7900883: [usability] ChoiceArrayQuestion in the interview is left-justified on the panel
Summary: rendering changed so right (last) column of table takes up extra horizontal space
Reviewed-by: ersh

! src/com/sun/interview/wizard/ChoiceArrayQuestionRenderer.java


From brian.kurotsuchi at oracle.com  Fri May 30 17:13:04 2014
From: brian.kurotsuchi at oracle.com (brian.kurotsuchi at oracle.com)
Date: Fri, 30 May 2014 17:13:04 +0000
Subject: hg: code-tools/jtharness: Summary: Set basic set of ignores for work
	with Netbeans and IDEA
Message-ID: <201405301713.s4UHD4ac018505@aojmv0008>

Changeset: 7a062f84e1e9
Author:    bkurotsu
Date:      2014-05-30 11:12 -0600
URL:       http://hg.openjdk.java.net/code-tools/jtharness/rev/7a062f84e1e9

Summary: Set basic set of ignores for work with Netbeans and IDEA
Reviewed-by: ersh

+ .hgignore