RFR: CODETOOLS-7902271: Use a standard collection instead of custom com/sun/javatest/util/Fifo container
Jonathan Gibbons
jonathan.gibbons at oracle.com
Fri Aug 10 00:23:17 UTC 2018
Looks good.
You might want to (re)consider your IDE settings for collapsing imports.
This proposed update to the styleguide suggests that in general wildcard
imports should not be used.
http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html#toc-import-statements
-- Jon
On 08/09/2018 04:45 PM, dmitry.bessonov at oracle.com wrote:
> Please review a fix to remove a custom container
> com/sun/javatest/util/Fifo:
>
> JBS: https://bugs.openjdk.java.net/browse/CODETOOLS-7902271
> Webrev: http://cr.openjdk.java.net/~dbessono/7902271/webrev/
>
> j.u.ArrayDeque [1] chosen as a Queue [2] implementation to replace
> Fifo class.
>
> Fifo::new -> Queue::new
> Fifo::insert -> Queue::offer
> Fifo::remove -> Queue::poll
> Fifo::flush -> Queue::clear
> Fifo::size -> Queue::size
> Fifo::isEmpty -> Queue::isEmpty
> Fifo::clear -> Queue::clear
>
>
> dmitry
>
> [1] https://docs.oracle.com/javase/7/docs/api/java/util/ArrayDeque.html
> [2] https://docs.oracle.com/javase/7/docs/api/java/util/Queue.html
>
More information about the jtharness-dev
mailing list