RFR: CODETOOLS-7902215: Follow-up generification and misc, part 3

Jonathan Gibbons jonathan.gibbons at oracle.com
Fri Jul 13 00:18:22 UTC 2018



On 07/12/2018 04:00 PM, dmitry.bessonov at oracle.com wrote:
>
>
> On 12/07/2018 23:28, Jonathan Gibbons wrote:
>>
>>
>> On 07/12/2018 07:27 AM, dmitry.bessonov at oracle.com wrote:
>>> Please review the following follow-up fix related to generics usage 
>>> in JTHarness code; also compatibility with JTReg codebase has been 
>>> restored.
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/CODETOOLS-7902215
>>> Webrev: http://cr.openjdk.java.net/~dbessono/7902215/webrev/
>>>
>>>
>>> dmitry
>>
>> Standard comments: there's more cleanup that can be done, like 
>> replacing Iterator.
>>
>> Watch for long lines: they make webrevs harder to read.
>>
>> The edit to src/com/sun/javatest/util/Properties.java is somewhat 
>> regressive,
>> and should be fixed.  It is preferable to use '{@code Map<String, 
>> String>}'
>> instead of the raw HTML equivalent.
>
> Updated the patch; new webrev is at
> http://cr.openjdk.java.net/~dbessono/7902215/01/webrev/
>
> Besides src/com/sun/javatest/util/Properties.java also used {@code} in 
> src/com/sun/javatest/TestEnvironment.java
>
>
> dmitry
>
>>
>> -- Jon

Pushed

-- Jon


More information about the jtharness-dev mailing list