RFR: CODETOOLS-7902402: Timestamped testing progress in harness.trace

dmitry.bessonov at oracle.com dmitry.bessonov at oracle.com
Mon Feb 25 16:14:59 UTC 2019


Thank you for the review, an updated patch is at:
http://cr.openjdk.java.net/~dbessono/7902402.1/

dmitry

On 25/02/2019 06:58, Jonathan Gibbons wrote:
> Minor suggestion to avoid the composite word "skiptimestamp" and invert 
> the sense of the property
> 
> e.g. javatest.trace.timestamp=false
> 
> I'm not suggesting to change the default, which is timestamps enabled.
> 
> I don't think you need to allow the user to change it; if you wanted to 
> do that, the user could supply a format string in a property. But most 
> people don't look at this file, except in extreme debug need, when a 
> simple predictable parseable format is good enough.
> 
> -- Jon
> 
> On 2/24/19 4:36 PM, dmitry.bessonov at oracle.com wrote:
>> Please review this change which adds time-stamping to the progress 
>> logged in harness.trace file.
>>
>> Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7902402
>> Webrev: http://cr.openjdk.java.net/~dbessono/7902402/
>>
>> Timestamping could be disabled by setting 
>> 'javatest.trace.skiptimestamp' system property to 'true'.
>>
>> Timestamp format is "yyyy-MM-dd'T'HH:mm:ssZ" (should we allow user to 
>> change it?)
>>
>> dmitry


More information about the jtharness-dev mailing list