RFR: Fix jtreg build with /usr/bin/git available
Dmitry Bessonov
dbessono at openjdk.org
Wed Aug 17 11:00:26 UTC 2022
On Tue, 16 Aug 2022 19:13:04 GMT, Jan Kratochvil <duke at openjdk.org> wrote:
> I have tried to rebase JTREG on top of `jt6.0-b23` or `master` of jtharness but with `/usr/bin/git` available JTREG then does not build:
>
> generate.release.file:
> BUILD FAILED
> .../jtreg/build/deps/jtharness/src/jtharness-jt6.0-b23/build/build.xml:277: exec returned: 128
>
> This reverts a part of commit [8a0bc39980118fc47d9fbe161f1bc1fa75aa854b](https://github.com/openjdk/jtharness/commit/8a0bc39980118fc47d9fbe161f1bc1fa75aa854b) by @dbessono where this change is not described and it may have been unintentional.
> Unforunately I am not yet Author so I do not yet have a JBS account so I cannot file it to JBS (Java Bug System).
The proposed changes simply disable build failure on error. The context of the code block is https://bugs.openjdk.org/browse/CODETOOLS-7902794 with few follow up enhancements. Is it `--git-dir=${basedir}/.git` in the line `<arg line="--git-dir=${basedir}/.git log -1 --format=%h"/>` which is causing failure for in your env ?
-------------
PR: https://git.openjdk.org/jtharness/pull/34
More information about the jtharness-dev
mailing list