RFR: 7902698: Collision of zero timestamp as a special value with use in filesystems [v2]

Dmitry Bessonov dbessono at openjdk.java.net
Thu Feb 3 14:54:18 UTC 2022


On Wed, 2 Feb 2022 22:42:24 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> src/com/sun/javatest/TRT_TreeNode.java line 794:
>> 
>>> 792:         File thisDir = new File(TestResultTable.getRootRelativePath(this));
>>> 793:         long lmd = table.getLastModifiedTime(thisDir);
>>> 794:         if (lastScanDate.isEmpty() || lmd <= lastScanDate.getAsLong()) {
>> 
>> Seen a failure of com.sun.javatest.SelectionTest when checking the latest patch... It seems that here a more correct replacement could be
>> 
>> 
>>         if (lastScanDate.isPresent() && lmd <= lastScanDate.getAsLong()) {
>>             return;
>>         }
>
> Thanks for the catch, I have implemented the suggested fix and verified the test is now passing

thank you

-------------

PR: https://git.openjdk.java.net/jtharness/pull/22


More information about the jtharness-dev mailing list