From duke at openjdk.java.net  Tue Jan 11 08:36:39 2022
From: duke at openjdk.java.net (gollayadav)
Date: Tue, 11 Jan 2022 08:36:39 GMT
Subject: Withdrawn: 7903076: Feature Tests - Adding five JavaTest GUI legacy
 automated feature test scripts
In-Reply-To: <Sy0vEpWpBPDPKKUY9OoZRKmhyMziC9IjjjkBTNJZ_64=.337bc32f-2699-4879-9b98-81d8e7848eae@github.com>
References: <Sy0vEpWpBPDPKKUY9OoZRKmhyMziC9IjjjkBTNJZ_64=.337bc32f-2699-4879-9b98-81d8e7848eae@github.com>
Message-ID: <FEWvdFT2S5IFW2CCMOvuH7AKsf4ZhScopf_3okxEdh8=.ed24c0a5-6d60-4b1a-b296-8812e9607f80@github.com>

On Wed, 15 Dec 2021 13:44:02 GMT, gollayadav <duke at openjdk.java.net> wrote:

> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.
> 
> 1.Browse5.java
> 2.Browse8.java
> 3.Config_Edit3.java
> 4.Config_Edit4.java
> 5.Config_Edit5.java

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jtharness/pull/19

From duke at openjdk.java.net  Tue Jan 11 08:38:54 2022
From: duke at openjdk.java.net (gollayadav)
Date: Tue, 11 Jan 2022 08:38:54 GMT
Subject: RFR: 7903076: Feature Tests - Adding five JavaTest GUI legacy
 automated feature test scripts
Message-ID: <GkbruNXGgyVtFW7liizpVV3m0tiv7Z-cqJqMcXlo5Fg=.330f8e77-c7dc-47ed-8a91-35c0e454c98c@github.com>

Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.

1.Browse5.java
2.Browse8.java
3.Config_Edit3.java
4.Config_Edit4.java
5.Config_Edit5.java

-------------

Commit messages:
 - 7903076: Feature Tests - Updated Config_Edit3 script
 - Update Config_Edit3.java
 - 7903076: Feature Tests - Corrected the whitespace errors
 - 7903076: Feature Tests - Adding five JavaTest GUI legacy automated feature test scripts

Changes: https://git.openjdk.java.net/jtharness/pull/21/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtharness&pr=21&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903076
  Stats: 438 lines in 9 files changed: 425 ins; 3 del; 10 mod
  Patch: https://git.openjdk.java.net/jtharness/pull/21.diff
  Fetch: git fetch https://git.openjdk.java.net/jtharness pull/21/head:pull/21

PR: https://git.openjdk.java.net/jtharness/pull/21

From duke at openjdk.java.net  Tue Jan 11 13:48:18 2022
From: duke at openjdk.java.net (gollayadav)
Date: Tue, 11 Jan 2022 13:48:18 GMT
Subject: RFR: 7903079: Feature Tests - Adding six JavaTest GUI legacy
 automated test scripts [v2]
In-Reply-To: <ozrUX_nRSVKQVxn1wJT5HAroq4484SjhVHRigf0kA-A=.0314baee-f0e8-4e88-8753-fd44027c817c@github.com>
References: <ozrUX_nRSVKQVxn1wJT5HAroq4484SjhVHRigf0kA-A=.0314baee-f0e8-4e88-8753-fd44027c817c@github.com>
Message-ID: <M_FvKdQyrelOMEuUGPik8h7fu8ewbwZTVsiCN6tvpoE=.167c8933-7aea-49bf-8239-dd6b73cc85be@github.com>

> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.
> 
> 1. Config_Edit6
> 2. Config_Edit7
> 3. Config_Load1
> 4. Config_Load2
> 5. Config_Load3
> 6. Config_Load4

gollayadav has updated the pull request incrementally with one additional commit since the last revision:

  7903079: Feature Tests - Updated 'Config_Edit6' test script.

-------------

Changes:
  - all: https://git.openjdk.java.net/jtharness/pull/20/files
  - new: https://git.openjdk.java.net/jtharness/pull/20/files/127e0da5..505de573

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtharness&pr=20&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jtharness&pr=20&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jtharness/pull/20.diff
  Fetch: git fetch https://git.openjdk.java.net/jtharness pull/20/head:pull/20

PR: https://git.openjdk.java.net/jtharness/pull/20

From duke at openjdk.java.net  Thu Jan 13 19:18:13 2022
From: duke at openjdk.java.net (gollayadav)
Date: Thu, 13 Jan 2022 19:18:13 GMT
Subject: RFR: 7903076: Feature Tests - Adding five JavaTest GUI legacy
 automated feature test scripts [v2]
In-Reply-To: <GkbruNXGgyVtFW7liizpVV3m0tiv7Z-cqJqMcXlo5Fg=.330f8e77-c7dc-47ed-8a91-35c0e454c98c@github.com>
References: <GkbruNXGgyVtFW7liizpVV3m0tiv7Z-cqJqMcXlo5Fg=.330f8e77-c7dc-47ed-8a91-35c0e454c98c@github.com>
Message-ID: <HZeBL9zNh3M9vBzAT95FTcKDpkErdIcJlwpAVf_r6ZI=.80123ed2-0ac1-41a9-9147-d84c6dc26aeb@github.com>

> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.
> 
> 1.Browse5.java
> 2.Browse8.java
> 3.Config_Edit3.java
> 4.Config_Edit4.java
> 5.Config_Edit5.java

gollayadav has updated the pull request incrementally with one additional commit since the last revision:

  7903076: Feature Tests - Updated Config_Edit5.java

-------------

Changes:
  - all: https://git.openjdk.java.net/jtharness/pull/21/files
  - new: https://git.openjdk.java.net/jtharness/pull/21/files/c8e2187a..02a67bd8

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtharness&pr=21&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jtharness&pr=21&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jtharness/pull/21.diff
  Fetch: git fetch https://git.openjdk.java.net/jtharness pull/21/head:pull/21

PR: https://git.openjdk.java.net/jtharness/pull/21

From cushon at openjdk.java.net  Thu Jan 20 03:33:18 2022
From: cushon at openjdk.java.net (Liam Miller-Cushon)
Date: Thu, 20 Jan 2022 03:33:18 GMT
Subject: RFR: 7902698: Collision of zero timestamp as a special value with use
 in filesystems
Message-ID: <VSWQ-3gxs9MX_WnzgrGCs7PEhCTpw3Q_nJdJ8XhmBU0=.22698bb4-f8dc-4b76-a338-3976d56c85a0@github.com>

This fixes a bug when the timestamp of a test file is set to zero, since jtharness currently uses zero as a special value. See discussion in [CODETOOLS-7902698](https://bugs.openjdk.java.net/browse/CODETOOLS-7902698).

-------------

Commit messages:
 - 7902698: Collision of zero timestamp as a special value with use in filesystems

Changes: https://git.openjdk.java.net/jtharness/pull/22/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jtharness&pr=22&range=00
  Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902698
  Stats: 10 lines in 3 files changed: 0 ins; 0 del; 10 mod
  Patch: https://git.openjdk.java.net/jtharness/pull/22.diff
  Fetch: git fetch https://git.openjdk.java.net/jtharness pull/22/head:pull/22

PR: https://git.openjdk.java.net/jtharness/pull/22

From dbessono at openjdk.java.net  Tue Jan 25 19:26:47 2022
From: dbessono at openjdk.java.net (Dmitry Bessonov)
Date: Tue, 25 Jan 2022 19:26:47 GMT
Subject: RFR: 7903076: Feature Tests - Adding five JavaTest GUI legacy
 automated feature test scripts [v2]
In-Reply-To: <HZeBL9zNh3M9vBzAT95FTcKDpkErdIcJlwpAVf_r6ZI=.80123ed2-0ac1-41a9-9147-d84c6dc26aeb@github.com>
References: <GkbruNXGgyVtFW7liizpVV3m0tiv7Z-cqJqMcXlo5Fg=.330f8e77-c7dc-47ed-8a91-35c0e454c98c@github.com>
 <HZeBL9zNh3M9vBzAT95FTcKDpkErdIcJlwpAVf_r6ZI=.80123ed2-0ac1-41a9-9147-d84c6dc26aeb@github.com>
Message-ID: <VvEtUymFSN3K9dba7cRSDXuiPfAj7x7oCeFj33YWSuU=.020148c6-70b1-4248-aec5-b01660bf49a5@github.com>

On Thu, 13 Jan 2022 19:18:13 GMT, gollayadav <duke at openjdk.java.net> wrote:

>> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.
>> 
>> 1.Browse5.java
>> 2.Browse8.java
>> 3.Config_Edit3.java
>> 4.Config_Edit4.java
>> 5.Config_Edit5.java
>
> gollayadav has updated the pull request incrementally with one additional commit since the last revision:
> 
>   7903076: Feature Tests - Updated Config_Edit5.java

Marked as reviewed by dbessono (Committer).

-------------

PR: https://git.openjdk.java.net/jtharness/pull/21

From dbessono at openjdk.java.net  Tue Jan 25 19:36:40 2022
From: dbessono at openjdk.java.net (Dmitry Bessonov)
Date: Tue, 25 Jan 2022 19:36:40 GMT
Subject: RFR: 7903079: Feature Tests - Adding six JavaTest GUI legacy
 automated test scripts [v2]
In-Reply-To: <M_FvKdQyrelOMEuUGPik8h7fu8ewbwZTVsiCN6tvpoE=.167c8933-7aea-49bf-8239-dd6b73cc85be@github.com>
References: <ozrUX_nRSVKQVxn1wJT5HAroq4484SjhVHRigf0kA-A=.0314baee-f0e8-4e88-8753-fd44027c817c@github.com>
 <M_FvKdQyrelOMEuUGPik8h7fu8ewbwZTVsiCN6tvpoE=.167c8933-7aea-49bf-8239-dd6b73cc85be@github.com>
Message-ID: <4ZGo58VXZhGhhGX1HzumBEwPPMGQkXqvXd_5BJEewaY=.1351c3ea-272e-4c0f-adcb-dc1420160d95@github.com>

On Tue, 11 Jan 2022 13:48:18 GMT, gollayadav <duke at openjdk.java.net> wrote:

>> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.
>> 
>> 1. Config_Edit6
>> 2. Config_Edit7
>> 3. Config_Load1
>> 4. Config_Load2
>> 5. Config_Load3
>> 6. Config_Load4
>
> gollayadav has updated the pull request incrementally with one additional commit since the last revision:
> 
>   7903079: Feature Tests - Updated 'Config_Edit6' test script.

Marked as reviewed by dbessono (Committer).

-------------

PR: https://git.openjdk.java.net/jtharness/pull/20

From dbessono at openjdk.java.net  Tue Jan 25 20:31:40 2022
From: dbessono at openjdk.java.net (Dmitry Bessonov)
Date: Tue, 25 Jan 2022 20:31:40 GMT
Subject: RFR: 7902698: Collision of zero timestamp as a special value with
 use in filesystems
In-Reply-To: <VSWQ-3gxs9MX_WnzgrGCs7PEhCTpw3Q_nJdJ8XhmBU0=.22698bb4-f8dc-4b76-a338-3976d56c85a0@github.com>
References: <VSWQ-3gxs9MX_WnzgrGCs7PEhCTpw3Q_nJdJ8XhmBU0=.22698bb4-f8dc-4b76-a338-3976d56c85a0@github.com>
Message-ID: <E7K-AVj9rHYF7pVz7-Rfkd6ku_5h_TJ4Wu3zJpOJpGM=.b34e99ac-04de-47fb-b5e7-e099e151269d@github.com>

On Thu, 20 Jan 2022 03:27:00 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

> This fixes a bug when the timestamp of a test file is set to zero, since jtharness currently uses zero as a special value. See discussion in [CODETOOLS-7902698](https://bugs.openjdk.java.net/browse/CODETOOLS-7902698).

It seems that previously zero default value served as "undefined yet" for these fields, now switched to "-1" as their default value. However 'URLConnection::getLastModified' returns "0 if not known" and 'File::lastModified' spec asserts: "returns 0L if the file does not exist or if an I/O error occurs. The value may be negative indicating the number of milliseconds before the epoch". 

It possibly would be more reliable and readable to switch types of these fields from 'long' to OptionalLong with OptionalLong.empty() as their default value.

-------------

PR: https://git.openjdk.java.net/jtharness/pull/22

From cushon at openjdk.java.net  Tue Jan 25 22:40:07 2022
From: cushon at openjdk.java.net (Liam Miller-Cushon)
Date: Tue, 25 Jan 2022 22:40:07 GMT
Subject: RFR: 7902698: Collision of zero timestamp as a special value with
 use in filesystems [v2]
In-Reply-To: <VSWQ-3gxs9MX_WnzgrGCs7PEhCTpw3Q_nJdJ8XhmBU0=.22698bb4-f8dc-4b76-a338-3976d56c85a0@github.com>
References: <VSWQ-3gxs9MX_WnzgrGCs7PEhCTpw3Q_nJdJ8XhmBU0=.22698bb4-f8dc-4b76-a338-3976d56c85a0@github.com>
Message-ID: <8qzt2ZPEQTWGjppg_mc1nNzPEwnwu0F-5tazmMqhRSA=.9c043d44-ea16-4a32-97ae-f3c2716ae2f8@github.com>

> This fixes a bug when the timestamp of a test file is set to zero, since jtharness currently uses zero as a special value. See discussion in [CODETOOLS-7902698](https://bugs.openjdk.java.net/browse/CODETOOLS-7902698).

Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:

  Use OptionalLong instead of -1L

-------------

Changes:
  - all: https://git.openjdk.java.net/jtharness/pull/22/files
  - new: https://git.openjdk.java.net/jtharness/pull/22/files/b56f7172..c988435a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jtharness&pr=22&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jtharness&pr=22&range=00-01

  Stats: 32 lines in 3 files changed: 5 ins; 0 del; 27 mod
  Patch: https://git.openjdk.java.net/jtharness/pull/22.diff
  Fetch: git fetch https://git.openjdk.java.net/jtharness pull/22/head:pull/22

PR: https://git.openjdk.java.net/jtharness/pull/22

From cushon at openjdk.java.net  Tue Jan 25 22:40:09 2022
From: cushon at openjdk.java.net (Liam Miller-Cushon)
Date: Tue, 25 Jan 2022 22:40:09 GMT
Subject: RFR: 7902698: Collision of zero timestamp as a special value with
 use in filesystems
In-Reply-To: <VSWQ-3gxs9MX_WnzgrGCs7PEhCTpw3Q_nJdJ8XhmBU0=.22698bb4-f8dc-4b76-a338-3976d56c85a0@github.com>
References: <VSWQ-3gxs9MX_WnzgrGCs7PEhCTpw3Q_nJdJ8XhmBU0=.22698bb4-f8dc-4b76-a338-3976d56c85a0@github.com>
Message-ID: <TnHsXIc25LNM-oTXHMyqOAcVTzqwaH07kt__lil9zyo=.5e441bbe-b234-4066-8251-539244947f9c@github.com>

On Thu, 20 Jan 2022 03:27:00 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

> This fixes a bug when the timestamp of a test file is set to zero, since jtharness currently uses zero as a special value. See discussion in [CODETOOLS-7902698](https://bugs.openjdk.java.net/browse/CODETOOLS-7902698).

Thanks for the review!

> It possibly would be more reliable and readable to switch types of these fields from 'long' to OptionalLong with OptionalLong.empty() as their default value.

Done

-------------

PR: https://git.openjdk.java.net/jtharness/pull/22

From duke at openjdk.java.net  Wed Jan 26 17:49:45 2022
From: duke at openjdk.java.net (gollayadav)
Date: Wed, 26 Jan 2022 17:49:45 GMT
Subject: Integrated: 7903076: Feature Tests - Adding five JavaTest GUI legacy
 automated feature test scripts
In-Reply-To: <GkbruNXGgyVtFW7liizpVV3m0tiv7Z-cqJqMcXlo5Fg=.330f8e77-c7dc-47ed-8a91-35c0e454c98c@github.com>
References: <GkbruNXGgyVtFW7liizpVV3m0tiv7Z-cqJqMcXlo5Fg=.330f8e77-c7dc-47ed-8a91-35c0e454c98c@github.com>
Message-ID: <ds7UMuVW4QrPKA_d9NVRRxrlCgryBHAcWjl5Fmja_co=.cf156637-528b-4405-aac6-b03b05c58421@github.com>

On Mon, 10 Jan 2022 19:56:52 GMT, gollayadav <duke at openjdk.java.net> wrote:

> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.
> 
> 1.Browse5.java
> 2.Browse8.java
> 3.Config_Edit3.java
> 4.Config_Edit4.java
> 5.Config_Edit5.java

This pull request has now been integrated.

Changeset: 3d72bd18
Author:    gollayadav <83762358+gollayadav at users.noreply.github.com>
Committer: Dmitry Bessonov <dbessono at openjdk.org>
URL:       https://git.openjdk.java.net/jtharness/commit/3d72bd18ab76c9f0ca32299221cc17ef41e4652d
Stats:     437 lines in 9 files changed: 424 ins; 3 del; 10 mod

7903076: Feature Tests - Adding five JavaTest GUI legacy automated feature test scripts

Reviewed-by: dbessono

-------------

PR: https://git.openjdk.java.net/jtharness/pull/21

From duke at openjdk.java.net  Wed Jan 26 18:16:40 2022
From: duke at openjdk.java.net (gollayadav)
Date: Wed, 26 Jan 2022 18:16:40 GMT
Subject: Integrated: 7903079: Feature Tests - Adding six JavaTest GUI legacy
 automated test scripts
In-Reply-To: <ozrUX_nRSVKQVxn1wJT5HAroq4484SjhVHRigf0kA-A=.0314baee-f0e8-4e88-8753-fd44027c817c@github.com>
References: <ozrUX_nRSVKQVxn1wJT5HAroq4484SjhVHRigf0kA-A=.0314baee-f0e8-4e88-8753-fd44027c817c@github.com>
Message-ID: <qH_mr5bU3YRVhR-pGbQ3g19jpkmRHJLrxXoQejo5TX4=.e6992b76-f2d1-42ae-a05a-62c827fcc254@github.com>

On Wed, 22 Dec 2021 08:17:37 GMT, gollayadav <duke at openjdk.java.net> wrote:

> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine.
> 
> 1. Config_Edit6
> 2. Config_Edit7
> 3. Config_Load1
> 4. Config_Load2
> 5. Config_Load3
> 6. Config_Load4

This pull request has now been integrated.

Changeset: 586965ee
Author:    gollayadav <83762358+gollayadav at users.noreply.github.com>
Committer: Dmitry Bessonov <dbessono at openjdk.org>
URL:       https://git.openjdk.java.net/jtharness/commit/586965ee11de10f89936332da3ce25221f893d28
Stats:     526 lines in 7 files changed: 526 ins; 0 del; 0 mod

7903079: Feature Tests - Adding six JavaTest GUI legacy automated test scripts

Reviewed-by: dbessono

-------------

PR: https://git.openjdk.java.net/jtharness/pull/20