RFR: 7903374: Feature Tests - Adding six JavaTest GUI legacy automated test scripts [v3]

[gollayadav]

On Tue, 8 Nov 2022 23:43:07 GMT, Dmitry Bessonov <dbessono at openjdk.org> wrote:

>>> @gollayadav cannot see the answer to the quesiton or any explaination or updates
>> 
>> Sorry for missing this question!!!
>> 
>> 'Markers.java' inherited 'ConfigTools.java' because it has the generic methods(For example: 'openLoadConfigDialogByMenu' - This method is used to load the configuration(.jti) file) related to javatest configuration editor and these methods are called directly from the Markers test scripts because the 'Markers' functionality/option depends on configuration editor menu.
>> 
>> Also, these generic methods in ConfigTools.java are used in other test scripts as well (Example: CreateWorkdir) and invoked by using the class name.
>
> The question is specifically about having these methods of class Markers _static_. If they are kept static then static imports could be used instead inheritance. Or if they are supposed to be used as inherited methods then they should be made non-static.

Thanks again for your review comments.

Yes, this can be done and I have used the static imports in the test scripts. Changes are available now and the build is also successful. Could you please check it once?

-------------

PR: https://git.openjdk.org/jtharness/pull/41