RFR: crashonly extension for jtharness - for fastdebug testing [v5]

Dmitry Bessonov dbessono at openjdk.org
Wed Aug 30 16:23:25 UTC 2023


On Wed, 30 Aug 2023 15:29:33 GMT, Dmitry Bessonov <dbessono at openjdk.org> wrote:

>> andrlos has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   storing crash file object rather than its contents in the crash object
>
> An extension performing additional test results filtering basing on the presence of very specific supplementary files and their names ("hs_err_pid" etc.) should be better kept as a custom extension to the basic JT functionality, probably on top of or/and extending or augmenting jtreg for such needs.

> @dbessono so basically what you are saying is that nothing like this will be allowed into the jtharness by you even if I dont touch the core classes

We should keep a balance between generic functionality residing in the basic default implementations, and various extensions. It might be even OK to have such extension as part of the JTHarness codebase, but that depends on how everything is organized and layered.

-------------

PR Comment: https://git.openjdk.org/jtharness/pull/49#issuecomment-1699483229


More information about the jtharness-dev mailing list