RFR: 7903519 : jtreg/jtharness is missing features for basic crash testing

[andrlos]

On Wed, 13 Dec 2023 10:06:10 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> this does not exactly add a crash testing option, however it allows users to define their own resultModifiers that they can force jtharness to use via advertising their resultModifier service in META-INF. I tested it with basic crashOnlyModificator and it works as intended - allows me to correctly skip and pass all the regular failures and only leaves me with crash tests as failures. Perfect for corner cases like JVM testing and such.
>> Also checked correct behavior in the logs, where the regular failure is still being reported and only the justification of the result modification is added at the bottom.
>
> src/com/sun/javatest/Script.java line 496:
> 
>> 494:             searchResultModifier();
>> 495:         }
>> 496:         return resultModifier.modifyStatus(proposedStatus, td);
> 
> maybe if a foreign code changed status result,  the FQN of class should be logged.

but.. shouldnt user know this already, since he would be the one to put the foreign implementation there? I would leave it up to user to notify himself in the status line that the result has been modified.. alternative would be to check the status after calling "tryModifyResult" and if its not the same status, appending String saying that the Status has been modified by external code.. :shrug:

-------------

PR Review Comment: https://git.openjdk.org/jtharness/pull/57#discussion_r1425142653