RFR: 7903519 : jtreg/jtharness is missing features for basic crash testing
andrlos
duke at openjdk.org
Wed Dec 13 11:26:57 UTC 2023
On Wed, 13 Dec 2023 10:32:03 GMT, andrlos <duke at openjdk.org> wrote:
>> src/com/sun/javatest/Script.java line 492:
>>
>>> 490: * @return status after modification (the proposedStatus by default)
>>> 491: */
>>> 492: private Status tryModifyResult(Status proposedStatus, TestDescription td){
>>
>> this method should be synchronized, or the `resultModifier` should be safely instantiated singleton. I would prefer the second. It would be good to die in initial stage, not late in runtime
>
> I prefer the method to be synchronized to be honest. I am not seeing how to keep the change this simple with mixing singleton in it..
"private synchronized void searchResultModifier()" should do it, shouldnt it? this function is only called once per Script instance which I assume is once per run.
-------------
PR Review Comment: https://git.openjdk.org/jtharness/pull/57#discussion_r1425218168
More information about the jtharness-dev
mailing list