RFR: 7903519 : jtreg/jtharness is missing features for basic crash testing
andrlos
duke at openjdk.org
Wed Dec 13 20:50:58 UTC 2023
On Wed, 13 Dec 2023 12:01:37 GMT, Vladimir Sitnikov <vsitnikov at openjdk.org> wrote:
>> this does not exactly add a crash testing option, however it allows users to define their own resultModifiers that they can force jtharness to use via advertising their resultModifier service in META-INF. I tested it with basic crashOnlyModificator and it works as intended - allows me to correctly skip and pass all the regular failures and only leaves me with crash tests as failures. Perfect for corner cases like JVM testing and such.
>> Also checked correct behavior in the logs, where the regular failure is still being reported and only the justification of the result modification is added at the bottom.
>
> src/com/sun/javatest/exec/ResultModifierInterface.java line 37:
>
>> 35: * crashed in the process without being intended to.
>> 36: */
>> 37: public interface ResultModifierInterface {
>
> Suggestion:
>
> public interface ResultModifier {
>
>
> Should it be just `ResultModifier` rather than `ResultModifierInterface`?
I am under impression that naming interface with suffix "Interface" is kinda a good practice..
-------------
PR Review Comment: https://git.openjdk.org/jtharness/pull/57#discussion_r1425869185
More information about the jtharness-dev
mailing list