RFR: 7903519 : jtreg/jtharness is missing features for basic crash testing
andrlos
duke at openjdk.org
Wed Dec 13 20:55:00 UTC 2023
On Wed, 13 Dec 2023 13:23:22 GMT, Vladimir Sitnikov <vsitnikov at openjdk.org> wrote:
>> IIRC, the `originalStatus` on input is necessary, because the original idea @andrlos had, that it was changing only failed tests.
>> Otherwise I agree with your comments. ty!
>
> The implementation can access the original status with `result.getStatus()`.
>
> In other words, the framework should populate the result as usual with `result.setStatus(execStatus)`, and then it could call `resultModifier.modifyResult(result)`
and if you are thinking about it @vlsi - The status is unmodifiable by design. I still stand by my implementation as a concept and believe it is pretty elegant.. I shall address judovana's remarks and improve naming a bit as I know that is not something that is particularly clear
-------------
PR Review Comment: https://git.openjdk.org/jtharness/pull/57#discussion_r1425872113
More information about the jtharness-dev
mailing list