RFR: 7903519 : jtreg/jtharness is missing features for basic crash testing [v4]
Vladimir Sitnikov
vsitnikov at openjdk.org
Thu Dec 14 04:26:55 UTC 2023
On Wed, 13 Dec 2023 21:17:10 GMT, andrlos <duke at openjdk.org> wrote:
>> this does not exactly add a crash testing option, however it allows users to define their own resultModifiers that they can force jtharness to use via advertising their resultModifier service in META-INF. I tested it with basic crashOnlyModificator and it works as intended - allows me to correctly skip and pass all the regular failures and only leaves me with crash tests as failures. Perfect for corner cases like JVM testing and such.
>> Also checked correct behavior in the logs, where the regular failure is still being reported and only the justification of the result modification is added at the bottom.
>
> andrlos has updated the pull request incrementally with one additional commit since the last revision:
>
> improvement to the naming scheme 2
src/com/sun/javatest/Script.java line 493:
> 491: */
> 492: private Status tryModifyStatus(Status originalStatus, TestDescription td){
> 493: if (statusModifier == null) {
`statusModifier` is not `volatile`, so reading the field without synchronization is unsafe
-------------
PR Review Comment: https://git.openjdk.org/jtharness/pull/57#discussion_r1426158105
More information about the jtharness-dev
mailing list