RFR: 7903519 : jtreg/jtharness is missing features for basic crash testing [v4]
andrlos
duke at openjdk.org
Thu Dec 14 08:12:10 UTC 2023
On Thu, 14 Dec 2023 04:12:33 GMT, Vladimir Sitnikov <vsitnikov at openjdk.org> wrote:
>> and if you are thinking about it @vlsi - The status is unmodifiable by design. I still stand by my implementation as a concept and believe it is pretty elegant.. I shall address judovana's remarks and improve naming a bit as I know that is not something that is particularly clear
>
> if the status is unmodifiable, then `TestResultTransformer` with method `TestResult transform(TestResult)` would be better as it would cover more cases rather than changing status alone
but TestResult is also unmodifiable once you set the status.. you would need to create a whole new TestResult and then link it and somehow chirurgically remove the old TestResult to not get a conflict.. and we dont need to cover more cases.. what would we even try to transform other than the status? We want to retain all the logs the test execution produced as I see no added value in modifying those. Giving user too much power can be dangerous.
-------------
PR Review Comment: https://git.openjdk.org/jtharness/pull/57#discussion_r1426371454
More information about the jtharness-dev
mailing list