RFR: 7903519 : jtreg/jtharness is missing features for basic crash testing [v4]
andrlos
duke at openjdk.org
Thu Dec 14 08:15:59 UTC 2023
On Thu, 14 Dec 2023 04:23:58 GMT, Vladimir Sitnikov <vsitnikov at openjdk.org> wrote:
>> andrlos has updated the pull request incrementally with one additional commit since the last revision:
>>
>> improvement to the naming scheme 2
>
> src/com/sun/javatest/Script.java line 493:
>
>> 491: */
>> 492: private Status tryModifyStatus(Status originalStatus, TestDescription td){
>> 493: if (statusModifier == null) {
>
> `statusModifier` is not `volatile`, so reading the field without synchronization is unsafe
would adding a `volatile` keyword to the atribute be sufficient? I am hesitant to make the tagged method synchronized as that would potentially create a bottleneck
-------------
PR Review Comment: https://git.openjdk.org/jtharness/pull/57#discussion_r1426378471
More information about the jtharness-dev
mailing list