RFR: 7903519 : jtreg/jtharness is missing features for basic crash testing [v5]

Vladimir Sitnikov vsitnikov at openjdk.org
Thu Dec 14 14:06:10 UTC 2023


On Thu, 14 Dec 2023 13:55:17 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> I like the idea of chained transformers.  The only issue indeed is order. Our usecase is jsut one of the many.  And chaining gives interesting posibilitues.
>> 
>> Maybe the interface can have `int getOrder` method and implements comparable with default method comparing by this, so order would be deterministc, and mainly - in user's hand? 
>> 
>> in addition it will solve the issue with default impl x null check. The transfomers would be simply list, and if empty, none will be applied.
>
> my trust to cp/mp order is a bit limited :) But may be much better then my artifical getOrder with sort

Frankly, `getOrder` could probably be added later if needed (it could be added as a default implementation returning 0 or something).

So I agree `getOrder` might be helpful if exact ordering will be needed in the future, however, I guess we could skip adding `getOrder` this time and rely on `ServiceLoader` order

-------------

PR Review Comment: https://git.openjdk.org/jtharness/pull/57#discussion_r1426757647


More information about the jtharness-dev mailing list