RFR: 7903519 : jtreg/jtharness is missing features for basic crash testing [v7]
Vladimir Sitnikov
vsitnikov at openjdk.org
Thu Dec 14 14:23:02 UTC 2023
On Thu, 14 Dec 2023 14:11:43 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:
> I'm partially surprised that you seems to ok to include this change to jtharness
Frankly, I am still a bit skeptical, however, the new naming of `StatusTransformer + transform` sounds more-or-less good, and it seems to be the least evil when compared with fully replacing `TestResult` within `Script`.
The suggested PR does not add much maintenance overhead, however, it would probably make sense to add at least one test for it. @andrlos , have you considered adding a test for the feature? Frankly, I have no idea if it would be easy or hard to add a test (I've no idea how tests for jtharness are created), however, it would be great to have one.
Frankly, from a test framework user's point of view, I would prefer something like `TestResult transform(TestResult)` or `testResult.withStatus(newStatus) -> producing new TestResult` or `TestResult.setStatus(newStatus)`.
However, the latter suggestions might require significant rework of jtreg. Of course, I am nowhere near to asking for such changes.
----
> Now I'm curious, do you think jtreg project could harbour some implementations of this interface
I am not sure. I know what jtreg is, however, I virtually do not use it, so I can't tell.
-------------
PR Comment: https://git.openjdk.org/jtharness/pull/57#issuecomment-1855939144
More information about the jtharness-dev
mailing list