RFR: crashonly extension for jtharness - for fastdebug testing [v5]

andrlos duke at openjdk.org
Mon Sep 4 14:11:54 UTC 2023


On Wed, 30 Aug 2023 16:20:19 GMT, Dmitry Bessonov <dbessono at openjdk.org> wrote:

>> An extension performing additional test results filtering basing on the presence of very specific supplementary files and their names ("hs_err_pid" etc.) should be better kept as a custom extension to the basic JT functionality, probably on top of or/and extending or augmenting jtreg for such needs.
>
>> @dbessono so basically what you are saying is that nothing like this will be allowed into the jtharness by you even if I dont touch the core classes
> 
> We should keep a balance between generic functionality residing in the basic default implementations, and various extensions. It might be even OK to have such extension as part of the JTHarness codebase, but that depends on how everything is organized and layered.

@dbessono, I created a clone of current master and melded a new approach of doing this into it, it can be seen in this PR into my fork (did not want to create hundreds of PRs here) please take a look if this would be acceptable.. I had to touch the core classes a little bit to separate some mechanics that would otherwise force me to copypaste really huge methods.. https://github.com/andrlos/jtharness/pull/1 Thanks for taking a look :-)

-------------

PR Comment: https://git.openjdk.org/jtharness/pull/49#issuecomment-1705337154


More information about the jtharness-dev mailing list