RFR: 7900303: auto updating components need accessbility control [v2]

[Alexandre Iline]

On Fri, 30 Aug 2024 09:06:42 GMT, Dmitry Bessonov <dbessono at openjdk.org> wrote:

>> The auto-updating component that can be improved in JTHarness UI in terms of accessibility is test run progress bar.
>> 
>> Such progress bars are visible on the main desktop and in test run monitor window.
>> 
>> We should provide a mechanism for the user to hide test run progress bars.
>> 
>> ### Default state
>> 
>> ![Screenshot 2024-08-30 at 09 47 36](https://github.com/user-attachments/assets/6cfcac77-a471-4d40-aeab-e6bd43cc6469)
>> 
>> ![Screenshot 2024-08-30 at 09 40 22](https://github.com/user-attachments/assets/c88eceec-ab04-48e6-928f-da67d08938f3)
>> 
>> Visually unchanged comparing to what we have now, without the patch.
>> 
>> ### Started with `-Djavatest.desktop.testrunprogressmonitor.hidden=true`
>> 
>> ![Screenshot 2024-08-30 at 09 48 01](https://github.com/user-attachments/assets/4552e637-61b2-43a5-80bb-73ef97b34226)
>> 
>> ![Screenshot 2024-08-30 at 09 46 43](https://github.com/user-attachments/assets/5d6a5bf1-cda1-4cca-943a-c68a91f7049c)
>
> Dmitry Bessonov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   CRN second year update

LGTM

src/com/sun/javatest/exec/ProgressMonitor.java line 382:

> 380: 
> 381:             boolean showTestRunProgressMonitor =
> 382:                     !Boolean.valueOf(System.getProperty("javatest.desktop.testrunprogressmonitor.hidden"));

AFAICS in the JavaTest code the property names sometimes are stored in string constants and sometimes are hardcoded in the sources. I can not tell which way is preferred, so just making a comment that optionally a string constant can be used for the property name.

-------------

PR Comment: https://git.openjdk.org/jtharness/pull/82#issuecomment-2322118738
PR Review Comment: https://git.openjdk.org/jtharness/pull/82#discussion_r1739236474