RFR: exracting method to fill in result status to allow for overriding in implementations of Script

Dmitry Bessonov dbessono at openjdk.org
Mon Feb 26 12:18:03 UTC 2024


On Thu, 18 Jan 2024 13:51:47 GMT, andrlos <duke at openjdk.org> wrote:

>>> well I would vote the "modify" based names out, since by default this wont be changing anything..
>> 
>> but htat is the reason of the method, isnt it?
>
> well the method just fills the Status attribute, but the reason to have this method extracted is the possibility to modify it.. but then every method that is overriteable would have to be a modify method according to that logic

Agree, `setTestResultStatus` looks more simple and clear, taking into account the default implementation especially ...

-------------

PR Review Comment: https://git.openjdk.org/jtharness/pull/59#discussion_r1502520107


More information about the jtharness-dev mailing list