RFR: exracting method to fill in result status to allow for overriding in implementations of Script

andrlos duke at openjdk.org
Wed Jan 10 14:01:45 UTC 2024


On Wed, 10 Jan 2024 13:58:19 GMT, andrlos <duke at openjdk.org> wrote:

>> src/com/sun/javatest/Script.java line 487:
>> 
>>> 485:      * @param execStatus Status object to fill into the testResultToFill
>>> 486:      */
>>> 487:     protected void fillTestExecutionStatus(TestResult testResultToFill, Status execStatus) {
>> 
>> I would  suggest `setTestResultStatus` or `modifyTestResultStatus`, as we are dealing with testResult variable ; or `setTestRunStatus` or `modifyTestRuntStatus` as we are called in `run`. But you know better, just ideas from point of view what I would be searching in autocompletion (fill is unlikely, execution more likely, still  rare)
>
> well I would vote the "modify" based names out, since by default this wont be changing anything..

I went with the naming kindly provided by @dbessono but I am happy to change it however we agree.

-------------

PR Review Comment: https://git.openjdk.org/jtharness/pull/59#discussion_r1447423892


More information about the jtharness-dev mailing list