RFR: exracting method to fill in result status to allow for overriding in implementations of Script

andrlos duke at openjdk.org
Thu Jan 18 13:54:33 UTC 2024


On Thu, 11 Jan 2024 08:35:42 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> I went with the naming kindly provided by @dbessono but I am happy to change it however we agree.
>
>> well I would vote the "modify" based names out, since by default this wont be changing anything..
> 
> but htat is the reason of the method, isnt it?

well the method just fills the Status attribute, but the reason to have this method extracted is the possibility to modify it.. but then every method that is overriteable would have to be a modify method according to that logic

-------------

PR Review Comment: https://git.openjdk.org/jtharness/pull/59#discussion_r1457471711


More information about the jtharness-dev mailing list