RFR: 7903714: Feature Tests - Adding five JavaTest GUI legacy automated test scripts [v2]
gollayadav
duke at openjdk.org
Fri Jun 14 12:50:36 UTC 2024
On Thu, 13 Jun 2024 11:30:32 GMT, Dmitry Bessonov <dbessono at openjdk.org> wrote:
>> gollayadav has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update CreateWorkdir08.java
>
> gui-tests/src/gui/src/jthtest/CreateWorkdir/CreateWorkdir08.java line 69:
>
>> 67: if (!((templatePath.getText() + File.separator).equals(DEFAULT_PATH)))
>> 68: throw new JemmyException("Default template path doesn't match default path: " + templatePath.getText()
>> 69: + File.separator + " != " + DEFAULT_PATH);
>
> Please wrap both throwing in `{...}`
@dbessono Thank You for your time in reviewing the test scripts.
Updated the test scripts as suggested.
> Looks like excessive `( ... )` used
@dbessono Thank You for your time in reviewing the test scripts.
Updated the test scripts as suggested.
-------------
PR Review Comment: https://git.openjdk.org/jtharness/pull/69#discussion_r1639770665
PR Review Comment: https://git.openjdk.org/jtharness/pull/69#discussion_r1639771160
More information about the jtharness-dev
mailing list