From duke at openjdk.org  Wed Mar  6 03:01:58 2024
From: duke at openjdk.org (duke)
Date: Wed, 6 Mar 2024 03:01:58 GMT
Subject: Withdrawn: 7903519 : jtreg/jtharness is missing features for basic
 crash testing
In-Reply-To: <EIBxVS6dckwbyYS7S2RMPCpYIBWx0iQZ0jABmS7hkQk=.e82fbc9d-8624-4a9e-9b21-02a905281b30@github.com>
References: <EIBxVS6dckwbyYS7S2RMPCpYIBWx0iQZ0jABmS7hkQk=.e82fbc9d-8624-4a9e-9b21-02a905281b30@github.com>
Message-ID: <4ExLzGPJn9mlOm9NbTfbJGpjmO_1atcjE6l9cHnxPeI=.244bb977-0f58-4d91-bbfa-c64c274cf5a2@github.com>

On Tue, 12 Dec 2023 23:22:34 GMT, andrlos <duke at openjdk.org> wrote:

> this does not exactly add a crash testing option, however it allows users to define their own resultModifiers that they can force jtharness to use via advertising their resultModifier service in META-INF. I tested it with basic crashOnlyModificator and it works as intended - allows me to correctly skip and pass all the regular failures and only leaves me with crash tests as failures. Perfect for corner cases like JVM testing and such.
> Also checked correct behavior in the logs, where the regular failure is still being reported and only the justification of the result modification is added at the bottom.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jtharness/pull/57

From duke at openjdk.org  Wed Mar  6 08:17:59 2024
From: duke at openjdk.org (gollayadav)
Date: Wed, 6 Mar 2024 08:17:59 GMT
Subject: RFR: 7903571: Feature Tests - Modified/Updated the ReportCreate.java
 and Tools.java
Message-ID: <4LOTi4CQQb6pDGsree8kuBzq-KijHzis-2RO9we1Dnc=.dca64e55-90bb-4a31-be73-5c5d71fe135a@github.com>

Modified/Updated the below two files as per the latest JT:
I. ReportCreate/ReportCreate.java
II. jthtest/Tools.java

I - Reason for modifying - "ReportCreate/ReportCreate.java":-

1. Special characters/extra space are getting appended while fetching the text from latest JavaTest html report creation page using "browser.getText()".
For example: '#'  is appended to "Configuration and Other Settings" text. To remove the special characters modified the above line.

2. HTML attribute names/values are changed in JavaTest report creation page.
For example: "name="locations"" is changed to "id="locations"".

3. Removed these lines as per CODETOOLS-6480602

II - Reason for modifying - "jthtest/Tools.java":-
1. Special characters/extra space are getting appended while fetching the text from javatest html report creation page using "browser.getText()". To remove the special characters modified the above line.


I have ran all the integrated tests with the above changes and no regression issues found. All tests are passed.

-------------

Commit messages:
 - 7903571: Feature Tests - Modified/Updated the ReportCreate.java and Tools.java

Changes: https://git.openjdk.org/jtharness/pull/60/files
 Webrev: https://webrevs.openjdk.org/?repo=jtharness&pr=60&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903571
  Stats: 12 lines in 2 files changed: 0 ins; 5 del; 7 mod
  Patch: https://git.openjdk.org/jtharness/pull/60.diff
  Fetch: git fetch https://git.openjdk.org/jtharness.git pull/60/head:pull/60

PR: https://git.openjdk.org/jtharness/pull/60

From dbessono at openjdk.org  Mon Mar 11 20:15:19 2024
From: dbessono at openjdk.org (Dmitry Bessonov)
Date: Mon, 11 Mar 2024 20:15:19 GMT
Subject: RFR: 7903571: Feature Tests - Modified/Updated the
 'ReportCreate.java' and 'Tools.java''
In-Reply-To: <4LOTi4CQQb6pDGsree8kuBzq-KijHzis-2RO9we1Dnc=.dca64e55-90bb-4a31-be73-5c5d71fe135a@github.com>
References: <4LOTi4CQQb6pDGsree8kuBzq-KijHzis-2RO9we1Dnc=.dca64e55-90bb-4a31-be73-5c5d71fe135a@github.com>
Message-ID: <dVHudJLNhh8opNvRYS_yqoOQthO72_i48ASeIbGeoO4=.f4d0b801-31a4-424e-9022-15a5f4334b14@github.com>

On Wed, 6 Mar 2024 08:11:09 GMT, gollayadav <duke at openjdk.org> wrote:

> Modified/Updated the below two files as per the latest JT:
> I. ReportCreate/ReportCreate.java
> II. jthtest/Tools.java
> 
> Due to format issues I have mentioned reasons for Modifying/Updating and details of the scripts in JBS linked.

Marked as reviewed by dbessono (Reviewer).

-------------

PR Review: https://git.openjdk.org/jtharness/pull/60#pullrequestreview-1929119132

From duke at openjdk.org  Tue Mar 12 15:34:21 2024
From: duke at openjdk.org (gollayadav)
Date: Tue, 12 Mar 2024 15:34:21 GMT
Subject: RFR: 7903571: Feature Tests - Modified/Updated the
 'ReportCreate.java' and 'Tools.java''
In-Reply-To: <dVHudJLNhh8opNvRYS_yqoOQthO72_i48ASeIbGeoO4=.f4d0b801-31a4-424e-9022-15a5f4334b14@github.com>
References: <4LOTi4CQQb6pDGsree8kuBzq-KijHzis-2RO9we1Dnc=.dca64e55-90bb-4a31-be73-5c5d71fe135a@github.com>
 <dVHudJLNhh8opNvRYS_yqoOQthO72_i48ASeIbGeoO4=.f4d0b801-31a4-424e-9022-15a5f4334b14@github.com>
Message-ID: <I8fKzJnp2i4QY2IFv1IZ0rUiLblGG_ZOHRB_Imp2ZcU=.49fbf58f-e9ee-4489-a4c6-6d5b764384cc@github.com>

On Mon, 11 Mar 2024 20:13:08 GMT, Dmitry Bessonov <dbessono at openjdk.org> wrote:

>> Modified/Updated the below two files as per the latest JT:
>> I. ReportCreate/ReportCreate.java
>> II. jthtest/Tools.java
>> 
>> Due to format issues I have mentioned reasons for Modifying/Updating and details of the scripts in JBS linked.
>
> Marked as reviewed by dbessono (Reviewer).

@dbessono Thank you for your time in reviewing the scripts.

-------------

PR Comment: https://git.openjdk.org/jtharness/pull/60#issuecomment-1991928963

From duke at openjdk.org  Tue Mar 12 18:13:21 2024
From: duke at openjdk.org (gollayadav)
Date: Tue, 12 Mar 2024 18:13:21 GMT
Subject: Integrated: 7903571: Feature Tests - Modified/Updated the
 'ReportCreate.java' and 'Tools.java''
In-Reply-To: <4LOTi4CQQb6pDGsree8kuBzq-KijHzis-2RO9we1Dnc=.dca64e55-90bb-4a31-be73-5c5d71fe135a@github.com>
References: <4LOTi4CQQb6pDGsree8kuBzq-KijHzis-2RO9we1Dnc=.dca64e55-90bb-4a31-be73-5c5d71fe135a@github.com>
Message-ID: <5Go4n481fOnZdZD6HcYZQi-lDJrf5hsY3BdBsoQXF2o=.5c7b8dfb-9d60-4958-af24-d7a559c742eb@github.com>

On Wed, 6 Mar 2024 08:11:09 GMT, gollayadav <duke at openjdk.org> wrote:

> Modified/Updated the below two files as per the latest JT:
> I. ReportCreate/ReportCreate.java
> II. jthtest/Tools.java
> 
> Due to format issues I have mentioned reasons for Modifying/Updating and details of the scripts in JBS linked.

This pull request has now been integrated.

Changeset: 78b39437
Author:    golla.yadav at oracle.com <gryadav at saturn.s3.javaplatfo1phx.oraclevcn.com>
Committer: Dmitry Bessonov <dbessono at openjdk.org>
URL:       https://git.openjdk.org/jtharness/commit/78b39437f5c542e7bde6176eaa531a0160c05c84
Stats:     12 lines in 2 files changed: 0 ins; 5 del; 7 mod

7903571: Feature Tests - Modified/Updated the 'ReportCreate.java' and 'Tools.java''

Reviewed-by: dbessono

-------------

PR: https://git.openjdk.org/jtharness/pull/60

From duke at openjdk.org  Wed Mar 13 15:17:47 2024
From: duke at openjdk.org (gollayadav)
Date: Wed, 13 Mar 2024 15:17:47 GMT
Subject: RFR: 7903688: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts
Message-ID: <P9aodQGuKl_vJd8P2-PFx5J6npKCiuWgxiUJAWlu80I=.389c86c4-6bd1-42a7-a348-e3b672d527e4@github.com>

Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine. Also verified with JDK8 on macos.

1. Markers13.java
2. Markers21.java
3. ReportCreate11.java
4. ReportCreate13.java
5. ReportCreate14.java

-------------

Commit messages:
 - 7903688 - Remove whitespace error - ReportCreate14.java
 - 7903688: Remove whitespace error - ReportCreate13.java
 - 7903688- Remove whitespace error - ReportCreate11.java
 - 7903688: remove whitespace error - Markers21.java
 - 7903688: Corrected carriage return and whitespace errors
 - 7903688: remove whitespace error
 - 7903688: remove carriage return
 - 7903688: Feature Tests - Corrected the white space erros
 - 7903688: Feature Tests - Corrected white space errors
 - 7903688: Feature Tests - Adding five JavaTest GUI legacy automated test scripts

Changes: https://git.openjdk.org/jtharness/pull/61/files
  Webrev: https://webrevs.openjdk.org/?repo=jtharness&pr=61&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903688
  Stats: 325 lines in 5 files changed: 325 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jtharness/pull/61.diff
  Fetch: git fetch https://git.openjdk.org/jtharness.git pull/61/head:pull/61

PR: https://git.openjdk.org/jtharness/pull/61

From duke at openjdk.org  Wed Mar 20 14:14:46 2024
From: duke at openjdk.org (gollayadav)
Date: Wed, 20 Mar 2024 14:14:46 GMT
Subject: RFR: 7903698: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts
Message-ID: <pToec3iCkdQinqp7dg9nadpXstfQNqhPEc5wIyKIkmw=.7aaa9bea-ef22-4fd8-9738-a31e211d573a@github.com>

Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tests are passing locally.

1. ReportCreate.java
2. ReportCreate15.java
3. ReportCreate16.java
4. ReportCreate17.java
5. ReportCreate18.java
6. ReportCreate22.java

-------------

Commit messages:
 - 7903698: Feature Tests - Adding five JavaTest GUI legacy automated test scripts

Changes: https://git.openjdk.org/jtharness/pull/62/files
  Webrev: https://webrevs.openjdk.org/?repo=jtharness&pr=62&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903698
  Stats: 349 lines in 6 files changed: 347 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jtharness/pull/62.diff
  Fetch: git fetch https://git.openjdk.org/jtharness.git pull/62/head:pull/62

PR: https://git.openjdk.org/jtharness/pull/62

From dbessono at openjdk.org  Mon Mar 25 18:55:28 2024
From: dbessono at openjdk.org (Dmitry Bessonov)
Date: Mon, 25 Mar 2024 18:55:28 GMT
Subject: RFR: 7903688: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts
In-Reply-To: <P9aodQGuKl_vJd8P2-PFx5J6npKCiuWgxiUJAWlu80I=.389c86c4-6bd1-42a7-a348-e3b672d527e4@github.com>
References: <P9aodQGuKl_vJd8P2-PFx5J6npKCiuWgxiUJAWlu80I=.389c86c4-6bd1-42a7-a348-e3b672d527e4@github.com>
Message-ID: <7q2mD8N8RKShmdFJAAK8Yb5z8Lf9xa3m0RBdZpOJAxM=.e0f2d38d-b457-4f6f-bbba-67188d0d9b61@github.com>

On Wed, 13 Mar 2024 13:50:38 GMT, gollayadav <duke at openjdk.org> wrote:

> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine. Also verified with JDK8 on macos.
> 
> 1. Markers13.java
> 2. Markers21.java
> 3. ReportCreate11.java
> 4. ReportCreate13.java
> 5. ReportCreate14.java

Thank you for the tests, checked additionally - they pass for me on Linux.

-------------

Marked as reviewed by dbessono (Reviewer).

PR Review: https://git.openjdk.org/jtharness/pull/61#pullrequestreview-1958534548

From duke at openjdk.org  Tue Mar 26 05:12:27 2024
From: duke at openjdk.org (gollayadav)
Date: Tue, 26 Mar 2024 05:12:27 GMT
Subject: RFR: 7903688: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts
In-Reply-To: <7q2mD8N8RKShmdFJAAK8Yb5z8Lf9xa3m0RBdZpOJAxM=.e0f2d38d-b457-4f6f-bbba-67188d0d9b61@github.com>
References: <P9aodQGuKl_vJd8P2-PFx5J6npKCiuWgxiUJAWlu80I=.389c86c4-6bd1-42a7-a348-e3b672d527e4@github.com>
 <7q2mD8N8RKShmdFJAAK8Yb5z8Lf9xa3m0RBdZpOJAxM=.e0f2d38d-b457-4f6f-bbba-67188d0d9b61@github.com>
Message-ID: <RiRl4qumom8yaw3J4w_lMJNQ7D9uwa8ODy9vn-2DmTQ=.b624a0e7-fa90-4d8f-803b-02a56575db20@github.com>

On Mon, 25 Mar 2024 18:52:32 GMT, Dmitry Bessonov <dbessono at openjdk.org> wrote:

> Thank you for the tests, checked additionally - they pass for me on Linux.

Thanks for your time in reviewing the test scripts.

-------------

PR Comment: https://git.openjdk.org/jtharness/pull/61#issuecomment-2019402618

From duke at openjdk.org  Tue Mar 26 09:43:28 2024
From: duke at openjdk.org (gollayadav)
Date: Tue, 26 Mar 2024 09:43:28 GMT
Subject: Integrated: 7903688: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts
In-Reply-To: <P9aodQGuKl_vJd8P2-PFx5J6npKCiuWgxiUJAWlu80I=.389c86c4-6bd1-42a7-a348-e3b672d527e4@github.com>
References: <P9aodQGuKl_vJd8P2-PFx5J6npKCiuWgxiUJAWlu80I=.389c86c4-6bd1-42a7-a348-e3b672d527e4@github.com>
Message-ID: <D-lIvnLTHrvyVuvLjf2C7V2jn-EvKqfxHnpY8peBGU8=.5e4d2f97-a942-44cf-8f89-6847977fba26@github.com>

On Wed, 13 Mar 2024 13:50:38 GMT, gollayadav <duke at openjdk.org> wrote:

> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine. Also verified with JDK8 on macos.
> 
> 1. Markers13.java
> 2. Markers21.java
> 3. ReportCreate11.java
> 4. ReportCreate13.java
> 5. ReportCreate14.java

This pull request has now been integrated.

Changeset: cefdd453
Author:    golla.yadav at oracle.com <gryadav at saturn.s3.javaplatfo1phx.oraclevcn.com>
Committer: Dmitry Bessonov <dbessono at openjdk.org>
URL:       https://git.openjdk.org/jtharness/commit/cefdd45392c8269f7e8037613668f9b69ae6dd0a
Stats:     325 lines in 5 files changed: 325 ins; 0 del; 0 mod

7903688: Feature Tests - Adding five JavaTest GUI legacy automated test scripts

Reviewed-by: dbessono

-------------

PR: https://git.openjdk.org/jtharness/pull/61

From dbessono at openjdk.org  Tue Mar 26 09:55:29 2024
From: dbessono at openjdk.org (Dmitry Bessonov)
Date: Tue, 26 Mar 2024 09:55:29 GMT
Subject: RFR: 7903698: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts
In-Reply-To: <pToec3iCkdQinqp7dg9nadpXstfQNqhPEc5wIyKIkmw=.7aaa9bea-ef22-4fd8-9738-a31e211d573a@github.com>
References: <pToec3iCkdQinqp7dg9nadpXstfQNqhPEc5wIyKIkmw=.7aaa9bea-ef22-4fd8-9738-a31e211d573a@github.com>
Message-ID: <gEsBACIbTYjxI2aCaLzXc4mX5ZdG8l_-vqAWRntCwO4=.936f9032-ee0c-4de2-b650-98fb70edc8d3@github.com>

On Wed, 20 Mar 2024 14:10:58 GMT, gollayadav <duke at openjdk.org> wrote:

> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tests are passing locally.
> 
> 1. ReportCreate.java
> 2. ReportCreate15.java
> 3. ReportCreate16.java
> 4. ReportCreate17.java
> 5. ReportCreate18.java
> 6. ReportCreate22.java

Thank you for adding test coverage, looks good. New tests pass for me on Linux.

-------------

Marked as reviewed by dbessono (Reviewer).

PR Review: https://git.openjdk.org/jtharness/pull/62#pullrequestreview-1959864169

From duke at openjdk.org  Tue Mar 26 15:55:28 2024
From: duke at openjdk.org (gollayadav)
Date: Tue, 26 Mar 2024 15:55:28 GMT
Subject: RFR: 7903698: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts
In-Reply-To: <gEsBACIbTYjxI2aCaLzXc4mX5ZdG8l_-vqAWRntCwO4=.936f9032-ee0c-4de2-b650-98fb70edc8d3@github.com>
References: <pToec3iCkdQinqp7dg9nadpXstfQNqhPEc5wIyKIkmw=.7aaa9bea-ef22-4fd8-9738-a31e211d573a@github.com>
 <gEsBACIbTYjxI2aCaLzXc4mX5ZdG8l_-vqAWRntCwO4=.936f9032-ee0c-4de2-b650-98fb70edc8d3@github.com>
Message-ID: <L9HQG2JiEzGJUignNsHi5yi3Qilt7LhPOmDgkp23pEE=.8b6618a4-1985-4fe2-81a2-53e95c773403@github.com>

On Tue, 26 Mar 2024 09:52:41 GMT, Dmitry Bessonov <dbessono at openjdk.org> wrote:

> Thank you for adding test coverage, looks good. New tests pass for me on Linux.

Thank you @dbessono for your time in reviewing the test scripts.

-------------

PR Comment: https://git.openjdk.org/jtharness/pull/62#issuecomment-2020814573

From duke at openjdk.org  Tue Mar 26 16:01:36 2024
From: duke at openjdk.org (gollayadav)
Date: Tue, 26 Mar 2024 16:01:36 GMT
Subject: Integrated: 7903698: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts
In-Reply-To: <pToec3iCkdQinqp7dg9nadpXstfQNqhPEc5wIyKIkmw=.7aaa9bea-ef22-4fd8-9738-a31e211d573a@github.com>
References: <pToec3iCkdQinqp7dg9nadpXstfQNqhPEc5wIyKIkmw=.7aaa9bea-ef22-4fd8-9738-a31e211d573a@github.com>
Message-ID: <1dTP8R68YWzkGgRdVPnRXjuC_GaXMnIgfpKfS7L4etY=.04d7af8b-8044-4814-a596-1719a8d8c741@github.com>

On Wed, 20 Mar 2024 14:10:58 GMT, gollayadav <duke at openjdk.org> wrote:

> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tests are passing locally.
> 
> 1. ReportCreate.java
> 2. ReportCreate15.java
> 3. ReportCreate16.java
> 4. ReportCreate17.java
> 5. ReportCreate18.java
> 6. ReportCreate22.java

This pull request has now been integrated.

Changeset: c64febe1
Author:    golla.yadav at oracle.com <gryadav at saturn.s3.javaplatfo1phx.oraclevcn.com>
Committer: Dmitry Bessonov <dbessono at openjdk.org>
URL:       https://git.openjdk.org/jtharness/commit/c64febe1c21df5acb45e39c48f661ba4d4e2d297
Stats:     349 lines in 6 files changed: 347 ins; 0 del; 2 mod

7903698: Feature Tests - Adding five JavaTest GUI legacy automated test scripts

Reviewed-by: dbessono

-------------

PR: https://git.openjdk.org/jtharness/pull/62

From duke at openjdk.org  Tue Mar 26 16:52:41 2024
From: duke at openjdk.org (gollayadav)
Date: Tue, 26 Mar 2024 16:52:41 GMT
Subject: RFR: 7903700: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts
Message-ID: <7Z47gG5zRN0sU2I5LUD6VBO488GllAIYXMxKz4I_JYI=.9b5b93bb-f5c3-491a-8296-7eeb0060522c@github.com>

Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine. Also verified with JDK8 on macos.

1. Config_TestTree1.java
2. Config_TestTree2.java
3. Config_TestTree3.java
4. Config_Load7.java
5. new9.java

-------------

Commit messages:
 - 7903700: Feature Tests - Adding five JavaTest GUI legacy automated test scripts

Changes: https://git.openjdk.org/jtharness/pull/63/files
  Webrev: https://webrevs.openjdk.org/?repo=jtharness&pr=63&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903700
  Stats: 437 lines in 5 files changed: 437 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jtharness/pull/63.diff
  Fetch: git fetch https://git.openjdk.org/jtharness.git pull/63/head:pull/63

PR: https://git.openjdk.org/jtharness/pull/63

From duke at openjdk.org  Wed Mar 27 11:38:28 2024
From: duke at openjdk.org (duke)
Date: Wed, 27 Mar 2024 11:38:28 GMT
Subject: Withdrawn: exracting method to fill in result status to allow for
 overriding in implementations of Script
In-Reply-To: <_7VE7By5WXV8vLGU5WVYrFkwqrvuW9Ron8qtzOOWZTs=.8a7f9002-ad83-463e-8550-c1c8a09e3cea@github.com>
References: <_7VE7By5WXV8vLGU5WVYrFkwqrvuW9Ron8qtzOOWZTs=.8a7f9002-ad83-463e-8550-c1c8a09e3cea@github.com>
Message-ID: <JAyv-tIpfmNFjhMFUkuQHX2rBv8iEHtvGfwfXq7KhZE=.93d2a98f-f03b-41ef-b2c8-96fb2e151760@github.com>

On Tue, 9 Jan 2024 20:43:42 GMT, andrlos <duke at openjdk.org> wrote:

> This is an alternative approach to https://github.com/openjdk/jtharness/pull/57
> counting on Script subclasses that will allow for such modifications.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jtharness/pull/59

From duke at openjdk.org  Wed Mar 27 13:26:08 2024
From: duke at openjdk.org (gollayadav)
Date: Wed, 27 Mar 2024 13:26:08 GMT
Subject: RFR: Feature Tests - Adding five JavaTest GUI legacy automated test
 scripts
Message-ID: <RicKAzfJZ9ZmzusKtfDcOCf27T7XzJNfev0WcdDa_Ec=.602a7a23-6f82-405c-ae69-04b94a37a381@github.com>

Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine. Also verified with JDK8 on macos.

1. Menu01.java
2. Menu02.java
3. Menu03.java
4. Menu04.java
5. Menu05.java

-------------

Commit messages:
 - 7903701: Feature Tests - Adding five JavaTest GUI legacy automated test scripts
 - 7903700: Feature Tests - Adding five JavaTest GUI legacy automated test scripts

Changes: https://git.openjdk.org/jtharness/pull/64/files
  Webrev: https://webrevs.openjdk.org/?repo=jtharness&pr=64&range=00
  Stats: 1050 lines in 10 files changed: 1050 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jtharness/pull/64.diff
  Fetch: git fetch https://git.openjdk.org/jtharness.git pull/64/head:pull/64

PR: https://git.openjdk.org/jtharness/pull/64

From duke at openjdk.org  Wed Mar 27 13:29:29 2024
From: duke at openjdk.org (gollayadav)
Date: Wed, 27 Mar 2024 13:29:29 GMT
Subject: Withdrawn: 7903701: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts
In-Reply-To: <RicKAzfJZ9ZmzusKtfDcOCf27T7XzJNfev0WcdDa_Ec=.602a7a23-6f82-405c-ae69-04b94a37a381@github.com>
References: <RicKAzfJZ9ZmzusKtfDcOCf27T7XzJNfev0WcdDa_Ec=.602a7a23-6f82-405c-ae69-04b94a37a381@github.com>
Message-ID: <h0zd_paxquvFaPPlNo7b7f9q3uFJFyG7_Dbu6wVghIU=.179caa8e-61e2-4abe-901f-6d5d89a7beb5@github.com>

On Wed, 27 Mar 2024 13:22:24 GMT, gollayadav <duke at openjdk.org> wrote:

> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine. Also verified with JDK8 on macos.
> 
> 1. Menu01.java
> 2. Menu02.java
> 3. Menu03.java
> 4. Menu04.java
> 5. Menu05.java

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jtharness/pull/64

From duke at openjdk.org  Wed Mar 27 14:21:36 2024
From: duke at openjdk.org (gollayadav)
Date: Wed, 27 Mar 2024 14:21:36 GMT
Subject: RFR: 7903701: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts
Message-ID: <pOhWnqSp4KxtKFePHUjAcHwgyjExVjVH4DzJAdufnTI=.86aacd24-09ce-4d42-9351-881f05bf52f4@github.com>

Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine. Also verified with JDK8 on macos.

1. Menu01.java
2. Menu02.java
3. Menu03.java
4. Menu04.java
5. Menu05.java

-------------

Commit messages:
 - 7903701: Corrected white space errors
 - 7903701: Feature Tests - Adding five JavaTest GUI legacy automated test scripts

Changes: https://git.openjdk.org/jtharness/pull/65/files
  Webrev: https://webrevs.openjdk.org/?repo=jtharness&pr=65&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903701
  Stats: 613 lines in 5 files changed: 613 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jtharness/pull/65.diff
  Fetch: git fetch https://git.openjdk.org/jtharness.git pull/65/head:pull/65

PR: https://git.openjdk.org/jtharness/pull/65

From duke at openjdk.org  Thu Mar 28 07:51:38 2024
From: duke at openjdk.org (moritz-bruder)
Date: Thu, 28 Mar 2024 07:51:38 GMT
Subject: RFR: Use ThreadGroup for passive connection
In-Reply-To: <oQRcLRpmSmKqHlicPyEBXeq5DDdseTl5XBi3eWc4Lns=.4b2c295e-607c-4d5f-b4bb-a4402ec5161e@github.com>
References: <EmSRXyVVXbATWNjJ2ENZoaVruerkUXZwm0lDBYEz3L0=.a03bbb01-d325-4707-bdd6-105e09531b95@github.com>
 <eLwoCyeN0clTLywcB19dDYS-MYxIqZdPhYLRRIcogqA=.34580c77-51bc-4a6c-be70-35c1348c3192@github.com>
 <oQRcLRpmSmKqHlicPyEBXeq5DDdseTl5XBi3eWc4Lns=.4b2c295e-607c-4d5f-b4bb-a4402ec5161e@github.com>
Message-ID: <S0pnmgtYeaih3TyTVgqs9KF6_QsTs4jQPVU6aalI1go=.fefd50f3-5754-4a70-a014-0b7ca1c97462@github.com>

On Thu, 22 Feb 2024 12:13:15 GMT, moritz-bruder <duke at openjdk.org> wrote:

>> I do not have anything to add.  I am waiting for a review or a discussion.
>
>> @moritz-bruder could you please provide more details of the problem that is being solved by this enhancement, link to any JBS bug IDs etc.
> 
> On our side this is an issue that is composed of two other issues.
> * The remote class loader, in particular because it starts threads in the same `ThreadGroup`, causes an exception to be thrown during `loadClass`.  This is fixed by this patch without really affecting other VMs (one additional allocation in total).
> * Another issue is that whenever an exception is thrown during class loading, the code for sending and receiving is thrown out of sync.  So the next call to `loadClass` will read the class data of the old request.  Thus, `AgentClassLoader` is not exception-safe.  This issue is not fixed with this patch.  It could be solved by doing some kind of rollback but it was too much effort.

> > > @moritz-bruder could you please provide more details of the problem that is being solved by this enhancement, link to any JBS bug IDs etc.
> > 
> > 
> > On our side this is an issue that is composed of two other issues.
> > ```
> > * The remote class loader, in particular because it starts threads in the same `ThreadGroup`, causes an exception to be thrown during `loadClass`.  This is fixed by this patch without really affecting other VMs (one additional allocation in total).
> > 
> > * Another issue is that whenever an exception is thrown during class loading, the code for sending and receiving is thrown out of sync.  So the next call to `loadClass` will read the class data of the old request.  Thus, `AgentClassLoader` is not exception-safe.  This issue is not fixed with this patch.  It could be solved by doing some kind of rollback but it was too much effort.
> > ```
> 
> Thank you, more background info would be appreciated - are the issues happening during OpenJDK jtreg test runs? or some other runs? could you please provide a JBS bug id.

I would be happy to create issues but getting access is difficult and the website to create bugs as unregistered user is missing the corresponding category entry.

I am fairly confident, that even just an OOME could potentially trigger this behavior in OpenJDK.  But it was observed in another VM.

-------------

PR Comment: https://git.openjdk.org/jtharness/pull/58#issuecomment-2024600594