From dbessono at openjdk.org  Thu May 16 11:37:11 2024
From: dbessono at openjdk.org (Dmitry Bessonov)
Date: Thu, 16 May 2024 11:37:11 GMT
Subject: RFR: 7903713: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts [v3]
In-Reply-To: <l8J5jiUVEWFyLTwIuoMiGhljO8k3yOpSrN_VBgPUFwA=.33a6d547-d0d1-4fbe-8337-e473be6b463a@github.com>
References: <BikFXp2XTyeqAZIkl8cQCPG2ndmx4o9ER6GtGHjyQgI=.8dbd3a02-08ef-41d4-8049-77c560b9e047@github.com>
 <l8J5jiUVEWFyLTwIuoMiGhljO8k3yOpSrN_VBgPUFwA=.33a6d547-d0d1-4fbe-8337-e473be6b463a@github.com>
Message-ID: <clPfsH2CUpRXI1gnI7Wkm5BmHodz58vd8m1cx0qd8W8=.9658031b-6eaf-4344-9170-e3c731902eae@github.com>

On Wed, 17 Apr 2024 11:24:10 GMT, gollayadav <duke at openjdk.org> wrote:

>> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine. Also verified with JDK8 on macos.
>> 
>> 1. CreateWorkdir2.java
>> 2. CreateWorkdir4.java
>> 3. CreateWorkdir5.java
>> 4. CreateWorkdir6.java
>> 5. CreateWorkdir7.java
>
> gollayadav has updated the pull request incrementally with one additional commit since the last revision:
> 
>   7903713: Updated test scripts

Thank you for improving test coverage, looks good.

-------------

Marked as reviewed by dbessono (Reviewer).

PR Review: https://git.openjdk.org/jtharness/pull/68#pullrequestreview-2060478877

From dbessono at openjdk.org  Mon May 20 12:33:10 2024
From: dbessono at openjdk.org (Dmitry Bessonov)
Date: Mon, 20 May 2024 12:33:10 GMT
Subject: RFR: 7903717: Feature Tests - Adding five JavaTest GUI legacy
 automated test scripts
In-Reply-To: <HEoPsIjaWnUY9fD0ktwARvftw9ShPCQb3fIa2L_ZSUY=.d5d3c862-59f3-4c9b-9251-b9179d65e599@github.com>
References: <HEoPsIjaWnUY9fD0ktwARvftw9ShPCQb3fIa2L_ZSUY=.d5d3c862-59f3-4c9b-9251-b9179d65e599@github.com>
Message-ID: <QNLce6DTAfCCnMcECPID_OHT6hV-BoUdHtzs5ZUBmic=.95a57484-cdcc-4598-bdd8-67fb008f856c@github.com>

On Mon, 22 Apr 2024 09:27:56 GMT, gollayadav <duke at openjdk.org> wrote:

> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine. Also verified with JDK8 on macos.
> 
> 1. CreateWorkdir16.java
> 2. CreateWorkdir17.java
> 3. Config_Edit2.java
> 4. Config_Load6_1.java
> 5. Config_Load8.java

gui-tests/src/gui/src/jthtest/Config_Edit/Config_Edit2.java line 39:

> 37: 
> 38: public class Config_Edit2 extends Test {
> 39:      private final static Hashtable standartTable;

Suggesting to use HashMap instead and use generics.

gui-tests/src/gui/src/jthtest/Config_Edit/Config_Edit2.java line 65:

> 63:      }
> 64: 
> 65:      public void testImpl() throws Exception {

Does the commented out code work and the test pass?

-------------

PR Review Comment: https://git.openjdk.org/jtharness/pull/70#discussion_r1606719045
PR Review Comment: https://git.openjdk.org/jtharness/pull/70#discussion_r1606716553

From dbessono at openjdk.org  Mon May 20 12:36:09 2024
From: dbessono at openjdk.org (Dmitry Bessonov)
Date: Mon, 20 May 2024 12:36:09 GMT
Subject: RFR: 7903718: Feature Tests - Adding four JavaTest GUI legacy
 automated test scripts
In-Reply-To: <PfFujf6kjd7u81fpoDVVqkKVfWeRJXHFXRk03gmZo_c=.ffb5acee-c426-4ce5-aa55-a9033638c749@github.com>
References: <PfFujf6kjd7u81fpoDVVqkKVfWeRJXHFXRk03gmZo_c=.ffb5acee-c426-4ce5-aa55-a9033638c749@github.com>
Message-ID: <hv6cU0pr0PzD12D9L2ZEJr9JqWFytpRkTdhdTsq0SRY=.98940bb0-fc41-4301-b966-a0278083cfbc@github.com>

On Mon, 22 Apr 2024 10:35:15 GMT, gollayadav <duke at openjdk.org> wrote:

> Adding below automated legacy JavaTest GUI feature Test Scripts to the Jemmy regression suite and tested locally on three platforms(Linux, Windows, Mac OS) and working fine. Also verified with JDK8 on macos.
> 
> 1. Markers22.java
> 2. ReportConverter1.java
> 3. View2.java
> 4. View3.java

gui-tests/src/gui/src/jthtest/Markers/Markers22.java line 112:

> 110:      @Override
> 111:      public String getDescription() {
> 112:           return "Start JavaTest with the -NewDesktop option. Create a workdirectory. Load an existing JTI file. Bring up configuration editor by doing Ctrl-E. Select the Enable Bookmarks from the Bookmarks menu. Select couple of questions from the history list. Bring up the popup menu and mark the all the questions. Bring up the Clear Answers to Marked Questions from the Bookmarks menu. Verify that all the selected questions should be have empty answers.";

Please split into several lines

gui-tests/src/gui/src/jthtest/StandardConfig_View/View.java line 43:

> 41:             new JMenuOperator(mainFrame, "Configure").pushMenuNoBlock("Configure|New Configuration", "|");
> 42:             return findConfigEditor(mainFrame);
> 43:         }/**/

Empty comment seems to be lost.

-------------

PR Review Comment: https://git.openjdk.org/jtharness/pull/71#discussion_r1606720894
PR Review Comment: https://git.openjdk.org/jtharness/pull/71#discussion_r1606721582

From duke at openjdk.org  Thu May 23 15:00:15 2024
From: duke at openjdk.org (duke)
Date: Thu, 23 May 2024 15:00:15 GMT
Subject: Withdrawn: Use ThreadGroup for passive connection
In-Reply-To: <EmSRXyVVXbATWNjJ2ENZoaVruerkUXZwm0lDBYEz3L0=.a03bbb01-d325-4707-bdd6-105e09531b95@github.com>
References: <EmSRXyVVXbATWNjJ2ENZoaVruerkUXZwm0lDBYEz3L0=.a03bbb01-d325-4707-bdd6-105e09531b95@github.com>
Message-ID: <9g6ZnH8Yh9ZoIeFt2S1AG7FquxX3kSuFv9mYdNlLgbM=.b8630d8a-8fcf-4fef-b879-60dc204e5749@github.com>

On Fri, 29 Dec 2023 11:15:50 GMT, moritz-bruder <duke at openjdk.org> wrote:

> Passive connections use a separate thread to ensure interruptible IO. Since this is technically part of the test setup it should use a separate ThreadGroup.
> 
> Please let me know if anything else is needed or you want to see any changes. I was trying to follow your processes but found a lot of dead links.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jtharness/pull/58

From duke at openjdk.org  Wed May 29 05:11:38 2024
From: duke at openjdk.org (andrlos)
Date: Wed, 29 May 2024 05:11:38 GMT
Subject: RFR: exracting method to fill in result status to allow for
 overriding in implementations of Script [v2]
In-Reply-To: <_7VE7By5WXV8vLGU5WVYrFkwqrvuW9Ron8qtzOOWZTs=.8a7f9002-ad83-463e-8550-c1c8a09e3cea@github.com>
References: <_7VE7By5WXV8vLGU5WVYrFkwqrvuW9Ron8qtzOOWZTs=.8a7f9002-ad83-463e-8550-c1c8a09e3cea@github.com>
Message-ID: <AqOFFcUq9W8l_ogX2YmOMz4mnewC_RWrpZLGGQ_wujA=.bced328a-1a8f-409e-81e8-1ed321218a8a@github.com>

> This is an alternative approach to https://github.com/openjdk/jtharness/pull/57
> counting on Script subclasses that will allow for such modifications.

andrlos has updated the pull request incrementally with one additional commit since the last revision:

  simplyfied method name

-------------

Changes:
  - all: https://git.openjdk.org/jtharness/pull/59/files
  - new: https://git.openjdk.org/jtharness/pull/59/files/aa542e51..95083b2e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jtharness&pr=59&range=01
 - incr: https://webrevs.openjdk.org/?repo=jtharness&pr=59&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jtharness/pull/59.diff
  Fetch: git fetch https://git.openjdk.org/jtharness.git pull/59/head:pull/59

PR: https://git.openjdk.org/jtharness/pull/59