RFR: 7900303: auto updating components need accessbility control [v2]
Dmitry Bessonov
dbessono at openjdk.org
Mon Sep 2 11:06:26 UTC 2024
On Fri, 30 Aug 2024 18:30:15 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:
>> Dmitry Bessonov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> CRN second year update
>
> src/com/sun/javatest/exec/ProgressMonitor.java line 382:
>
>> 380:
>> 381: boolean showTestRunProgressMonitor =
>> 382: !Boolean.valueOf(System.getProperty("javatest.desktop.testrunprogressmonitor.hidden"));
>
> AFAICS in the JavaTest code the property names sometimes are stored in string constants and sometimes are hardcoded in the sources. I can not tell which way is preferred, so just making a comment that optionally a string constant can be used for the property name.
Thank you, filed a follow-up improvement https://git.openjdk.org/jtharness/pull/83
-------------
PR Review Comment: https://git.openjdk.org/jtharness/pull/82#discussion_r1740728681
More information about the jtharness-dev
mailing list