From dbessono at openjdk.org  Fri Jan 10 12:55:20 2025
From: dbessono at openjdk.org (Dmitry Bessonov)
Date: Fri, 10 Jan 2025 12:55:20 GMT
Subject: RFR: 7903929: Improve component layout in ChoiceQuestionRenderer and
 ChoiceArrayQuestionRenderer
Message-ID: <SLWkzwIKuaLHAwvt36N-F2P1NT3_5G6MCvLk6KwZfeQ=.fcedab4f-8d51-4f01-a6eb-a49bff6cb126@github.com>

The ChoiceQuestionRenderer and ChoiceArrayQuestionRenderer classes contain a complex layout of the components which represent selectable options. This layout is based on JTable used as a container and this over-complicates navigation with keyboard and proper rendering.

Instead of JTable, a standard approach to layout using panels could be used.

-------------

Commit messages:
 - 7903892: JT Harness - cannot do a selection in a group of components via keyboard

Changes: https://git.openjdk.org/jtharness/pull/91/files
  Webrev: https://webrevs.openjdk.org/?repo=jtharness&pr=91&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903929
  Stats: 262 lines in 2 files changed: 10 ins; 232 del; 20 mod
  Patch: https://git.openjdk.org/jtharness/pull/91.diff
  Fetch: git fetch https://git.openjdk.org/jtharness.git pull/91/head:pull/91

PR: https://git.openjdk.org/jtharness/pull/91

From lkuskov at openjdk.org  Fri Jan 10 16:11:49 2025
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Fri, 10 Jan 2025 16:11:49 GMT
Subject: RFR: 7903929: Improve component layout in ChoiceQuestionRenderer
 and ChoiceArrayQuestionRenderer
In-Reply-To: <SLWkzwIKuaLHAwvt36N-F2P1NT3_5G6MCvLk6KwZfeQ=.fcedab4f-8d51-4f01-a6eb-a49bff6cb126@github.com>
References: <SLWkzwIKuaLHAwvt36N-F2P1NT3_5G6MCvLk6KwZfeQ=.fcedab4f-8d51-4f01-a6eb-a49bff6cb126@github.com>
Message-ID: <gt3xoAGJGpeGPE9CwobzOTQK-vM0lcbrRxoRkqVjs7k=.d465eb1a-d1bd-48c1-9d30-2f78bb43e8a7@github.com>

On Fri, 10 Jan 2025 12:50:57 GMT, Dmitry Bessonov <dbessono at openjdk.org> wrote:

> The ChoiceQuestionRenderer and ChoiceArrayQuestionRenderer classes contain a complex layout of the components which represent selectable options. This layout is based on JTable used as a container and this over-complicates navigation with keyboard and proper rendering.
> 
> Instead of JTable, a standard approach to layout using panels could be used.

Marked as reviewed by lkuskov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jtharness/pull/91#pullrequestreview-2542840255

From dbessono at openjdk.org  Fri Jan 10 17:06:45 2025
From: dbessono at openjdk.org (Dmitry Bessonov)
Date: Fri, 10 Jan 2025 17:06:45 GMT
Subject: Integrated: 7903929: Improve component layout in
 ChoiceQuestionRenderer and ChoiceArrayQuestionRenderer
In-Reply-To: <SLWkzwIKuaLHAwvt36N-F2P1NT3_5G6MCvLk6KwZfeQ=.fcedab4f-8d51-4f01-a6eb-a49bff6cb126@github.com>
References: <SLWkzwIKuaLHAwvt36N-F2P1NT3_5G6MCvLk6KwZfeQ=.fcedab4f-8d51-4f01-a6eb-a49bff6cb126@github.com>
Message-ID: <tcGN9oxsNXIkSQ33-OnAkP2k7PPblj8dvkp20JVN6mU=.00ee71f0-b2ba-4ada-a24a-705b1e0bb236@github.com>

On Fri, 10 Jan 2025 12:50:57 GMT, Dmitry Bessonov <dbessono at openjdk.org> wrote:

> The ChoiceQuestionRenderer and ChoiceArrayQuestionRenderer classes contain a complex layout of the components which represent selectable options. This layout is based on JTable used as a container and this over-complicates navigation with keyboard and proper rendering.
> 
> Instead of JTable, a standard approach to layout using panels could be used.

This pull request has now been integrated.

Changeset: 7315e725
Author:    Dmitry Bessonov <dbessono at openjdk.org>
URL:       https://git.openjdk.org/jtharness/commit/7315e72563c8328adbf219241afb46f8fb91332d
Stats:     262 lines in 2 files changed: 10 ins; 232 del; 20 mod

7903929: Improve component layout in ChoiceQuestionRenderer and ChoiceArrayQuestionRenderer

Reviewed-by: lkuskov

-------------

PR: https://git.openjdk.org/jtharness/pull/91