From jonathan.gibbons at oracle.com Sat Mar 2 09:42:26 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Sat, 02 Mar 2013 17:42:26 +0000
Subject: hg: code-tools/jtreg: 7900030: jtreg fails to find test if more than
1 @bug tag or 'bug' is next line after @bug tag
Message-ID: <20130302174226.AC025477E3@hg.openjdk.java.net>
Changeset: d51e8d24dbaf
Author: jjg
Date: 2013-03-02 09:42 -0800
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/d51e8d24dbaf
7900030: jtreg fails to find test if more than 1 @bug tag or 'bug' is next line after @bug tag
! make/tests/BugIdTests.gmk
! src/share/classes/com/sun/javatest/regtest/RegressionTestFinder.java
+ src/share/test/javatest/regtest/data/bugidtests/MixTest.java
From jonathan.gibbons at oracle.com Sat Mar 2 14:37:41 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Sat, 02 Mar 2013 22:37:41 +0000
Subject: hg: code-tools/jtreg: 7165943: jtreg should retun an exit code if
-bug:ID is used and no tests are found
Message-ID: <20130302223741.92EFA477E6@hg.openjdk.java.net>
Changeset: dc66abdd6822
Author: jjg
Date: 2013-03-02 14:37 -0800
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/dc66abdd6822
7165943: jtreg should retun an exit code if -bug:ID is used and no tests are found
+ make/tests/ExitCodeTest.gmk
! src/share/classes/com/sun/javatest/regtest/Main.java
+ src/share/test/javatest/regtest/data/exitCodes/Error.java
+ src/share/test/javatest/regtest/data/exitCodes/Fail.java
+ src/share/test/javatest/regtest/data/exitCodes/Pass.java
+ src/share/test/javatest/regtest/data/exitCodes/TEST.ROOT
From jonathan.gibbons at oracle.com Wed Mar 6 16:40:11 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Thu, 07 Mar 2013 00:40:11 +0000
Subject: hg: code-tools/jtreg: 7900103: refactor jtreg Main to support
"TestManager" abstraction
Message-ID: <20130307004011.D81B047A97@hg.openjdk.java.net>
Changeset: 18b915ef257f
Author: jjg
Date: 2013-03-06 16:40 -0800
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/18b915ef257f
7900103: refactor jtreg Main to support "TestManager" abstraction
! src/share/classes/com/sun/javatest/regtest/Main.java
! src/share/classes/com/sun/javatest/regtest/RegressionReporter.java
! src/share/classes/com/sun/javatest/regtest/RegressionTestSuite.java
+ src/share/classes/com/sun/javatest/regtest/TestManager.java
! src/share/classes/com/sun/javatest/regtest/i18n.properties
From stuart.marks at oracle.com Thu Mar 7 15:15:58 2013
From: stuart.marks at oracle.com (Stuart Marks)
Date: Thu, 07 Mar 2013 15:15:58 -0800
Subject: RFR: 7900051 - jtreg cleanup intermittentely fails to delete
files on Windows
In-Reply-To: <5114393E.4000503@oracle.com>
References: <51005505.7060607@oracle.com> <5112915D.4090303@oracle.com>
<51130F5F.8050200@oracle.com> <5113109C.4060206@oracle.com>
<51141DB6.7070707@oracle.com> <5114220B.10100@oracle.com>
<511435B5.4080308@oracle.com> <5114393E.4000503@oracle.com>
Message-ID: <51391FAE.7020307@oracle.com>
Hi, did this ever get pushed?
Eric Wang was diagnosing intermittent test failures and he was running into
problems where a test would pass but jtreg would fail it after-the-fact when it
was unable to clean up the scratch directory. I think those failures might be
helped by Jim's cleanup change.
s'marks
On 2/7/13 3:31 PM, Jonathan Gibbons wrote:
> I've not looked at this round of changes, but I will, and will push them if
> they're OK.
>
> -- Jon
>
> On 02/07/2013 03:16 PM, Jim Gish wrote:
>> All I had to do was look at the subject of my own message, didn't I? It's
>> been one of those crazy days:-( Thanks.
>>
>> Do the changes look ok? If so, could you push them, please? (I updated the
>> commit message and attached a proper patch).
>>
>> Jim
>>
>> On 02/07/2013 04:52 PM, Jonathan Gibbons wrote:
>>> 7900051 is a CODETOOLS bug, isn't it?
>>>
>>> -- Jon
>>>
>>>
>>> On 02/07/2013 01:33 PM, Jim Gish wrote:
>>>> Thanks, Jonathan -- I made your suggested changes. Please re-review. I
>>>> suppose we need a code-tools bug for this don't we?
>>>>
>>>> Thanks,
>>>> Jim
>>>>
>>>> http://cr.openjdk.java.net/~jgish/Bug7900051-DeleteRetry/
>>>>
>>>>
>>>> On 02/06/2013 09:25 PM, Jonathan Gibbons wrote:
>>>>> Also, notice the inconsistent order of words in
>>>>>
>>>>> 111 RETRY_DELETE_DELAY_MSEC = isWindows ? 500 : 0;
>>>>> 112 MAX_DELETE_RETRY_SECONDS = isWindows ? 30 : 0;
>>>>> I guess I would expect to see MAX_ be a prefix to what it is a max of, such as
>>>>> MAX_RETRY_DELETE_SECONDS
>>>>>
>>>>> Also, it's not clear to me that it helps to change units, especially given
>>>>> the silly slip you had in the code that I mentioned earlier. Why not
>>>>> keep all times consistently in the same units, presumably MSEC?
>>>>>
>>>>> -- Jon
>>>>>
>>>>>
>>>>> On 02/06/2013 06:20 PM, Jonathan Gibbons wrote:
>>>>>> Jim,
>>>>>>
>>>>>> Sorry for the delay; thanks for the reminder.
>>>>>>
>>>>>> To get from milliseconds to seconds, you divide by 1000, not multiply by
>>>>>> it ;-) In two places.
>>>>>>
>>>>>> I don't think you should log messages about deleting files. Some tests
>>>>>> generate *lots* of files, and it would be unacceptable to report them
>>>>>> being deleted, one by one. I can see that occasionally you might want
>>>>>> to see this level of details, but it should be enabled by setting a
>>>>>> system property such as javatest.regtest.showDeleteFiles and should be
>>>>>> off by default. Reporting issues when files cannot be deleted, such as
>>>>>> ScratchDirectory.java:191(new) is acceptable.
>>>>>>
>>>>>> -- Jon
>>>>>>
>>>>>>
>>>>>> On 02/06/2013 09:22 AM, Jim Gish wrote:
>>>>>>> I haven't heard back on this one yet. Any comments?
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Jim
>>>>>>>
>>>>>>> On 01/23/2013 04:24 PM, Jim Gish wrote:
>>>>>>>> Please review:
>>>>>>>> http://cr.openjdk.java.net/~jgish/Bug7900051-DeleteRetry/
>>>>>>>>
>>>>>>>>
>>>>>>>> Summary: this change adds delete retry logic on Windows similar to that
>>>>>>>> that is already there on init. It also consolidates the delete
>>>>>>>> methods. Instead of trying some N times with Delta msec. delay in
>>>>>>>> between, it now tries for up to 30 seconds with Delta (500 msec) delay
>>>>>>>> in between.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Jim
>>>>>>>> --
>>>>>>>> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
>>>>>>>> Oracle Java Platform Group | Core Libraries Team
>>>>>>>> 35 Network Drive
>>>>>>>> Burlington, MA 01803
>>>>>>>> jim.gish at oracle.com
>>>>>>>
>>>>>>> --
>>>>>>> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
>>>>>>> Oracle Java Platform Group | Core Libraries Team
>>>>>>> 35 Network Drive
>>>>>>> Burlington, MA 01803
>>>>>>> jim.gish at oracle.com
>>>>>>
>>>>>
>>>>
>>>> --
>>>> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
>>>> Oracle Java Platform Group | Core Libraries Team
>>>> 35 Network Drive
>>>> Burlington, MA 01803
>>>> jim.gish at oracle.com
>>>
>>
>> --
>> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
>> Oracle Java Platform Group | Core Libraries Team
>> 35 Network Drive
>> Burlington, MA 01803
>> jim.gish at oracle.com
>
From jonathan.gibbons at oracle.com Fri Mar 8 10:14:07 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Fri, 08 Mar 2013 18:14:07 +0000
Subject: hg: code-tools/jtreg: 7900110: "jtreg -help" broken
Message-ID: <20130308181407.AC47648010@hg.openjdk.java.net>
Changeset: 087f4a5c9885
Author: jjg
Date: 2013-03-08 10:13 -0800
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/087f4a5c9885
7900110: "jtreg -help" broken
! src/share/classes/com/sun/javatest/regtest/Help.java
! src/share/classes/com/sun/javatest/regtest/Main.java
From jonathan.gibbons at oracle.com Fri Mar 8 10:58:46 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Fri, 08 Mar 2013 18:58:46 +0000
Subject: hg: code-tools/jtreg: 7900107: jtreg should doc the existence of
support for @files
Message-ID: <20130308185846.8BF6848012@hg.openjdk.java.net>
Changeset: e8ac7ffa2e10
Author: jjg
Date: 2013-03-08 10:58 -0800
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/e8ac7ffa2e10
7900107: jtreg should doc the existence of support for @files
! src/share/classes/com/sun/javatest/regtest/Help.java
! src/share/classes/com/sun/javatest/regtest/i18n.properties
From jonathan.gibbons at oracle.com Fri Mar 8 12:07:02 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Fri, 08 Mar 2013 20:07:02 +0000
Subject: hg: code-tools/jtreg: 7900111: jtreg should support test groups
Message-ID: <20130308200703.6550148015@hg.openjdk.java.net>
Changeset: f6459b9d25aa
Author: jjg
Date: 2013-03-08 12:06 -0800
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/f6459b9d25aa
7900111: jtreg should support test groups
! make/Defs.gmk
+ make/tests/GroupTest.gmk
+ src/share/classes/com/sun/javatest/regtest/GraphUtils.java
+ src/share/classes/com/sun/javatest/regtest/GroupManager.java
! src/share/classes/com/sun/javatest/regtest/Help.java
! src/share/classes/com/sun/javatest/regtest/Main.java
! src/share/classes/com/sun/javatest/regtest/RegressionTestFinder.java
! src/share/classes/com/sun/javatest/regtest/RegressionTestSuite.java
! src/share/classes/com/sun/javatest/regtest/TestManager.java
! src/share/classes/com/sun/javatest/regtest/TestProperties.java
! src/share/classes/com/sun/javatest/regtest/i18n.properties
+ src/share/test/javatest/regtest/data/groups/TEST.ROOT
+ src/share/test/javatest/regtest/data/groups/TEST.groups
+ src/share/test/javatest/regtest/data/groups/TEST.groups2
+ src/share/test/javatest/regtest/data/groups/d1/d11/SCCS/Bad.java
+ src/share/test/javatest/regtest/data/groups/d1/d11/Test.java
+ src/share/test/javatest/regtest/data/groups/d1/d12/Test.java
+ src/share/test/javatest/regtest/data/groups/d1/d13/Test.java
+ src/share/test/javatest/regtest/data/groups/d2/Test.java
+ src/share/test/javatest/regtest/data/groups/d3/d31/Test.java
+ src/share/test/javatest/regtest/data/groups/d3/d32/Bad.java
+ src/share/test/javatest/regtest/data/groups/d3/d32/Test.java
+ src/share/test/javatest/regtest/data/groups/d3/d33/Test.java
+ src/share/test/javatest/regtest/data/groups/d4/NoTests.java
From jonathan.gibbons at oracle.com Fri Mar 8 14:22:40 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Fri, 08 Mar 2013 22:22:40 +0000
Subject: hg: code-tools/jtreg: 7900113: some tests incorrectly use java from
$PATH
Message-ID: <20130308222241.0ED484801E@hg.openjdk.java.net>
Changeset: 5237cc454495
Author: jjg
Date: 2013-03-08 14:21 -0800
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/5237cc454495
7900113: some tests incorrectly use java from $PATH
! make/tests/EnvTest.gmk
! make/tests/NoJUnit.gmk
! make/tests/TestWhiteSpaceFiles.gmk
From jonathan.gibbons at oracle.com Fri Mar 8 15:24:53 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Fri, 08 Mar 2013 23:24:53 +0000
Subject: hg: code-tools/jtreg: 7054628: Would like jtreg option to list tests
which would be run without running them
Message-ID: <20130308232454.238A648023@hg.openjdk.java.net>
Changeset: 6d863eb30919
Author: jjg
Date: 2013-03-08 15:24 -0800
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/6d863eb30919
7054628: Would like jtreg option to list tests which would be run without running them
! src/share/classes/com/sun/javatest/regtest/Main.java
! src/share/classes/com/sun/javatest/regtest/i18n.properties
From jonathan.gibbons at oracle.com Sat Mar 9 11:38:25 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Sat, 09 Mar 2013 19:38:25 +0000
Subject: hg: code-tools/jtreg: 7900118: -listtest doesn't work correctly in
multirun mode
Message-ID: <20130309193826.7F8894803A@hg.openjdk.java.net>
Changeset: 31862b8cac88
Author: jjg
Date: 2013-03-09 11:38 -0800
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/31862b8cac88
7900118: -listtest doesn't work correctly in multirun mode
! src/share/classes/com/sun/javatest/regtest/Main.java
! src/share/classes/com/sun/javatest/regtest/i18n.properties
From jonathan.gibbons at oracle.com Sat Mar 9 17:33:27 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Sun, 10 Mar 2013 01:33:27 +0000
Subject: hg: code-tools/jtreg: 7900119: Add option to show the expansion of
groups
Message-ID: <20130310013328.98CEB4803D@hg.openjdk.java.net>
Changeset: 0d7f0cb95c7c
Author: jjg
Date: 2013-03-09 17:33 -0800
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/0d7f0cb95c7c
7900119: Add option to show the expansion of groups
! src/share/classes/com/sun/javatest/regtest/GroupManager.java
! src/share/classes/com/sun/javatest/regtest/Main.java
+ src/share/classes/com/sun/javatest/regtest/NaturalComparator.java
! src/share/classes/com/sun/javatest/regtest/TestManager.java
! src/share/classes/com/sun/javatest/regtest/i18n.properties
From jonathan.gibbons at oracle.com Thu Mar 14 12:05:50 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Thu, 14 Mar 2013 19:05:50 +0000
Subject: hg: code-tools/jtreg: 7900128: jtreg should use absolute paths for
test.jdk and compile.jdk properties
Message-ID: <20130314190551.59BC848156@hg.openjdk.java.net>
Changeset: 3764980b808e
Author: jjg
Date: 2013-03-14 12:05 -0700
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/3764980b808e
7900128: jtreg should use absolute paths for test.jdk and compile.jdk properties
! src/share/classes/com/sun/javatest/regtest/RegressionScript.java
From jonathan.gibbons at oracle.com Sat Mar 16 10:57:55 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Sat, 16 Mar 2013 17:57:55 +0000
Subject: hg: code-tools/jtreg: 7900131: @build should use
-XDignore.symbol.file=true
Message-ID: <20130316175755.A0FF0481D5@hg.openjdk.java.net>
Changeset: 5d04f69f18e4
Author: jjg
Date: 2013-03-16 10:57 -0700
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/5d04f69f18e4
7900131: @build should use -XDignore.symbol.file=true
+ make/tests/IgnoreSymbolFileTest.gmk
! src/share/classes/com/sun/javatest/regtest/BuildAction.java
+ src/share/test/javatest/regtest/data/ignoresymbolfile/TEST.ROOT
+ src/share/test/javatest/regtest/data/ignoresymbolfile/Test.java
From jonathan.gibbons at oracle.com Sat Mar 16 14:09:42 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Sat, 16 Mar 2013 21:09:42 +0000
Subject: hg: code-tools/jtreg: 7900132: TestProperties should save lib dirs as
root-relative paths
Message-ID: <20130316210943.06D37481D9@hg.openjdk.java.net>
Changeset: ccde148d0ecb
Author: jjg
Date: 2013-03-16 14:09 -0700
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/ccde148d0ecb
7900132: TestProperties should save lib dirs as root-relative paths
! src/share/classes/com/sun/javatest/regtest/TestProperties.java
+ src/share/test/javatest/regtest/data/libdirs/TEST.ROOT
+ src/share/test/javatest/regtest/data/libdirs/l1/L1.java
+ src/share/test/javatest/regtest/data/libdirs/l2/L2.java
+ src/share/test/javatest/regtest/data/libdirs/l4/L4.java
+ src/share/test/javatest/regtest/data/libdirs/l6/L6.java
+ src/share/test/javatest/regtest/data/libdirs/t1/TEST.properties
+ src/share/test/javatest/regtest/data/libdirs/t1/l3/L3.java
+ src/share/test/javatest/regtest/data/libdirs/t1/l5/L5.java
+ src/share/test/javatest/regtest/data/libdirs/t1/t2/LibTest.java
+ src/share/test/javatest/regtest/data/libdirs/t1/t2/TEST.properties
From jonathan.gibbons at oracle.com Sat Mar 16 15:36:49 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Sat, 16 Mar 2013 22:36:49 +0000
Subject: hg: code-tools/jtreg: 7900133: fix library build issues for TestNG
tests
Message-ID: <20130316223649.E4063481DC@hg.openjdk.java.net>
Changeset: 1f625ce4f59d
Author: jjg
Date: 2013-03-16 15:36 -0700
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/1f625ce4f59d
7900133: fix library build issues for TestNG tests
+ make/tests/LibDirsTest.gmk
! src/share/classes/com/sun/javatest/regtest/BuildAction.java
! src/share/classes/com/sun/javatest/regtest/TestNGAction.java
From jonathan.gibbons at oracle.com Sat Mar 16 19:31:23 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Sun, 17 Mar 2013 02:31:23 +0000
Subject: hg: code-tools/jtreg: 7900134: fix bootclasspath issues for TestNG
tests
Message-ID: <20130317023124.84867481E4@hg.openjdk.java.net>
Changeset: 98387c9f36e3
Author: jjg
Date: 2013-03-16 19:30 -0700
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/98387c9f36e3
7900134: fix bootclasspath issues for TestNG tests
! make/tests/BootClassPathTest.gmk
! src/share/classes/com/sun/javatest/regtest/MainAction.java
! src/share/classes/com/sun/javatest/regtest/RegressionScript.java
! src/share/classes/com/sun/javatest/regtest/RegressionTestSuite.java
From jonathan.gibbons at oracle.com Sun Mar 17 16:47:03 2013
From: jonathan.gibbons at oracle.com (Jonathan Gibbons)
Date: Sun, 17 Mar 2013 16:47:03 -0700
Subject: RFR: 7900051 - jtreg cleanup intermittentely fails to delete
files on Windows
In-Reply-To: <511435B5.4080308@oracle.com>
References: <51005505.7060607@oracle.com> <5112915D.4090303@oracle.com>
<51130F5F.8050200@oracle.com> <5113109C.4060206@oracle.com>
<51141DB6.7070707@oracle.com> <5114220B.10100@oracle.com>
<511435B5.4080308@oracle.com>
Message-ID: <514655F7.9090102@oracle.com>
Jim,
You don't appear to have fixed the issue that milliseconds * 1000 gives
you microseconds, not seconds. No matter I will fix it.
-- Jon
On 02/07/2013 03:16 PM, Jim Gish wrote:
> All I had to do was look at the subject of my own message, didn't I?
> It's been one of those crazy days:-( Thanks.
>
> Do the changes look ok? If so, could you push them, please? (I
> updated the commit message and attached a proper patch).
>
> Jim
>
> On 02/07/2013 04:52 PM, Jonathan Gibbons wrote:
>> 7900051 is a CODETOOLS bug, isn't it?
>>
>> -- Jon
>>
>>
>> On 02/07/2013 01:33 PM, Jim Gish wrote:
>>> Thanks, Jonathan -- I made your suggested changes. Please
>>> re-review. I suppose we need a code-tools bug for this don't we?
>>>
>>> Thanks,
>>> Jim
>>>
>>> http://cr.openjdk.java.net/~jgish/Bug7900051-DeleteRetry/
>>>
>>>
>>> On 02/06/2013 09:25 PM, Jonathan Gibbons wrote:
>>>> Also, notice the inconsistent order of words in
>>>>
>>>> 111 RETRY_DELETE_DELAY_MSEC = isWindows ? 500 : 0;
>>>> 112 MAX_DELETE_RETRY_SECONDS = isWindows ? 30 : 0;
>>>> I guess I would expect to see MAX_ be a prefix to what it is a max
>>>> of, such as
>>>> MAX_RETRY_DELETE_SECONDS
>>>>
>>>> Also, it's not clear to me that it helps to change units,
>>>> especially given the silly slip you had in the code that I
>>>> mentioned earlier. Why not keep all times consistently in the
>>>> same units, presumably MSEC?
>>>>
>>>> -- Jon
>>>>
>>>>
>>>> On 02/06/2013 06:20 PM, Jonathan Gibbons wrote:
>>>>> Jim,
>>>>>
>>>>> Sorry for the delay; thanks for the reminder.
>>>>>
>>>>> To get from milliseconds to seconds, you divide by 1000, not
>>>>> multiply by it ;-) In two places.
>>>>>
>>>>> I don't think you should log messages about deleting files. Some
>>>>> tests generate *lots* of files, and it would be unacceptable to
>>>>> report them being deleted, one by one. I can see that
>>>>> occasionally you might want to see this level of details, but it
>>>>> should be enabled by setting a system property such as
>>>>> javatest.regtest.showDeleteFiles and should be off by default.
>>>>> Reporting issues when files cannot be deleted, such as
>>>>> ScratchDirectory.java:191(new) is acceptable.
>>>>>
>>>>> -- Jon
>>>>>
>>>>>
>>>>> On 02/06/2013 09:22 AM, Jim Gish wrote:
>>>>>> I haven't heard back on this one yet. Any comments?
>>>>>>
>>>>>> Thanks,
>>>>>> Jim
>>>>>>
>>>>>> On 01/23/2013 04:24 PM, Jim Gish wrote:
>>>>>>> Please review:
>>>>>>> http://cr.openjdk.java.net/~jgish/Bug7900051-DeleteRetry/
>>>>>>>
>>>>>>>
>>>>>>> Summary: this change adds delete retry logic on Windows similar
>>>>>>> to that that is already there on init. It also consolidates the
>>>>>>> delete methods. Instead of trying some N times with Delta msec.
>>>>>>> delay in between, it now tries for up to 30 seconds with Delta
>>>>>>> (500 msec) delay in between.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Jim
>>>>>>> --
>>>>>>> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
>>>>>>> Oracle Java Platform Group | Core Libraries Team
>>>>>>> 35 Network Drive
>>>>>>> Burlington, MA 01803
>>>>>>> jim.gish at oracle.com
>>>>>>
>>>>>> --
>>>>>> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
>>>>>> Oracle Java Platform Group | Core Libraries Team
>>>>>> 35 Network Drive
>>>>>> Burlington, MA 01803
>>>>>> jim.gish at oracle.com
>>>>>
>>>>
>>>
>>> --
>>> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
>>> Oracle Java Platform Group | Core Libraries Team
>>> 35 Network Drive
>>> Burlington, MA 01803
>>> jim.gish at oracle.com
>>
>
> --
> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
> Oracle Java Platform Group | Core Libraries Team
> 35 Network Drive
> Burlington, MA 01803
> jim.gish at oracle.com
From jonathan.gibbons at oracle.com Sun Mar 17 17:25:15 2013
From: jonathan.gibbons at oracle.com (Jonathan Gibbons)
Date: Sun, 17 Mar 2013 17:25:15 -0700
Subject: RFR: 7900051 - jtreg cleanup intermittentely fails to delete
files on Windows
In-Reply-To: <514655F7.9090102@oracle.com>
References: <51005505.7060607@oracle.com> <5112915D.4090303@oracle.com>
<51130F5F.8050200@oracle.com> <5113109C.4060206@oracle.com>
<51141DB6.7070707@oracle.com> <5114220B.10100@oracle.com>
<511435B5.4080308@oracle.com> <514655F7.9090102@oracle.com>
Message-ID: <51465EEB.8030709@oracle.com>
OK, I think I see what happened -- I guess you didn't update the webrev
and just posted the patch.
-- Jon
On 03/17/2013 04:47 PM, Jonathan Gibbons wrote:
> Jim,
>
> You don't appear to have fixed the issue that milliseconds * 1000
> gives you microseconds, not seconds. No matter I will fix it.
>
> -- Jon
>
> On 02/07/2013 03:16 PM, Jim Gish wrote:
>> All I had to do was look at the subject of my own message, didn't I?
>> It's been one of those crazy days:-( Thanks.
>>
>> Do the changes look ok? If so, could you push them, please? (I
>> updated the commit message and attached a proper patch).
>>
>> Jim
>>
>> On 02/07/2013 04:52 PM, Jonathan Gibbons wrote:
>>> 7900051 is a CODETOOLS bug, isn't it?
>>>
>>> -- Jon
>>>
>>>
>>> On 02/07/2013 01:33 PM, Jim Gish wrote:
>>>> Thanks, Jonathan -- I made your suggested changes. Please
>>>> re-review. I suppose we need a code-tools bug for this don't we?
>>>>
>>>> Thanks,
>>>> Jim
>>>>
>>>> http://cr.openjdk.java.net/~jgish/Bug7900051-DeleteRetry/
>>>>
>>>>
>>>> On 02/06/2013 09:25 PM, Jonathan Gibbons wrote:
>>>>> Also, notice the inconsistent order of words in
>>>>>
>>>>> 111 RETRY_DELETE_DELAY_MSEC = isWindows ? 500 : 0;
>>>>> 112 MAX_DELETE_RETRY_SECONDS = isWindows ? 30 : 0;
>>>>> I guess I would expect to see MAX_ be a prefix to what it is a max
>>>>> of, such as
>>>>> MAX_RETRY_DELETE_SECONDS
>>>>>
>>>>> Also, it's not clear to me that it helps to change units,
>>>>> especially given the silly slip you had in the code that I
>>>>> mentioned earlier. Why not keep all times consistently in the
>>>>> same units, presumably MSEC?
>>>>>
>>>>> -- Jon
>>>>>
>>>>>
>>>>> On 02/06/2013 06:20 PM, Jonathan Gibbons wrote:
>>>>>> Jim,
>>>>>>
>>>>>> Sorry for the delay; thanks for the reminder.
>>>>>>
>>>>>> To get from milliseconds to seconds, you divide by 1000, not
>>>>>> multiply by it ;-) In two places.
>>>>>>
>>>>>> I don't think you should log messages about deleting files. Some
>>>>>> tests generate *lots* of files, and it would be unacceptable to
>>>>>> report them being deleted, one by one. I can see that
>>>>>> occasionally you might want to see this level of details, but it
>>>>>> should be enabled by setting a system property such as
>>>>>> javatest.regtest.showDeleteFiles and should be off by default.
>>>>>> Reporting issues when files cannot be deleted, such as
>>>>>> ScratchDirectory.java:191(new) is acceptable.
>>>>>>
>>>>>> -- Jon
>>>>>>
>>>>>>
>>>>>> On 02/06/2013 09:22 AM, Jim Gish wrote:
>>>>>>> I haven't heard back on this one yet. Any comments?
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Jim
>>>>>>>
>>>>>>> On 01/23/2013 04:24 PM, Jim Gish wrote:
>>>>>>>> Please review:
>>>>>>>> http://cr.openjdk.java.net/~jgish/Bug7900051-DeleteRetry/
>>>>>>>>
>>>>>>>>
>>>>>>>> Summary: this change adds delete retry logic on Windows similar
>>>>>>>> to that that is already there on init. It also consolidates
>>>>>>>> the delete methods. Instead of trying some N times with Delta
>>>>>>>> msec. delay in between, it now tries for up to 30 seconds with
>>>>>>>> Delta (500 msec) delay in between.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Jim
>>>>>>>> --
>>>>>>>> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
>>>>>>>> Oracle Java Platform Group | Core Libraries Team
>>>>>>>> 35 Network Drive
>>>>>>>> Burlington, MA 01803
>>>>>>>> jim.gish at oracle.com
>>>>>>>
>>>>>>> --
>>>>>>> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
>>>>>>> Oracle Java Platform Group | Core Libraries Team
>>>>>>> 35 Network Drive
>>>>>>> Burlington, MA 01803
>>>>>>> jim.gish at oracle.com
>>>>>>
>>>>>
>>>>
>>>> --
>>>> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
>>>> Oracle Java Platform Group | Core Libraries Team
>>>> 35 Network Drive
>>>> Burlington, MA 01803
>>>> jim.gish at oracle.com
>>>
>>
>> --
>> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
>> Oracle Java Platform Group | Core Libraries Team
>> 35 Network Drive
>> Burlington, MA 01803
>> jim.gish at oracle.com
>
From jonathan.gibbons at oracle.com Sun Mar 17 17:56:43 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Mon, 18 Mar 2013 00:56:43 +0000
Subject: hg: code-tools/jtreg: 7900051: jtreg cleanup intermittently fails to
delete files on Windows
Message-ID: <20130318005643.D794848201@hg.openjdk.java.net>
Changeset: 5ff665fbc16d
Author: jjg
Date: 2013-03-17 17:56 -0700
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/5ff665fbc16d
7900051: jtreg cleanup intermittently fails to delete files on Windows
Contributed-by: jim.gish at oracle.com
! src/share/classes/com/sun/javatest/regtest/RegressionScript.java
! src/share/classes/com/sun/javatest/regtest/ScratchDirectory.java
From jonathan.gibbons at oracle.com Sun Mar 17 18:07:39 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Mon, 18 Mar 2013 01:07:39 +0000
Subject: hg: code-tools/jtreg: 7900135: jtreg should detect validity of JT_HOME
Message-ID: <20130318010739.AC2CB48202@hg.openjdk.java.net>
Changeset: 88ad7368b700
Author: jjg
Date: 2013-03-17 18:07 -0700
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/88ad7368b700
7900135: jtreg should detect validity of JT_HOME
Contributed-by: jim.gish at oracle.com
! src/share/bin/jtreg.sh
From jonathan.gibbons at oracle.com Mon Mar 18 18:16:41 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Tue, 19 Mar 2013 01:16:41 +0000
Subject: hg: code-tools/jtreg: 7900136: update Ant build
Message-ID: <20130319011642.6620048230@hg.openjdk.java.net>
Changeset: a8a8f2d2e711
Author: jjg
Date: 2013-03-18 18:16 -0700
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/a8a8f2d2e711
7900136: update Ant build
! make/build.properties
! make/build.xml
+ make/i18n.pat
! src/share/classes/com/sun/javatest/regtest/GroupManager.java
! src/share/classes/com/sun/javatest/regtest/RegressionTestFinder.java
! src/share/classes/com/sun/javatest/regtest/TestManager.java
From jonathan.gibbons at oracle.com Wed Mar 20 13:11:24 2013
From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com)
Date: Wed, 20 Mar 2013 20:11:24 +0000
Subject: hg: code-tools/jtreg: 7900138: Exclude from group not working
Message-ID: <20130320201125.4F681482B5@hg.openjdk.java.net>
Changeset: d47a6e238c3e
Author: jjg
Date: 2013-03-20 13:10 -0700
URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/d47a6e238c3e
7900138: Exclude from group not working
! src/share/classes/com/sun/javatest/regtest/TestManager.java
From yiming.wang at oracle.com Thu Mar 7 15:45:19 2013
From: yiming.wang at oracle.com (Eric Wang)
Date: Thu, 07 Mar 2013 23:45:19 -0000
Subject: RFR: 7900051 - jtreg cleanup intermittentely fails to delete
files on Windows
In-Reply-To: <51391FAE.7020307@oracle.com>
References: <51005505.7060607@oracle.com> <5112915D.4090303@oracle.com>
<51130F5F.8050200@oracle.com> <5113109C.4060206@oracle.com>
<51141DB6.7070707@oracle.com> <5114220B.10100@oracle.com>
<511435B5.4080308@oracle.com> <5114393E.4000503@oracle.com>
<51391FAE.7020307@oracle.com>
Message-ID: <5139267E.2010207@oracle.com>
Thanks Stuart, I'm investigating below tests, they failed on windows due
to RFR 7900051.
http://sqeweb.us.oracle.com/jsn/nightly/reg/test_stabilization/2013_01_07/win_ken/run_156/testoutput/jdk_lang/JTwork/sun/misc/EscapePath.jtr
http://sqeweb.us.oracle.com/jsn/nightly/reg/test_stabilization/2013_01_07/win_sandeep/run_107/testoutput/jdk_jfr/JTwork/closed/com/oracle/jfr/startupargs/OptionsTest/TestDefaultRecordingDisabled.jtr
http://sqeweb.us.oracle.com/jsn/nightly/reg/test_stabilization/2013_01_07/win_ken/run_305/testoutput/jdk_io/JTwork/java/io/File/SetLastModified.jtr
http://sqeweb.us.oracle.com/jsn/nightly/reg/test_stabilization/2013_01_07/win_ken/run_37/testoutput/jdk_jfr/JTwork/closed/com/oracle/jfr/startupargs/OptionsTest/TestGlobalBufferSize.jtr
http://sqeweb.us.oracle.com/jsn/nightly/reg/test_stabilization/2013_01_07/win_ken/run_11/testoutput/jdk_net/JTwork/java/net/URLClassLoader/closetest/GetResourceAsStream.jtr
http://sqeweb.us.oracle.com/jsn/nightly/reg/test_stabilization/2013_01_07/win_ken/run_11/testoutput/jdk_net/JTwork/java/net/URLClassLoader/closetest/CloseTest.jtr
-Eric
On 2013/3/8 7:15, Stuart Marks wrote:
> Hi, did this ever get pushed?
>
> Eric Wang was diagnosing intermittent test failures and he was running
> into problems where a test would pass but jtreg would fail it
> after-the-fact when it was unable to clean up the scratch directory. I
> think those failures might be helped by Jim's cleanup change.
>
> s'marks
>
> On 2/7/13 3:31 PM, Jonathan Gibbons wrote:
>> I've not looked at this round of changes, but I will, and will push
>> them if
>> they're OK.
>>
>> -- Jon
>>
>> On 02/07/2013 03:16 PM, Jim Gish wrote:
>>> All I had to do was look at the subject of my own message, didn't
>>> I? It's
>>> been one of those crazy days:-( Thanks.
>>>
>>> Do the changes look ok? If so, could you push them, please? (I
>>> updated the
>>> commit message and attached a proper patch).
>>>
>>> Jim
>>>
>>> On 02/07/2013 04:52 PM, Jonathan Gibbons wrote:
>>>> 7900051 is a CODETOOLS bug, isn't it?
>>>>
>>>> -- Jon
>>>>
>>>>
>>>> On 02/07/2013 01:33 PM, Jim Gish wrote:
>>>>> Thanks, Jonathan -- I made your suggested changes. Please
>>>>> re-review. I
>>>>> suppose we need a code-tools bug for this don't we?
>>>>>
>>>>> Thanks,
>>>>> Jim
>>>>>
>>>>> http://cr.openjdk.java.net/~jgish/Bug7900051-DeleteRetry/
>>>>>
>>>>>
>>>>> On 02/06/2013 09:25 PM, Jonathan Gibbons wrote:
>>>>>> Also, notice the inconsistent order of words in
>>>>>>
>>>>>> 111 RETRY_DELETE_DELAY_MSEC = isWindows ? 500 : 0;
>>>>>> 112 MAX_DELETE_RETRY_SECONDS = isWindows ? 30 : 0;
>>>>>> I guess I would expect to see MAX_ be a prefix to what it is a
>>>>>> max of, such as
>>>>>> MAX_RETRY_DELETE_SECONDS
>>>>>>
>>>>>> Also, it's not clear to me that it helps to change units,
>>>>>> especially given
>>>>>> the silly slip you had in the code that I mentioned earlier.
>>>>>> Why not
>>>>>> keep all times consistently in the same units, presumably MSEC?
>>>>>>
>>>>>> -- Jon
>>>>>>
>>>>>>
>>>>>> On 02/06/2013 06:20 PM, Jonathan Gibbons wrote:
>>>>>>> Jim,
>>>>>>>
>>>>>>> Sorry for the delay; thanks for the reminder.
>>>>>>>
>>>>>>> To get from milliseconds to seconds, you divide by 1000, not
>>>>>>> multiply by
>>>>>>> it ;-) In two places.
>>>>>>>
>>>>>>> I don't think you should log messages about deleting files. Some
>>>>>>> tests
>>>>>>> generate *lots* of files, and it would be unacceptable to report
>>>>>>> them
>>>>>>> being deleted, one by one. I can see that occasionally you
>>>>>>> might want
>>>>>>> to see this level of details, but it should be enabled by setting a
>>>>>>> system property such as javatest.regtest.showDeleteFiles and
>>>>>>> should be
>>>>>>> off by default. Reporting issues when files cannot be deleted,
>>>>>>> such as
>>>>>>> ScratchDirectory.java:191(new) is acceptable.
>>>>>>>
>>>>>>> -- Jon
>>>>>>>
>>>>>>>
>>>>>>> On 02/06/2013 09:22 AM, Jim Gish wrote:
>>>>>>>> I haven't heard back on this one yet. Any comments?
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Jim
>>>>>>>>
>>>>>>>> On 01/23/2013 04:24 PM, Jim Gish wrote:
>>>>>>>>> Please review:
>>>>>>>>> http://cr.openjdk.java.net/~jgish/Bug7900051-DeleteRetry/
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Summary: this change adds delete retry logic on Windows
>>>>>>>>> similar to that
>>>>>>>>> that is already there on init. It also consolidates the delete
>>>>>>>>> methods. Instead of trying some N times with Delta msec. delay in
>>>>>>>>> between, it now tries for up to 30 seconds with Delta (500
>>>>>>>>> msec) delay
>>>>>>>>> in between.
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Jim
>>>>>>>>> --
>>>>>>>>> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
>>>>>>>>> Oracle Java Platform Group | Core Libraries Team
>>>>>>>>> 35 Network Drive
>>>>>>>>> Burlington, MA 01803
>>>>>>>>> jim.gish at oracle.com
>>>>>>>>
>>>>>>>> --
>>>>>>>> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
>>>>>>>> Oracle Java Platform Group | Core Libraries Team
>>>>>>>> 35 Network Drive
>>>>>>>> Burlington, MA 01803
>>>>>>>> jim.gish at oracle.com
>>>>>>>
>>>>>>
>>>>>
>>>>> --
>>>>> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
>>>>> Oracle Java Platform Group | Core Libraries Team
>>>>> 35 Network Drive
>>>>> Burlington, MA 01803
>>>>> jim.gish at oracle.com
>>>>
>>>
>>> --
>>> Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
>>> Oracle Java Platform Group | Core Libraries Team
>>> 35 Network Drive
>>> Burlington, MA 01803
>>> jim.gish at oracle.com
>>