From jonathan.gibbons at oracle.com Mon Aug 3 18:51:46 2015 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 03 Aug 2015 18:51:46 +0000 Subject: hg: code-tools/jtreg: 7901474: Field 'fired' in Alarm should be marked volatile Message-ID: <201508031851.t73IplsQ001285@aojmv0008.oracle.com> Changeset: 160e00964cdf Author: sla Date: 2015-08-03 11:50 -0700 URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/160e00964cdf 7901474: Field 'fired' in Alarm should be marked volatile ! src/share/classes/com/sun/javatest/regtest/agent/Alarm.java From jonathan.gibbons at oracle.com Tue Aug 4 02:17:44 2015 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 04 Aug 2015 02:17:44 +0000 Subject: hg: code-tools/jtreg: 7901477: Remove support for "samevm" mode Message-ID: <201508040217.t742HiUY007447@aojmv0008.oracle.com> Changeset: 08fa519e5384 Author: jjg Date: 2015-08-03 19:17 -0700 URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/08fa519e5384 7901477: Remove support for "samevm" mode ! make/tests/AutoVMTests.gmk ! make/tests/BadTests.gmk ! make/tests/Basic.gmk ! make/tests/CPAppendTests.gmk ! make/tests/CleanupTest.gmk ! make/tests/ExcludeTest.gmk ! make/tests/IgnoreSymbolFileTest.gmk ! make/tests/JDK11Test.gmk ! make/tests/JavacExitCodeTests.gmk ! make/tests/JavacTests.gmk ! make/tests/MultiRunTest.gmk ! make/tests/OpenFileTests.gmk ! make/tests/ProblemList.gmk ! make/tests/PropertyTests.gmk ! make/tests/RerunTest.gmk ! make/tests/SecurityManagerTests.gmk ! make/tests/SecurityProviderTest.gmk ! make/tests/StatsTests.gmk ! make/tests/T4730538.gmk ! make/tests/T6517728.gmk ! make/tests/T6517916.gmk ! make/tests/T6519296.gmk ! make/tests/T6533136.gmk ! make/tests/TestNativePath.gmk ! make/tests/TestVMOpts.gmk ! make/tests/TestWhiteSpaceFiles.gmk ! make/tests/TimelimitTests.gmk ! make/tests/TimeoutHandlerTest.gmk ! make/tests/TimeoutTest.gmk ! make/tests/jcov.gmk ! src/share/classes/com/sun/javatest/regtest/CompileAction.java ! src/share/classes/com/sun/javatest/regtest/DriverAction.java ! src/share/classes/com/sun/javatest/regtest/JDK.java ! src/share/classes/com/sun/javatest/regtest/Main.java ! src/share/classes/com/sun/javatest/regtest/MainAction.java ! src/share/classes/com/sun/javatest/regtest/RegressionScript.java ! src/share/classes/com/sun/javatest/regtest/ScratchDirectory.java ! src/share/classes/com/sun/javatest/regtest/i18n.properties ! src/share/test/javatest/regtest/RetainTest.java - src/share/test/javatest/regtest/data/rerun/std/AppletTest.samevm.out - src/share/test/javatest/regtest/data/rerun/std/BuildTest.samevm.out - src/share/test/javatest/regtest/data/rerun/std/CleanTest.samevm.out - src/share/test/javatest/regtest/data/rerun/std/CompileTest.samevm.out - src/share/test/javatest/regtest/data/rerun/std/IgnoreTest.samevm.out - src/share/test/javatest/regtest/data/rerun/std/JUnitTest.samevm.out - src/share/test/javatest/regtest/data/rerun/std/MainTest.samevm.out - src/share/test/javatest/regtest/data/rerun/std/ShellTest.samevm.out - src/share/test/javatest/regtest/data/rerun/std/TestNGTest.samevm.out - src/share/test/javatest/regtest/data/rerun/testng/TestNGTest.samevm.out ! src/share/test/javatest/regtest/data/vmopts/build.xml From jonathan.gibbons at oracle.com Thu Aug 6 00:15:21 2015 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 06 Aug 2015 00:15:21 +0000 Subject: hg: code-tools/jtreg: clean up arg file handling Message-ID: <201508060015.t760FLRr022927@aojmv0008.oracle.com> Changeset: 2f4dfe2d0d67 Author: jjg Date: 2015-08-05 17:14 -0700 URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/2f4dfe2d0d67 clean up arg file handling ! src/share/classes/com/sun/javatest/regtest/Action.java ! src/share/classes/com/sun/javatest/regtest/AppletAction.java ! src/share/classes/com/sun/javatest/regtest/CompileAction.java ! src/share/classes/com/sun/javatest/regtest/Locations.java ! src/share/classes/com/sun/javatest/regtest/MainAction.java ! src/share/classes/com/sun/javatest/regtest/RegressionScript.java ! src/share/test/javatest/regtest/RetainTest.java ! src/share/test/javatest/regtest/data/rerun/std/AppletTest.agentvm.out ! src/share/test/javatest/regtest/data/rerun/std/AppletTest.othervm.out ! src/share/test/javatest/regtest/data/rerun/std/JUnitTest.othervm.out ! src/share/test/javatest/regtest/data/rerun/std/MainTest.othervm.out ! src/share/test/javatest/regtest/data/rerun/std/TestNGTest.othervm.out ! src/share/test/javatest/regtest/data/rerun/testng/TestNGTest.othervm.out From weijun.wang at oracle.com Wed Aug 26 16:06:36 2015 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 27 Aug 2015 00:06:36 +0800 Subject: "Error: Group is invalid" if there are non-existing directories Message-ID: <55DDE40C.3020403@oracle.com> I've just updated my local jtreg to 4.1 b12 and noticed a difference. When working on a bug I had the habit to create a new repo for it and remove unrelated tests, so when I call "make jdk_security4" it will run much faster. This worked fine but with b12 if a directory is missing I will see an error .../jdk/test/TEST.groups: group jdk_security4: file not found: com/sun/security/jgss Error: Group is invalid: jdk_security4 Is this necessary? On the other hand, even if jdk_security includes jdk_security4, running make on it does not fail immediately. Thanks Max From jonathan.gibbons at oracle.com Wed Aug 26 16:28:49 2015 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 26 Aug 2015 09:28:49 -0700 Subject: "Error: Group is invalid" if there are non-existing directories In-Reply-To: <55DDE40C.3020403@oracle.com> References: <55DDE40C.3020403@oracle.com> Message-ID: <55DDE941.1010408@oracle.com> On 08/26/2015 09:06 AM, Weijun Wang wrote: > I've just updated my local jtreg to 4.1 b12 and noticed a difference. > > When working on a bug I had the habit to create a new repo for it and > remove unrelated tests, so when I call "make jdk_security4" it will > run much faster. This worked fine but with b12 if a directory is > missing I will see an error > > .../jdk/test/TEST.groups: group jdk_security4: file not found: > com/sun/security/jgss > Error: Group is invalid: jdk_security4 > > Is this necessary? > > On the other hand, even if jdk_security includes jdk_security4, > running make on it does not fail immediately. > > Thanks > Max Max, It is hard to distinguish between mistyped pathnames and deliberately-missing directories, and I would prefer to go with the more generally useful case of catching mistyped pathnames. Do you really need to remove tests? Surely there are enough selection mechanisms in jtreg for you to select the tests you want? If you're prepared to "hack" the repo by removing files, why not just add in a temporary group called "my_tests" instead? -- Jon From weijun.wang at oracle.com Fri Aug 28 00:35:40 2015 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 28 Aug 2015 08:35:40 +0800 Subject: How to write test requiring a specific locale? Message-ID: <55DFACDC.3080203@oracle.com> Hi All In https://bugs.openjdk.java.net/browse/JDK-8133910, the test tries to grep certain text from tool output, but when the default locale is not "en_US" it might fail. I don't want to rewrite the test to check localized text so there are only 2 ways: 1. Force the text to run with "en_US". In Unix, seems setting LANG or LC_ALL to "en_US.UTF-8" (these are script tests), but it does not work on Windows. I can only think of adding "-J-Duser.language=en -J-Duser.country=US" into TESTTOOLVMOPTS. 2. Ignore the text when locale is not en_US. The @requires tag does not support user.encoding. Shall I check $LANG or $LC_ALL? Should they contain "en_US" on most test machines? Or it's "C"? Thanks Max From weijun.wang at oracle.com Mon Aug 31 02:07:57 2015 From: weijun.wang at oracle.com (Wang Weijun) Date: Mon, 31 Aug 2015 10:07:57 +0800 Subject: "Error: Group is invalid" if there are non-existing directories In-Reply-To: <55DDE941.1010408@oracle.com> References: <55DDE40C.3020403@oracle.com> <55DDE941.1010408@oracle.com> Message-ID: <8E1F0C88-E4C9-476A-8BDB-6C697947B37E@oracle.com> > On Aug 27, 2015, at 12:28 AM, Jonathan Gibbons wrote: > > It is hard to distinguish between mistyped pathnames and deliberately-missing directories, and I would prefer to go with the more generally useful case of catching mistyped pathnames. I see. > > Do you really need to remove tests? Surely there are enough selection mechanisms in jtreg for you to select the tests you want? If you're prepared to "hack" the repo by removing files, why not just add in a temporary group called "my_tests" instead? OK. Or I can just hack the definition of jdk_security4 itself. Ever since JPRT does not recognize -rtests I have to use -otests. ?Max