jtreg-dev Digest, Vol 33, Issue 1
Mani Sarkar
sadhak001 at gmail.com
Mon Aug 1 22:21:05 UTC 2016
Hi Jon,
Thanks for the JTRegModuleHelper fix in the latest version of jtreg,
latest build at https://adopt-openjdk.ci.cloudbees.com/job/jtreg/ has the
appropriate class included.
Cheers
Mani
On Mon, 1 Aug 2016 21:18 , <jtreg-dev-request at openjdk.java.net> wrote:
> Send jtreg-dev mailing list submissions to
> jtreg-dev at openjdk.java.net
>
> To subscribe or unsubscribe via the World Wide Web, visit
> http://mail.openjdk.java.net/mailman/listinfo/jtreg-dev
> or, via email, send a message with subject or body 'help' to
> jtreg-dev-request at openjdk.java.net
>
> You can reach the person managing the list at
> jtreg-dev-owner at openjdk.java.net
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of jtreg-dev digest..."
>
>
> Today's Topics:
>
> 1. hg: code-tools/jtreg: add missing file
> (jonathan.gibbons at oracle.com)
> 2. hg: code-tools/jtreg: 7901667: Enhance library support in
> TEST.properties (jonathan.gibbons at oracle.com)
> 3. Re: [rfc] more benevolent java version check (Jonathan Gibbons)
> 4. hg: code-tools/jtreg: remove obsolete make rules
> (jonathan.gibbons at oracle.com)
> 5. hg: code-tools/jtreg: 7901750: more benevolent java version
> check (jonathan.gibbons at oracle.com)
> 6. Re: [rfc] more benevolent java version check (Jonathan Gibbons)
> 7. hg: code-tools/jtreg: 7901747: jtreg treats TestNG Skip
> status as failure. (jonathan.gibbons at oracle.com)
> 8. Re: [rfc] more benevolent java version check (Jiri Vanek)
> 9. Re: [rfc] more benevolent java version check (Jiri Vanek)
> 10. hg: code-tools/jtreg: compile JTRegModuleHelper in Ant build
> (jonathan.gibbons at oracle.com)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Fri, 29 Jul 2016 22:16:25 +0000
> From: jonathan.gibbons at oracle.com
> To: jtreg-dev at openjdk.java.net
> Subject: hg: code-tools/jtreg: add missing file
> Message-ID: <201607292216.u6TMGPcE017567 at aojmv0008.oracle.com>
>
> Changeset: 5579e5a08111
> Author: jjg
> Date: 2016-07-29 15:16 -0700
> URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/5579e5a08111
>
> add missing file
>
> + src/share/classes/com/sun/javatest/regtest/agent/Flags.java
>
>
>
> ------------------------------
>
> Message: 2
> Date: Sat, 30 Jul 2016 00:44:33 +0000
> From: jonathan.gibbons at oracle.com
> To: jtreg-dev at openjdk.java.net
> Subject: hg: code-tools/jtreg: 7901667: Enhance library support in
> TEST.properties
> Message-ID: <201607300044.u6U0iXGX016374 at aojmv0008.oracle.com>
>
> Changeset: fd9206d1a256
> Author: jjg
> Date: 2016-07-29 17:44 -0700
> URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/fd9206d1a256
>
> 7901667: Enhance library support in TEST.properties
>
> + make/tests/LibBuildArgsTest.gmk
> ! src/share/classes/com/sun/javatest/regtest/Locations.java
> ! src/share/classes/com/sun/javatest/regtest/RegressionScript.java
> ! src/share/classes/com/sun/javatest/regtest/RegressionTestFinder.java
> ! src/share/classes/com/sun/javatest/regtest/RegressionTestSuite.java
> ! src/share/classes/com/sun/javatest/regtest/TestNGAction.java
> ! src/share/classes/com/sun/javatest/regtest/TestProperties.java
> ! src/share/doc/javatest/regtest/tag-spec.html
> ! src/share/test/javatest/regtest/InterruptTest.java
> + src/share/test/javatest/regtest/data/libBuildArgs/TEST.ROOT
> +
> src/share/test/javatest/regtest/data/libBuildArgs/bad/LibBuildArgsTest.java
> + src/share/test/javatest/regtest/data/libBuildArgs/bad/TEST.properties
> +
> src/share/test/javatest/regtest/data/libBuildArgs/good/LibBuildArgsTest.java
> + src/share/test/javatest/regtest/data/libBuildArgs/good/TEST.properties
> + src/share/test/javatest/regtest/data/libBuildArgs/lib/bad/Bad1.java
> + src/share/test/javatest/regtest/data/libBuildArgs/lib/bad/Bad2.java
> + src/share/test/javatest/regtest/data/libBuildArgs/lib/good/Good1.java
> + src/share/test/javatest/regtest/data/libBuildArgs/lib/good/Good2.java
> + src/share/test/javatest/regtest/data/libBuildArgs/lib/mixed/Bad.java
> + src/share/test/javatest/regtest/data/libBuildArgs/lib/mixed/Good.java
>
>
>
> ------------------------------
>
> Message: 3
> Date: Fri, 29 Jul 2016 18:04:28 -0700
> From: Jonathan Gibbons <jonathan.gibbons at oracle.com>
> To: jtreg-dev at openjdk.java.net
> Subject: Re: [rfc] more benevolent java version check
> Message-ID: <579BFD1C.5000509 at oracle.com>
> Content-Type: text/plain; charset=utf-8; format=flowed
>
> Jiri,
>
> Your patch is against quite an old version of the class, but I
> understand what you are trying to do, and so I'll look at making the
> current code be more tolerant of JAVA_TOOL_OPTIONS
>
> -- Jon
>
> On 07/29/2016 01:57 AM, Jiri Vanek wrote:
> > ping please?
> >
> > J.
> > On 07/27/2016 08:28 PM, Jiri Vanek wrote:
> >> Hello!
> >>
> >> Please accept attached patch which is making java version check for
> >> other vm more bullet proof.
> >>
> >> Originally, the java version was strictly expecting the searched item
> >> on first line.
> >> However, when eg $JAVA_TOOL_OPTIONS is used, the output of forked
> >> process got messy. EG:
> >>
> >> java -version
> >> Picked up JAVA_TOOL_OPTIONS: -XX:+UseShenandoahGC
> >> OpenJDK 64-Bit Server VM warning: Compressed Oops not supported with
> >> ShenandoahGC
> >> ....
> >>
> >> My patch is making the usage of JAVA_TOOL_OPTIONS possible, as it is
> >> searching the output of forked
> >> process by key.
> >>
> >>
> >> Tahnx!
> >>
> >> J.
> >>
> >> benevolent_java_version.patch
> >>
> >>
> >> diff -r 7906b5ebfc75 src/share/classes/com/sun/javatest/regtest/JDK.java
> >> --- a/src/share/classes/com/sun/javatest/regtest/JDK.java Thu Apr
> >> 16 17:45:57 2015 -0700
> >> +++ b/src/share/classes/com/sun/javatest/regtest/JDK.java Wed Jul
> >> 27 20:23:30 2016 +0200
> >> @@ -150,9 +150,15 @@
> >> String out = getOutput(p);
> >> int rc = p.waitFor();
> >> if (rc == 0) {
> >> - String[] v =
> >> StringUtils.splitEqual(out.trim());
> >> - if (v.length == 2 &&
> >> v[0].equals(VERSION_PROPERTY))
> >> - version = v[1];
> >> + String[] outs=out.split("\n");
> >> + for (String line : outs) {
> >> + System.out.println(line);
> >> + String[] v =
> >> StringUtils.splitEqual(line.trim());
> >> + if (v.length == 2 &&
> >> v[0].equals(VERSION_PROPERTY)) {
> >> + version = v[1];
> >> + break;
> >> + }
> >> + }
> >> }
> >> } catch (InterruptedException e) {
> >> // ignore, leave version as default
> >>
> >
>
>
>
> ------------------------------
>
> Message: 4
> Date: Sat, 30 Jul 2016 01:30:48 +0000
> From: jonathan.gibbons at oracle.com
> To: jtreg-dev at openjdk.java.net
> Subject: hg: code-tools/jtreg: remove obsolete make rules
> Message-ID: <201607300130.u6U1UmZl025126 at aojmv0008.oracle.com>
>
> Changeset: 720dd7793cea
> Author: jjg
> Date: 2016-07-29 17:55 -0700
> URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/720dd7793cea
>
> remove obsolete make rules
>
> ! make/jtreg.gmk
> - make/tests/NoJUnit.gmk
>
>
>
> ------------------------------
>
> Message: 5
> Date: Sat, 30 Jul 2016 01:37:42 +0000
> From: jonathan.gibbons at oracle.com
> To: jtreg-dev at openjdk.java.net
> Subject: hg: code-tools/jtreg: 7901750: more benevolent java version
> check
> Message-ID: <201607300137.u6U1bgd0026160 at aojmv0008.oracle.com>
>
> Changeset: 3f9d1b865d72
> Author: jjg
> Date: 2016-07-29 18:37 -0700
> URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/3f9d1b865d72
>
> 7901750: more benevolent java version check
> Based on contribution from jvanek at redhat.com
>
> ! src/share/classes/com/sun/javatest/regtest/JDK.java
>
>
>
> ------------------------------
>
> Message: 6
> Date: Fri, 29 Jul 2016 18:38:51 -0700
> From: Jonathan Gibbons <jonathan.gibbons at oracle.com>
> To: jtreg-dev at openjdk.java.net
> Subject: Re: [rfc] more benevolent java version check
> Message-ID: <579C052B.4040103 at oracle.com>
> Content-Type: text/plain; charset=utf-8; format=flowed
>
> https://bugs.openjdk.java.net/browse/CODETOOLS-7901750
>
> now fixed.
>
> On 07/27/2016 11:28 AM, Jiri Vanek wrote:
> > Hello!
> >
> > Please accept attached patch which is making java version check for
> > other vm more bullet proof.
> >
> > Originally, the java version was strictly expecting the searched item
> > on first line.
> > However, when eg $JAVA_TOOL_OPTIONS is used, the output of forked
> > process got messy. EG:
> >
> > java -version
> > Picked up JAVA_TOOL_OPTIONS: -XX:+UseShenandoahGC
> > OpenJDK 64-Bit Server VM warning: Compressed Oops not supported with
> > ShenandoahGC
> > ....
> >
> > My patch is making the usage of JAVA_TOOL_OPTIONS possible, as it is
> > searching the output of forked process by key.
> >
> >
> > Tahnx!
> >
> > J.
>
>
>
> ------------------------------
>
> Message: 7
> Date: Sat, 30 Jul 2016 02:15:28 +0000
> From: jonathan.gibbons at oracle.com
> To: jtreg-dev at openjdk.java.net
> Subject: hg: code-tools/jtreg: 7901747: jtreg treats TestNG Skip
> status as failure.
> Message-ID: <201607300215.u6U2FSW8004085 at aojmv0008.oracle.com>
>
> Changeset: 939e604a94a2
> Author: jjg
> Date: 2016-07-29 19:15 -0700
> URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/939e604a94a2
>
> 7901747: jtreg treats TestNG Skip status as failure.
>
> ! src/share/classes/com/sun/javatest/regtest/TestNGAction.java
>
>
>
> ------------------------------
>
> Message: 8
> Date: Sat, 30 Jul 2016 14:35:45 +0200
> From: Jiri Vanek <jvanek at redhat.com>
> To: Jonathan Gibbons <jonathan.gibbons at oracle.com>,
> jtreg-dev at openjdk.java.net
> Subject: Re: [rfc] more benevolent java version check
> Message-ID: <d4aa95da-0283-f81f-ec07-6e4bee81a773 at redhat.com>
> Content-Type: text/plain; charset=utf-8; format=flowed
>
> On 07/30/2016 03:38 AM, Jonathan Gibbons wrote:
> > https://bugs.openjdk.java.net/browse/CODETOOLS-7901750
> >
> > now fixed.
>
>
> That was quick :)
> TYVM!
> J.
>
> >
> > On 07/27/2016 11:28 AM, Jiri Vanek wrote:
> >> Hello!
> >>
> >> Please accept attached patch which is making java version check for
> other vm more bullet proof.
> >>
> >> Originally, the java version was strictly expecting the searched item
> on first line.
> >> However, when eg $JAVA_TOOL_OPTIONS is used, the output of forked
> process got messy. EG:
> >>
> >> java -version
> >> Picked up JAVA_TOOL_OPTIONS: -XX:+UseShenandoahGC
> >> OpenJDK 64-Bit Server VM warning: Compressed Oops not supported with
> ShenandoahGC
> >> ....
> >>
> >> My patch is making the usage of JAVA_TOOL_OPTIONS possible, as it is
> searching the output of
> >> forked process by key.
> >>
> >>
> >> Tahnx!
> >>
> >> J.
> >
>
>
>
> ------------------------------
>
> Message: 9
> Date: Sat, 30 Jul 2016 14:44:33 +0200
> From: Jiri Vanek <jvanek at redhat.com>
> To: Jonathan Gibbons <jonathan.gibbons at oracle.com>,
> jtreg-dev at openjdk.java.net, issues at adoptopenjdk.java.net
> Subject: Re: [rfc] more benevolent java version check
> Message-ID: <b3907b04-a32a-cc8f-b5cd-77eb4bc589f4 at redhat.com>
> Content-Type: text/plain; charset=utf-8; format=flowed
>
> Ouch.
> It looks like jenkins build is stuck since 25th jul.
>
> https://adopt-openjdk.ci.cloudbees.com/job/jtreg/scmPollLog/
>
> Started on Jul 29, 2016 9:12:00 PM
> ERROR: Failed to record SCM polling for
> hudson.model.FreeStyleProject at 710a47ff[jtreg]
> java.lang.UnsupportedOperationException
> at
> com.cloudbees.hudson.model.PsuedoNode.createLauncher(PsuedoNode.java:77)
> at
> hudson.tools.JDKInstaller.performInstallation(JDKInstaller.java:143)
> at
> hudson.tools.InstallerTranslator.getToolHome(InstallerTranslator.java:68)
> at
> hudson.tools.ToolLocationNodeProperty.getToolHome(ToolLocationNodeProperty.java:108)
> at
> hudson.tools.ToolInstallation.translateFor(ToolInstallation.java:206)
> at hudson.model.JDK.forNode(JDK.java:143)
> at
> hudson.model.AbstractProject.getEnvironment(AbstractProject.java:357)
> at
> hudson.model.AbstractProject.pollWithWorkspace(AbstractProject.java:1460)
> at hudson.model.AbstractProject._poll(AbstractProject.java:1438)
> at hudson.model.AbstractProject.poll(AbstractProject.java:1349)
> at
> hudson.triggers.SCMTrigger$Runner.runPolling(SCMTrigger.java:526)
> at hudson.triggers.SCMTrigger$Runner.run(SCMTrigger.java:555)
> at
> hudson.util.SequentialExecutionQueue$QueueEntry.run(SequentialExecutionQueue.java:119)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
>
> J:(
>
> On 07/30/2016 02:35 PM, Jiri Vanek wrote:
> > On 07/30/2016 03:38 AM, Jonathan Gibbons wrote:
> >> https://bugs.openjdk.java.net/browse/CODETOOLS-7901750
> >>
> >> now fixed.
> >
> >
> > That was quick :)
> > TYVM!
> > J.
> >
> >>
> >> On 07/27/2016 11:28 AM, Jiri Vanek wrote:
> >>> Hello!
> >>>
> >>> Please accept attached patch which is making java version check for
> other vm more bullet proof.
> >>>
> >>> Originally, the java version was strictly expecting the searched item
> on first line.
> >>> However, when eg $JAVA_TOOL_OPTIONS is used, the output of forked
> process got messy. EG:
> >>>
> >>> java -version
> >>> Picked up JAVA_TOOL_OPTIONS: -XX:+UseShenandoahGC
> >>> OpenJDK 64-Bit Server VM warning: Compressed Oops not supported with
> ShenandoahGC
> >>> ....
> >>>
> >>> My patch is making the usage of JAVA_TOOL_OPTIONS possible, as it is
> searching the output of
> >>> forked process by key.
> >>>
> >>>
> >>> Tahnx!
> >>>
> >>> J.
> >>
> >
>
>
>
> ------------------------------
>
> Message: 10
> Date: Mon, 01 Aug 2016 20:18:45 +0000
> From: jonathan.gibbons at oracle.com
> To: jtreg-dev at openjdk.java.net
> Subject: hg: code-tools/jtreg: compile JTRegModuleHelper in Ant build
> Message-ID: <201608012018.u71KIk5Y025857 at aojmv0008.oracle.com>
>
> Changeset: fce2955d1b7b
> Author: jjg
> Date: 2016-08-01 13:18 -0700
> URL: http://hg.openjdk.java.net/code-tools/jtreg/rev/fce2955d1b7b
>
> compile JTRegModuleHelper in Ant build
>
> ! make/build.xml
>
>
>
> End of jtreg-dev Digest, Vol 33, Issue 1
> ****************************************
>
--
@theNeomatrix369 <http://twitter.com/theNeomatrix369>* | **Blog
<http://neomatrix369.wordpress.com/>** | *LJC Associate & LJC Advocate
(@adoptopenjdk & @adoptajsr programs)
*Meet-a-Project - *MutabilityDetector
<https://github.com/MutabilityDetector>* | **Bitbucket
<https://bitbucket.org/neomatrix369>* * | **Github
<https://github.com/neomatrix369>* * | **LinkedIn
<http://uk.linkedin.com/pub/mani-sarkar/71/a77/39b>*
*Come to Devoxx UK 2016:* http://www.devoxx.co.uk/
*Don't chase success, rather aim for "Excellence", and success will come
chasing after you!*
More information about the jtreg-dev
mailing list