ant seems to be using wrong defaults source/target and so making the adop-openjdk readme-incompatible

[Jiri Vanek]

On 08/11/2016 04:25 AM, Jonathan Gibbons wrote:
> http://hg.openjdk.java.net/code-tools/jtreg/rev/5af630cbe724
>
> -- Jon
>


Thank you very much,
  You are kind.

       J.

> On 08/10/2016 06:02 AM, Jiri Vanek wrote:
>> ping?
>>
>> May somebody pls review the one linner?
>>
>> best regards from cz and ty in advance,
>>   J.
>> On 08/08/2016 09:17 PM, Jiri Vanek wrote:
>>> Hello!
>>>
>>> Although changeset
>>> http://hg.openjdk.java.net/code-tools/jtreg/rev/9664f5b2338c
>>> clearly says "7901611: jtreg should use JDK 7 as a baseline for executing jtreg itself"
>>>
>>> It is actually enforcing 1.8... for ant.
>>>
>>>
>>> As readme: http://hg.openjdk.java.net/code-tools/jtreg/file/644163a82cae/README#l23 specifies the
>>> same, I believe
>>>
>>> --- a/make/build.xml    Mon Aug 01 14:01:29 2016 -0700
>>> +++ b/make/build.xml    Mon Aug 08 21:14:37 2016 +0200
>>> @@ -171,7 +171,7 @@
>>>
>>>      <target name="-compile-jtreg.classes">
>>>          <mkdir dir="${build.classes.dir}"/>
>>> -        <javac encoding="iso-8859-1" source="1.8" target="1.8"
>>> +        <javac encoding="iso-8859-1" source="1.7" target="1.7"
>>>              debug="true" debuglevel="source,lines"
>>>              srcdir="${src.classes.dir}"
>>>              destdir="${build.classes.dir}"
>>>
>>>
>>>
>>> should be used.
>>>
>>>
>>> I confess I did not tried the patch, but from nowhere else the values
>>> [ https://adopt-openjdk.ci.cloudbees.com/job/jtreg/624/consoleFull ]
>>>
>>>   [javac] '-sourcepath'
>>>     [javac] '/scratch/jenkins/workspace/jtreg/src/share/classes'
>>>     [javac] '-target'
>>>     [javac] '1.8'
>>>     [javac] '-encoding'
>>>     [javac] 'iso-8859-1'
>>>     [javac] '-g:source,lines'
>>>     [javac] '-Xlint:all'
>>>     [javac] '-source'
>>>     [javac] '1.8'
>>>
>>>
>>>
>>> Currently the sad fact is, that binaries from adopt-openjdk are incompatible with thirs own
>>> statement - jdk8 only.
>>
>