RFC: add starred module(s)

[Jiri Vanek]

ping?
On 12/05/2017 11:01 AM, Jiri Vanek wrote:
> Hi Jonathan!
> 
> I think this proposal have quite a sense.  I was moving our old jtreg tests to work with jdk9 too, 
> and copy pasting on module level is terrible.
> 
> This proposal is cool. It is keeping encapsulation in place and lowering the writing a lot.
> I would go even more deep, eg " @modules all-needed", and jtreg will deduct necessary --add-whatever 
> on its own.
> 
> The shell part is even more worse. And especially the shell part is where jtreg is hard to replace 
> (read: I like jtreg here very much :) )
> Here you get only TESTMODULES variable which is not enough, and (unlike in java file) it is here 
> even for jdk8 and older.
> So maybe there can be one more variable, containing full  --add-whatever string  which got filled 
> only for modular jdk?
> 
> I will be happy to implement those features if you agree with the principle.
> 
> 
> Thanx!
>    J.
> 
> 
> 
> On 11/30/2017 02:21 PM, Miloslav Zezulka wrote:
>> Hello,
>>
>> when working with @modules tag, it might be sometimes beneficial to have
>> the ability to open multiple packages from the same parent using one
>> @modules tag only (for example via star notation as in regular java
>> imports). The idea came to my mind when modifying some CPU reproducers to
>> be compatible with JDK9. Let's consider a JTreg comment for one of them:
>>
>>   * ....
>>   * @modules java.security.jgss/sun.security.krb5.internal
>>   * @modules java.security.jgss/sun.security.krb5.internal.ccache
>>   * @modules java.security.jgss/sun.security.krb5.internal.crypto
>>   * @modules java.security.jgss/sun.security.krb5.internal.ktab
>>   * @modules java.base/sun.security.util
>>   * @modules java.security.jgss/sun.security.jgss
>>   */
>>
>> Although this has the advantage thta we explicitly know which internal
>> packages are being opened for the given test, someone might prefer to use
>> the @modules tag the folllowing way to make the JTreg comment more readable
>> and less wordier:
>>
>>   * ....
>>   * @modules java.security.jgss/sun.security.krb5.internal.*
>>   * @modules java.base/sun.security.util
>>   * @modules java.security.jgss/sun.security.jgss
>>   */
>>
>> As a JTreg newbie, I wasn't able to find such feature in the current
>> version. The attached patch is a draft of how this might be implemented.
>>
>> Thoughts?
>>
>> Thanks,
>> Míla
>>
> 
> 


-- 
Jiri Vanek
Senior QE engineer, OpenJDK QE lead, Mgr.
Red Hat Czech
jvanek at redhat.com    M: +420775390109