RFR(S): 7902351: jtreg evaluates ProblemList with properties of VM running jtreg

[Jonathan Gibbons]

Goetz,

I've reviewed the code, but I'm thinking to restructure it a bit so that 
the OS is available directly from the RegressionParams object instead of 
hidden inside the TestListWithPlatforms code. This means we would 
support params.getTestOS() alongside params.getTestJDK().  As minor 
points, I'm not sure I agree with the comment on 
RegressionParameters.java:344 (testrunner and testee are the same), and 
the error message on 339 should really go to System.err instead of 
System.out. Nevertheless, you have a good basis for a solution to this 
long-standing issue; I'll refactor your code a bit, and run it through 
the tests.

-- Jon



On 12/06/2018 04:02 AM, Lindenmaier, Goetz wrote:
> Great, thanks!
>
> Best regards,
>    Goetz.
>
>> -----Original Message-----
>> From: Jonathan Gibbons <jonathan.gibbons at oracle.com>
>> Sent: Mittwoch, 5. Dezember 2018 16:55
>> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; jtreg-
>> dev at openjdk.java.net
>> Subject: Re: RFR(S): 7902351: jtreg evaluates ProblemList with properties of
>> VM running jtreg
>>
>> Goetz,
>>
>> I'll review this and will sponsor the change.
>>
>> -- Jon
>>
>> On 12/5/18 12:02 AM, Lindenmaier, Goetz wrote:
>>> Hi,
>>>
>>> When evaluating the ProblemList specified with -exclude, jtreg compares
>> the platform specifiers as windows-i586 with the properties of the VM
>> running the jtreg harness. It does not use the properties of the VM specified
>> by -testvm which is the VM to be tested.
>>> Our testrunner is a 64-bit VM, that also tests 32-bit variants. Thus, if we
>> want to exclude a test for the 32-bit VM by specifying windows-i586, it is not
>> excluded. Instead, the ProbelmList is scanned for windows-amd64 excludes.
>>> Basic functionality to ask the testvm for its properties is already
>> implemented and just needs to be used in the proper place.
>>> This change also fixes a copy-and-paste error in OS.java.
>>>
>>> Please review. I please need a sponsor.
>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7902351
>>> http://cr.openjdk.java.net/~goetz/wr18/7902351-ProblemList-jtreg/01/
>>>
>>> Best regards,
>>>     Goetz.