RFC: add starred module(s)

Jonathan Gibbons jonathan.gibbons at oracle.com
Wed Feb 7 16:23:22 UTC 2018


Felix,

Generally, this is not a bad idea. jtreg supports library modules, 
although I'll be the first to admit there may be rough edges still to be 
discovered in the support.

-- Jon


On 2/6/18 5:51 PM, Felix Yang wrote:
> Hi Max,
>
>     I have another idea, how about make the test libs into JPMS 
> modules. Then the dependencies will be explicitly described at where 
> it happens. Any comment?
>
> -Felix
> On 2018/2/6 21:51, Weijun Wang wrote:
>> While I am not requesting for an automatic discovery of @module tags, 
>> I wonder if we can enhance jtreg from another angle to make test 
>> writing a little easier.
>>
>> The "@modules java.security.jgss/sun.security.krb5.*" example is 
>> painful because these --add-exports are not required by the tests 
>> themselves. Instead, it's a library class (KDC.java in the same 
>> directory) they are using that is accessing these internal classes. 
>> This explains why the @module tags appear in multiple tests but you 
>> won't see any of these tests importing a class in those packages.
>>
>> Think of this extreme example, suppose someone adds a reference to an 
>> internal class in ProcessTools.java, then suddenly all tests using it 
>> require a new @module tag.
>>
>> So, is it possible to add the @module tags to that library class?
>>
>> /*
>>   * @library
>>   * @module ....
>>   */
>>
>> Thanks
>> Max
>>
>



More information about the jtreg-dev mailing list