Bugfix: do not set TESTMODULES environment variable if JDK is not modular

[Zdeněk Žamberský]

On 02/12/2018 01:16 PM, Miloslav Zezulka wrote:
>> I have pushed a variant of your fix, along with spec updates and tests.
>> In a related fix, jtreg will now report a warning if the version of the
> compile JDK
>> does not match the version of the test JDK.
> Thanks!

I already tried to do Jtreg build with latest changes and I can confirm,
that TESTMODULES env. var. is now only exportedin shell tests,
when testing modular JDK.

When it comes to java jtreg tests it works as previously,
@modules tag makes them work on modular JDK,
but running them on non-modular JDK is still possible.

Thank you both.

>
> On Sat, Feb 10, 2018 at 1:31 AM, Jonathan Gibbons <
> jonathan.gibbons at oracle.com> wrote:
>
>> Mila,
>>
>> I have pushed a variant of your fix, along with spec updates and tests.
>> In a related fix, jtreg will now report a warning if the version of the
>> compile JDK
>> does not match the version of the test JDK.
>>
>> -- Jon
>>
>>
>>
>> On 12/15/2017 02:37 AM, Miloslav Zezulka wrote:
>>
>>> This is a very small patch fixing the issue pointed out in $subject. I've
>>> added checks for both compile and test JDK - is this an overkill, since
>>> most of the time the implication goes COMPILEJDK.modular =>
>>> TESTJDK.modular, or a necessary thing to have for foolproofness?
>>>
>>> Please let me know what you think.
>>>
>>> Thanks,
>>> Mila
>>>
>>

-- 
Zdeněk Žamberský
OpenJDK QE
Red Hat