RFR: CODETOOLS-7902373: Intellij jtreg plugin fails to resolve external libraries
Thomas Stüfe
thomas.stuefe at gmail.com
Tue Jan 29 14:06:33 UTC 2019
Greetings,
May I please have your opinions about the following fix:
bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7902373
cr:
http://cr.openjdk.java.net/~stuefe/webrevs/codetools-7902373--intellij-jtreg-plugin-fails-to-resolve-external-libraries/webrev.00/webrev/
jtreg tests containing references to external test libraries (e.g. @library
/test/lib) are not properly handled(e.g. jdk.test.lib.process.*), and
references to those test support classes will not be resolved and result in
red wiggly lines in Intellij. This affects mostly jtreg tests for the
hotspot, since those typically rely on /test/lib.
This patch causes the Intellij jtreg plugin properly recognize and handle
the external.lib.roots entry in the test suite configuration files. The
TEST.ROOT file for an opened source is parsed and the external library path
extracted. I am not sure whether this is the best way to go about it or
whether this is too expensive though. The parsing is only done for the
first file under a given TEST.ROOT, so it should be okay?
The plugin works for me, on a quite underpowered ultrabook. Note that I
also added a lot of logging, all debug level, to aid me in development. If
necessary I can remove it but would prefer not to.
Please note that I'm quite new to jtreg plugin development as well as to
the jtreg internals, so I may miss something obvious. Would appreciate it
if someone more knowledgeable reviews it (Maurizio?).
Thanks & Best Regards, Thomas
More information about the jtreg-dev
mailing list