RFR: 7902637: Use https://git.openjdk.java.net for CODE_TOOLS_URL

Erik Helin erik.helin at oracle.com
Wed Mar 11 16:58:23 UTC 2020


On 3/11/20 5:52 PM, Jonathan Gibbons wrote:
> Looks good to me.  Thanks for looking at this.

Thanks for reviewing Jon!
Erik

> -- Jon
> 
> On 3/11/20 9:47 AM, Erik Helin wrote:
>> Hi all,
>>
>> please review this small patch that changes the CODE_TOOLS_URL in 
>> make/build-all.sh to https://git.openjdk.java.net instead of 
>> http://hg.openjdk.java.net/code-tools. This change is needed to allow 
>> JTReg's OpenJDK dependencies JTHarness [0], asmtools [1] and JCov [3] 
>> to transition to Git if they so choose.
>>
>> I also made the CODE_TOOLS_URL variable user configurable so those 
>> that wish to continue to use https://hg.openjdk.java.net/code-tools 
>> can do so by running:
>>
>>   CODE_TOOLS_URL=https://hg.openjdk.java.net/code-tools \
>>   bash make/build-all.sh
>>
>> Issue:
>> https://bugs.openjdk.java.net/browse/CODETOOLS-7902637
>>
>> Webrev:
>> http://cr.openjdk.java.net/~ehelin/7902637/00/
>>
>> Testing:
>> I manually tested running the following on Linux x64 with satisfactory 
>> results:
>> - bash make/build-all.sh
>> - CODE_TOOLS_URL=https://hg.openjdk.java.net/code-tools \
>>   bash make/build-all.sh
>>
>> Thanks,
>> Erik
>>
>> PS. I have not yet gotten the confirmation that I'm subscribed to 
>> jtreg-dev so please CC me on any replies.
>>
>> [0]: https://hg.openjdk.java.net/code-tools/jtharness
>> [1]: https://hg.openjdk.java.net/code-tools/asmtools
>> [2]: https://hg.openjdk.java.net/code-tools/jcov



More information about the jtreg-dev mailing list