Suggestion: make jtdiff more flexible on summary file naming
Jonathan Gibbons
jonathan.gibbons at oracle.com
Mon Nov 16 16:36:29 UTC 2020
Tiago,
It is not so much that jtreg is being strict as much as it is about
looking at the argument and inferring the kind of content, based
on the standard output generated by the main jtreg tool.
It would probably be reasonable to provide a way to force the
command-line arguments to be treated as summary files.
-- Jon
On 11/16/20 7:10 AM, Tiago Daitx wrote:
> Hi,
>
> Currently jtdift is very strict about the naming of a summary.txt
> file. In src/share/classes/com/sun/javatest/diff/ReportReader.java it
> uses file.getName().equals(SUMMARY_TXT) twice. Is there a particular
> reason for it being that strict about the file name?
>
> Assuming there is no need for it to be so strict, would it be
> acceptable to make it a tad more flexible? My first suggestion would
> be replacing the equals with endsWith(). And the second one would be
> adding some extra logic (system/java property, command line argument)
> that will either ignore the 'equals()' check or use something else
> instead.
>
> As for a use case, I don't have anything particularly strong on this.
> In some situations I find it easier to manage files with a particular
> naming convention than having each of them in their own separate
> directories.
>
> Best regards,
> Tiago
>
More information about the jtreg-dev
mailing list