Suggestion: make jtdiff more flexible on summary file naming

Jonathan Gibbons jonathan.gibbons at oracle.com
Mon Nov 16 18:47:54 UTC 2020


I think a command line option would be better, so that it shows up in 
command-line help.  I haven't looked at the code to see the best form of 
such as option, but I envisage two possibilities:

1. A boolean flag that declares that the file args are summary files. 
This allows flexibility for summary files only.

2. An option that declares the kind of the file args. This allows 
flexibility for any of the supported file types.

-- Jon

On 11/16/20 10:21 AM, Tiago Daitx wrote:
> Hi Jonathan,
>
> On Mon, Nov 16, 2020 at 1:38 PM Jonathan Gibbons
> <jonathan.gibbons at oracle.com> wrote:
>> Tiago,
>>
>> It is not so much that jtreg is being strict as much as it is about
>> looking at the argument and inferring the kind of content, based
>> on the standard output generated by the main jtreg tool.
>>
>> It would probably be reasonable to provide a way to force the
>> command-line arguments to be treated as summary files.
> Is there any preference on doing that as another command line argument
> (so that it does show in --help) or could this be done as simply as
> looking for a system or java property?
>
> My only concern about doing it as a property is how to make people
> aware that it exists. Do you have any suggestions where that
> should/could be mentioned? Somewhere in the documentation? In or close
> to the "File not recognized" error message?
>
> I am willing to submit patches for this proposal, just trying to
> figure out what is considered an acceptable solution.
>
> Regards,
> Tiago
>
> --
> Tiago Stürmer Daitx
> Software Engineer
> tiago.daitx at canonical.com
>
> PGP Key: 4096R/F5B213BE (hkp://keyserver.ubuntu.com)
> Fingerprint = 45D0 FE5A 8109 1E91 866E  8CA4 1931 8D5E F5B2 13BE


More information about the jtreg-dev mailing list