From jonathan.gibbons at oracle.com Tue Sep 1 22:20:03 2020 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 01 Sep 2020 22:20:03 +0000 Subject: hg: code-tools/jtreg: 8 new changesets Message-ID: <202009012220.081MK3kd020360@aojmv0008.oracle.com> Changeset: 11871ddad808 Author: jjg Date: 2020-08-31 10:41 -0700 URL: https://hg.openjdk.java.net/code-tools/jtreg/rev/11871ddad808 ifdef tests using $(ANT) ! test/6533043/T6533043.gmk ! test/6533074/T6533074.gmk ! test/vmopts/TestVMOpts.gmk Changeset: a894c5fc4170 Author: jjg Date: 2020-08-31 10:55 -0700 URL: https://hg.openjdk.java.net/code-tools/jtreg/rev/a894c5fc4170 7902754: jtreg should use -source instead of --release for @enablePreview ! src/share/classes/com/sun/javatest/regtest/exec/CompileAction.java Changeset: 0f3dc54faef8 Author: jjg Date: 2020-08-31 12:57 -0700 URL: https://hg.openjdk.java.net/code-tools/jtreg/rev/0f3dc54faef8 lower expected os.maxSwap to 0 in RequiresTest ! test/requires/ExprTest.java Changeset: 9cd94a1da3a8 Author: jjg Date: 2020-08-31 13:37 -0700 URL: https://hg.openjdk.java.net/code-tools/jtreg/rev/9cd94a1da3a8 set property test.enable.preview or env var TESTENABLEPREVIEW for benefit of driver tests ! src/share/classes/com/sun/javatest/regtest/exec/RegressionScript.java ! src/share/classes/com/sun/javatest/regtest/exec/ShellAction.java ! src/share/doc/javatest/regtest/tag-spec.html Changeset: 895036acdea2 Author: jjg Date: 2020-08-31 17:52 -0700 URL: https://hg.openjdk.java.net/code-tools/jtreg/rev/895036acdea2 set --gnu-emacs true -q for tidy ! test/docs.gmk Changeset: 0c640b1cd602 Author: jjg Date: 2020-09-01 09:35 -0700 URL: https://hg.openjdk.java.net/code-tools/jtreg/rev/0c640b1cd602 initial support for new-style version numbers for jtreg ! make/Rules.gmk ! src/share/classes/com/sun/javatest/regtest/tool/Help.java + src/share/classes/com/sun/javatest/regtest/tool/RuntimeVersion.java ! src/share/classes/com/sun/javatest/regtest/tool/Tool.java ! src/share/classes/com/sun/javatest/regtest/tool/Version.java ! src/share/classes/com/sun/javatest/regtest/tool/i18n.properties Changeset: 92c611c22ff5 Author: jjg Date: 2020-09-01 14:27 -0700 URL: https://hg.openjdk.java.net/code-tools/jtreg/rev/92c611c22ff5 7902748: Improve diagnostic output when failing to get version for JDK under test ! src/share/classes/com/sun/javatest/regtest/config/JDK.java ! src/share/classes/com/sun/javatest/regtest/config/Locations.java ! src/share/classes/com/sun/javatest/regtest/config/RegressionContext.java ! src/share/classes/com/sun/javatest/regtest/config/RegressionParameters.java ! src/share/classes/com/sun/javatest/regtest/config/RegressionTestSuite.java ! src/share/classes/com/sun/javatest/regtest/exec/RegressionScript.java ! src/share/classes/com/sun/javatest/regtest/tool/Tool.java ! test/basic/Basic.java ! test/jdkModulesTest/JDKModulesTest.java Changeset: 9acb97db5867 Author: jjg Date: 2020-09-01 15:18 -0700 URL: https://hg.openjdk.java.net/code-tools/jtreg/rev/9acb97db5867 add support for new zip bundle names ! make/Defs.gmk ! make/Makefile ! make/Rules.gmk ! make/jtreg.gmk From jonathan.gibbons at oracle.com Tue Sep 15 22:31:38 2020 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 15 Sep 2020 22:31:38 +0000 Subject: hg: code-tools/jtreg: 7902765: New build script: Separate specification of version info from download code Message-ID: <202009152231.08FMVc0q017659@aojmv0008.oracle.com> Changeset: ff9fdaab4344 Author: jjg Date: 2020-09-15 15:23 -0700 URL: https://hg.openjdk.java.net/code-tools/jtreg/rev/ff9fdaab4344 7902765: New build script: Separate specification of version info from download code Contributed-by: mikael.vidstedt at oracle.com, jonathan.gibbons at oracle.com ! README + README-new.md + make/build-support/asmtools/build.sh + make/build-support/asmtools/version-numbers + make/build-support/build-common.sh + make/build-support/jcov/build.sh + make/build-support/jcov/version-numbers + make/build-support/jtharness/build.sh + make/build-support/jtharness/version-numbers + make/build-support/version-numbers + make/build.sh From igor.ignatyev at oracle.com Thu Sep 17 21:10:45 2020 From: igor.ignatyev at oracle.com (Igor Ignatyev) Date: Thu, 17 Sep 2020 14:10:45 -0700 Subject: RFR : 7902707 : user modules can be used only in othervm Message-ID: <49DB7F8C-9D89-4630-90EF-A7B6DC1DF7D6@oracle.com> http://cr.openjdk.java.net/~iignatyev//CODETOOLS-7902707/webrev.00 > 230 lines changed: 175 ins; 27 del; 28 mod; Hi all, could you please review this patch which makes it possible to use user modules in agentvm? from JBS: > usage of user modules leads to CNF if a test is run in agentvm, because jtreg doesn't communicate module path to agents. > > A similar problem exists in driver actions, even in othervm execution mode, as DriverAction filters out --module-path and other related flags (rerun section, though, has them listed which made it hard to comprehend) the patch include the following changes: - extend DO_MAIN operation message to include module-path and add-module list; - if an agent gets a not empty modulepath, it constructs ModuleLayer is constructed using this path, and uses the loader from this layer instead of system loader; - --module-path and --add-module are recorded in rerun section; - for driver, --module-path, --add-modules, --add-exports, --add-opens are exempted from filtering. I should notice that the driver part change is debatable, yet I'd argue the new behavior doesn't contradict the tag spec or any other official jtreg documentations and is less surprising. JBS: https://bugs.openjdk.java.net/browse/CODETOOLS-7902707 webrev: http://cr.openjdk.java.net/~iignatyev//CODETOOLS-7902707/webrev.00 Thanks, -- Igor From igor.ignatyev at oracle.com Tue Sep 22 17:57:08 2020 From: igor.ignatyev at oracle.com (Igor Ignatyev) Date: Tue, 22 Sep 2020 10:57:08 -0700 Subject: RFR : 7902707 : user modules can be used only in othervm In-Reply-To: <49DB7F8C-9D89-4630-90EF-A7B6DC1DF7D6@oracle.com> References: <49DB7F8C-9D89-4630-90EF-A7B6DC1DF7D6@oracle.com> Message-ID: <6B8523B8-EFE6-42FD-9B16-899E0FB31147@oracle.com> ping? > On Sep 17, 2020, at 2:10 PM, Igor Ignatyev wrote: > > http://cr.openjdk.java.net/~iignatyev//CODETOOLS-7902707/webrev.00 >> 230 lines changed: 175 ins; 27 del; 28 mod; > > > Hi all, > > could you please review this patch which makes it possible to use user modules in agentvm? > from JBS: >> usage of user modules leads to CNF if a test is run in agentvm, because jtreg doesn't communicate module path to agents. >> >> A similar problem exists in driver actions, even in othervm execution mode, as DriverAction filters out --module-path and other related flags (rerun section, though, has them listed which made it hard to comprehend) > > the patch include the following changes: > - extend DO_MAIN operation message to include module-path and add-module list; > - if an agent gets a not empty modulepath, it constructs ModuleLayer is constructed using this path, and uses the loader from this layer instead of system loader; > - --module-path and --add-module are recorded in rerun section; > - for driver, --module-path, --add-modules, --add-exports, --add-opens are exempted from filtering. > > I should notice that the driver part change is debatable, yet I'd argue the new behavior doesn't contradict the tag spec or any other official jtreg documentations and is less surprising. > > JBS: https://bugs.openjdk.java.net/browse/CODETOOLS-7902707 > webrev: http://cr.openjdk.java.net/~iignatyev//CODETOOLS-7902707/webrev.00 > > Thanks, > -- Igor