RFR: 7902912: Update IntelliJ Plugin build Readme [v2]
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Fri Apr 30 13:48:00 UTC 2021
On Fri, 30 Apr 2021 13:42:20 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Hi, may I have reviews for this small documentation fix please? I am not a CODETOOLS committer so I may need someone to sponsor this fix.
>>
>> Since I just built the intellij plugin in 2020.3, I stumbled about a couple of ambiguous infos which are not immediately clear to outsiders.
>>
>> -> some UI features changed in Intellij
>> -> Clarified the meaning of JTREG_HOME
>> -> One thing I was not sure about was the required SDK level to build the plugin. The documentation says "Any JDK 8 is fine" which I took as "JDK8 is required" - proceeded to download JDK 8 but then I was unable to choose this JDK as a SDK for the IDEA JDK. It was, however, happy with a JDK 15 I gave it, and proceeded to build the plugin without any issues. Therefore I changed the sentence to "Any JDK 8++ is a fine choice".
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>
> Update plugins/idea/README.md
>
> Co-authored-by: Maurizio Cimadamore <54672762+mcimadamore at users.noreply.github.com>
you have to `/integrate` I think then I can sponsor
-------------
PR: https://git.openjdk.java.net/jtreg/pull/8
More information about the jtreg-dev
mailing list