RFR: Fix a crash with IntelliJ 2020.2 [v2]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Mon Mar 22 11:37:44 UTC 2021


On Sat, 20 Mar 2021 01:17:51 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> com.intellij.diagnostic.PluginException: Class constructor must not have parameters: com.oracle.plugin.jtreg.service.ui.JTRegServiceConfigurable [Plugin: jtreg]
>> 	at com.intellij.serviceContainer.ComponentManagerImpl.instantiateExtensionWithPicoContainerOnlyIfNeeded(ComponentManagerImpl.kt:696)
>> 	at com.intellij.openapi.options.ConfigurableEP$ClassProducer.createElement(ConfigurableEP.java:422)
>> 	at com.intellij.openapi.options.ConfigurableEP.createConfigurable(ConfigurableEP.java:329)
>> 	at com.intellij.openapi.options.ex.ConfigurableWrapper.createConfigurable(ConfigurableWrapper.java:45)
>
> Liam Miller-Cushon has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.

Looks good - typically we add notes of what changed in the plugin file (resources/plugin.xml) and we bump the version number.
Also, I suspect this fix has some implication when it comes to backward compatibility - currently we state:
`    <idea-version since-build="162.0"/>`
Should we rectify that?

-------------

PR: https://git.openjdk.java.net/jtreg/pull/5


More information about the jtreg-dev mailing list