RFR: 7902859: Fix a crash with IntelliJ 2020.2 [v2]

Liam Miller-Cushon cushon at openjdk.java.net
Mon Mar 22 19:01:46 UTC 2021


On Mon, 22 Mar 2021 11:40:35 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Looks good - typically we add notes of what changed in the plugin file (resources/plugin.xml) and we bump the version number.
>> Also, I suspect this fix has some implication when it comes to backward compatibility - currently we state:
>> `    <idea-version since-build="162.0"/>`
>> Should we rectify that?
>
> Btw - this also needs a bug to be opened under the CodeTools project (tool = jtreg).

Thanks!

I filed the bug, and updated the note and version number in `resources/plugin.xml`.

> Also, I suspect this fix has some implication when it comes to backward compatibility - currently we state: `<idea-version since-build="162.0"/>`

I tried downloading 162.0 / 2016.2, the I can still install the new plugin and load the preference pane without an error, so I think this change is backwards compatible. I don't know very much about IntelliJ plugins, though, and I can do more investigation if there's anything you'd recommend verifying? Alternately I can just bump the version in `<idea-version>` if you think everyone using the plugin is likely to be on a more recent version of IntelliJ at this point?

-------------

PR: https://git.openjdk.java.net/jtreg/pull/5


More information about the jtreg-dev mailing list