RFR: 7902924: Add build script for jtreg plugin [v4]

[Maurizio Cimadamore]

On Wed, 5 May 2021 18:16:06 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update jtreg root to point to non-existent folder
>>  - Exclude IntelliJ project files
>
> plugins/idea/README.md line 2:
> 
>> 1: # jtreg plugin for IntelliJ IDE
>> 2: ##### *Maurizio Cimadamore and Chris Hegarty, September 2016, version 0.4*
> 
> Can you change the wording of the version number in the README.md file so that it's clear that the version number is of the README, not the resulting binary.  Or better yet, maybe also include the version of the current binary?

If that helps I can remove the versioning all together. I don't want to add a dependency between the file and the plugin version - that's what we have `git` for: if you browse files on Github you will always see a README that is in sync with whatever version the plugin is at (which can be checked by looking at the gradle build file).

> plugins/idea/README.md line 53:
> 
>> 51: 
>> 52: > Note: the property `intellijVersion` can be used to specify which IDE version should the plugin depend on (defaults to `2021.1`).
>> 53: 
> 
> Please mention that if you're behind a proxy, you'll need to configure the Java network settings.
> 
>     `-Dhttps.proxyhost=<yourProxy> -Dhttps.proxyPort=<yourProxyPort>`

or, should we just link here?
https://docs.gradle.org/current/userguide/build_environment.html#sec:accessing_the_web_via_a_proxy

> Several comments here:
> 
>     1. The addition in the filename "-gradle" is a little confusing, is it really necessary?

I didn't do anything to add that - maybe it can be removed, I'll check
> 
>     2. There are two jar files in my resulting build directory, you have to compare them to know they are the same.  Just adds a speedbump for someone trying for the first time.

The README talks about `build/distributions`. In there there is just _one_ file:

build/distributions/jtreg-plugin-gradle-1.12.zip

That is the plugin that should be installed.

> 
> 
> ./build/libs/jtreg-plugin-gradle-1.12.jar
> ./build/idea-sandbox/plugins/jtreg-plugin-gradle/lib/jtreg-plugin-gradle-1.12.jar
> 
>     1. IntelliJ can also install a .zip file, but you said to install the jar file.  Is it possible to not build the .zip file?

The zip file is the one to install. I'll drop references to `jar` and replace with `zip`

> 
> 
> ./build/distributions/jtreg-plugin-gradle-1.12.zip
> 
>     1. Lastly, I built the plugin with my default JDK 16 (60.0), but apparently Intellij IDEA 2021.1 only recognized up to JDK 11 (55.0) and hung after throwing up a popup.  You might want to -target 11?

I'll check that.

> plugins/idea/README.md line 101:
> 
>> 99: 
>> 100: > Note: debugging only works with a _single_ test action (e.g. `@run` or `@compile`). If multiple test actions are present, debugging will not work correctly. This is a known issue. To workaround, please manually remove the test actions that do not need to be debugged. 
>> 101: 
> 
> That is, once a `@compile file.java` has been built, `@compile` can be temporarily removed from the test source so the debugger can debug the `@run test`.
> 
> You might also include that @build isn't counted as a test action, and can coexist with an @run.

ok

-------------

PR: https://git.openjdk.java.net/jtreg/pull/9