RFR: 7902924: Add build script for jtreg plugin [v4]

[Bradford Wetmore]

On Wed, 5 May 2021 20:43:31 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> plugins/idea/README.md line 60:
>> 
>>> 58: ### Installing the plugin
>>> 59: 
>>> 60: To install the plugin in your IDE, first you need to build a plugin module file (a `.jar` file), as described in the previous section.
>> 
>> Several comments here:
>> 
>> 1.  The addition in the filename "-gradle" is a little confusing, is it really necessary?
>> 
>> 2.  There are two jar files in my resulting build directory, you have to compare them to know they are the same.  Just adds a speedbump for someone trying for the first time.
>> 
>> ./build/libs/jtreg-plugin-gradle-1.12.jar
>> ./build/idea-sandbox/plugins/jtreg-plugin-gradle/lib/jtreg-plugin-gradle-1.12.jar
>> 
>> 3.  IntelliJ can also install a .zip file, but you said to install the jar file.  Is it possible to not build the .zip file?
>> 
>> ./build/distributions/jtreg-plugin-gradle-1.12.zip
>> 
>> 4.  Lastly, I built the plugin with my default JDK 16 (60.0), but apparently Intellij IDEA 2021.1 only recognized up to JDK 11 (55.0) and hung after throwing up a popup.  You might want to -target 11?
>
>> Several comments here:
>> 
>>     1. The addition in the filename "-gradle" is a little confusing, is it really necessary?
> 
> I didn't do anything to add that - maybe it can be removed, I'll check
>> 
>>     2. There are two jar files in my resulting build directory, you have to compare them to know they are the same.  Just adds a speedbump for someone trying for the first time.
> 
> The README talks about `build/distributions`. In there there is just _one_ file:
> 
> build/distributions/jtreg-plugin-gradle-1.12.zip
> 
> That is the plugin that should be installed.
> 
>> 
>> 
>> ./build/libs/jtreg-plugin-gradle-1.12.jar
>> ./build/idea-sandbox/plugins/jtreg-plugin-gradle/lib/jtreg-plugin-gradle-1.12.jar
>> 
>>     1. IntelliJ can also install a .zip file, but you said to install the jar file.  Is it possible to not build the .zip file?
> 
> The zip file is the one to install. I'll drop references to `jar` and replace with `zip`
> 
>> 
>> 
>> ./build/distributions/jtreg-plugin-gradle-1.12.zip
>> 
>>     1. Lastly, I built the plugin with my default JDK 16 (60.0), but apparently Intellij IDEA 2021.1 only recognized up to JDK 11 (55.0) and hung after throwing up a popup.  You might want to -target 11?
> 
> I'll check that.

Missed the zip, I probably just read it as jar since you talked about building the jar in the para above.

-------------

PR: https://git.openjdk.java.net/jtreg/pull/9