RFR: 7902924: Add build script for jtreg plugin [v8]

Bradford Wetmore wetmore at openjdk.java.net
Wed May 5 22:15:00 UTC 2021


On Wed, 5 May 2021 21:22:21 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This patch adds support for building the jtreg plugin with gradle.
>> 
>> This is a much more stable way to build the plugin, as the IntelliJ build dependency is automatically downloaded by gradle.
>> 
>> The build relies on the IntelliJ support for gradle-ized plugins:
>> 
>> https://github.com/JetBrains/gradle-intellij-plugin
>> 
>> Which is officially supported by JetBrains, see:
>> 
>> https://plugins.jetbrains.com/docs/intellij/gradle-build-system.html
>> 
>> 
>> The only thing that needs to be done by developers before firing up a gradle build, is to specify the path of a jtreg root in the gradle.properties file. Everything else should work out of the box.
>> 
>> I have also updated build instructions to reflect the new build system.
>> 
>> Please let me know if this is an improvement over the build steps we had before (I think it is, but I have not tested this extensively).
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update README.md
>   
>   dropped reference to .idea folder

Latest README changes look good.

plugins/idea/README.md line 37:

> 35: > `-Dhttps.proxyhost=<proxyServer> -Dhttps.proxyPort=<proxyPort>`
> 36: 
> 37: This will download the required IntelliJ dependencies, will build the plugin and will place the results in the `build/distributions` folder.

Maybe:  

This will download gradle and the required IntelliJ dependencies...

plugins/idea/README.md line 51:

> 49: To install the plugin in your IDE, first you need to build a plugin module file (a `.zip` file), as described in the previous section.
> 50: 
> 51: Once the plugin jar has been obtained, it can be installed in the IDE; go in `Help -> Find Action...`, and type `Install plugin from disk`, and then select the corresponding action from the drop down list. A new file dialog will pop up: point the IDE to the zip file you have created in the step above. The IDE will require a restart - once restart is completed the installation process is completed, and the plugin is ready to be used to run and debug jtreg tests.

"...plugin jar has been obtained, it can be installed..."

Should be zip?

-------------

PR: https://git.openjdk.java.net/jtreg/pull/9


More information about the jtreg-dev mailing list